fix(support): let portal users change only the issues they raised

This commit is contained in:
Nabin Hait
2026-10-21 12:03:41 +05:30
parent d77dc849fb
commit 06e36cf801
2 changed files with 23 additions and 2 deletions
+4 -2
View File
@@ -306,9 +306,11 @@ def auto_close_tickets():
def has_website_permission(doc, ptype, user, verbose=False):
from erpnext.controllers.website_list_for_contact import has_website_permission
permission_based_on_customer = has_website_permission(doc, ptype, user, verbose)
if doc.raised_by == user:
return True
return permission_based_on_customer or doc.raised_by == user
# other issues of the customer can be viewed, but only the user's own issues can be changed
return ptype in ("read", "print") and has_website_permission(doc, ptype, user, verbose)
def update_issue(contact, method):
@@ -273,6 +273,25 @@ class TestIssue(TestSetUp):
self.assertEqual(issue.first_responded_on, frappe.flags.current_time)
self.assertEqual(issue.agreement_status, "Resolution Due")
def test_portal_user_changes_only_own_issues(self):
from erpnext.tests.permission_test_utils import as_user, make_fenced_user
user = make_fenced_user("_test_issue_portal_customer@example.com", ["Customer"])
customer = frappe.get_doc("Customer", "_Test Customer")
if user not in [row.user for row in customer.portal_users]:
customer.append("portal_users", {"user": user})
customer.save()
staff_issue = make_issue(customer="_Test Customer", index=1).name
own_issue = make_issue(customer="_Test Customer", index=2).name
frappe.db.set_value("Issue", own_issue, "raised_by", user)
staff_issue, own_issue = frappe.get_doc("Issue", staff_issue), frappe.get_doc("Issue", own_issue)
with as_user(user):
self.assertTrue(frappe.has_website_permission(staff_issue, "read"))
self.assertFalse(frappe.has_website_permission(staff_issue, "write"))
self.assertFalse(frappe.has_website_permission(staff_issue, "delete"))
self.assertTrue(frappe.has_website_permission(own_issue, "write"))
class TestFirstResponseTime(TestSetUp):
# working hours used in all cases: Mon-Fri, 10am to 6pm