ext/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-10-31 23:07:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(stock): scale disassembly tolerance by the source conversion factor

Browse Source 
The row's conversion factor is editable, so a large one widened the tolerance without limit.

(cherry picked from commit a890c77fa0)
This commit is contained in:
Mihir Kandoi
2026-10-23 12:16:51 +05:30
committed by pandiyan
parent b8421d8446
commit 08d21e44c7
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
erpnext/stock/doctype/stock_entry/stock_entry.py
+5 -5
View File
@@ -1103,7 +1103,7 @@ class StockEntry(StockController):
expected_by_name, expected_by_item = {}, defaultdict(float)
for source_row, qty in expected_rows:
if source_row.get("name"):
expected_by_name[source_row.name] = qty
expected_by_name[source_row.name] = (qty, flt(source_row.conversion_factor))
expected_by_item[source_row.item_code] += qty
precision = frappe.get_precision("Stock Entry Detail", "transfer_qty")
@@ -1116,9 +1116,9 @@ class StockEntry(StockController):
continue # covered by validate_finished_good_consumption
if row.ste_detail and row.ste_detail in expected_by_name:
expected = expected_by_name[row.ste_detail]
expected, conversion_factor = expected_by_name[row.ste_detail]
elif row.item_code in expected_by_item:
expected = expected_by_item[row.item_code]
expected, conversion_factor = expected_by_item[row.item_code], 1
else:
frappe.throw(
_(
@@ -1128,8 +1128,8 @@ class StockEntry(StockController):
title=_("Invalid Disassembly Item"),
)
# qty is rounded in the row UOM, so allow that rounding scaled to stock UOM
row_tolerance = max(tolerance, qty_tolerance * flt(row.conversion_factor))
# qty is rounded in the source UOM, so allow that rounding scaled to stock UOM
row_tolerance = max(tolerance, qty_tolerance * conversion_factor)
if abs(flt(row.transfer_qty, precision) - flt(expected, precision)) > row_tolerance:
frappe.throw(
_(