ext/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-10-29 22:57:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(stock): round disassembly rows in the coarser whole-number UOM

Browse Source 
With both UOMs whole and a conversion factor below 1 (Nos at 0.5 Box),
whole Nos could still be half a Box.

(cherry picked from commit 9592d4103b)
This commit is contained in:
Mihir Kandoi
2026-10-22 02:10:46 +00:00
committed by Mergify
parent befecbb946
commit 306637fe9b
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
erpnext/stock/doctype/stock_entry/services/disassemble.py
+7 -4
View File
@@ -27,11 +27,14 @@ def _qty_tolerance(precision: int) -> float:
def get_whole_number_units(row) -> tuple[float, float] | None:
"""Row qty in its whole-number UOM and the stock qty of one such unit, or None when any qty is allowed."""
if cint(frappe.get_cached_value("UOM", row.uom, "must_be_whole_number")):
return flt(row.qty), flt(row.conversion_factor)
if cint(frappe.get_cached_value("UOM", row.stock_uom, "must_be_whole_number")):
"""Row qty in its coarser whole-number UOM and the stock qty of one such unit, or None when any
qty is allowed. Rounding in the finer unit can leave a fraction of the coarser one."""
uom_is_whole = cint(frappe.get_cached_value("UOM", row.uom, "must_be_whole_number"))
stock_uom_is_whole = cint(frappe.get_cached_value("UOM", row.stock_uom, "must_be_whole_number"))
if stock_uom_is_whole and (not uom_is_whole or flt(row.conversion_factor) < 1):
return flt(row.transfer_qty), 1.0
if uom_is_whole:
return flt(row.qty), flt(row.conversion_factor)
return None