ext/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-10-29 22:57:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(stock): reject disassemblies missing a component they now owe

Browse Source 
(cherry picked from commit 519aa05076)
This commit is contained in:
Mihir Kandoi
2026-10-22 02:10:45 +00:00
committed by Mergify
parent 1f2a148b55
commit 32f1c39fb4
1 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
erpnext/stock/doctype/stock_entry/services/disassemble.py
+19 -2
View File
@@ -98,15 +98,19 @@ class DisassembleStockEntry(BaseStockEntry):
return self.validate_materials_against_bom()
progress = self.get_disassembly_progress(source_fg_qty)
expected_rows = [
(source_row, self.get_component_stock_qty(source_row, progress))
for source_row in self.get_items_from_manufacture_stock_entry()
]
expected_by_name, expected_by_item = {}, defaultdict(float)
for source_row in self.get_items_from_manufacture_stock_entry():
qty = self.get_component_stock_qty(source_row, progress)
for source_row, qty in expected_rows:
if source_row.get("name"):
expected_by_name[source_row.name] = qty
expected_by_item[source_row.item_code] += qty
precision = frappe.get_precision("Stock Entry Detail", "transfer_qty")
tolerance = _qty_tolerance(precision)
self.validate_no_missing_components(expected_rows, precision, tolerance)
for row in self.doc.items:
if row.is_finished_item:
@@ -166,6 +170,19 @@ class DisassembleStockEntry(BaseStockEntry):
title=_("Invalid Disassembly Quantity"),
)
def validate_no_missing_components(self, expected_rows, precision, tolerance):
"""A draft made before another disassembly was submitted can lack a component it now owes."""
present = {row.ste_detail or row.item_code for row in self.doc.items}
for source_row, qty in expected_rows:
key = source_row.get("name") or source_row.item_code
if not source_row.is_finished_item and flt(qty, precision) > tolerance and key not in present:
frappe.throw(
_("Item {0} is missing from this disassembly. Get the items again.").format(
frappe.bold(source_row.item_code)
),
title=_("Missing Disassembly Item"),
)
def get_received_component_qty(self) -> dict:
received_qty = defaultdict(float)
for row in self.doc.items: