ext/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-10-29 22:57:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(assets): validate asset when fetching capitalization asset details

Browse Source
This commit is contained in:
khushi8112
2026-10-26 16:23:05 +05:30
parent 0a3b4e33d3
commit 42ef0cd403
1 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
erpnext/assets/doctype/asset_capitalization/asset_capitalization.py
+2 -9
View File
@@ -753,9 +753,8 @@ def get_target_asset_details(asset=None, company=None):
# Get Asset Details
asset_details = frappe._dict()
if asset:
erpnext.require_permission("Asset", asset, "select")
asset_details = frappe.db.get_value("Asset", asset, ["asset_name", "item_code"], as_dict=1)
if not asset_details:
frappe.throw(_("Asset {0} does not exist").format(asset))
# Re-set item code from Asset
out.target_item_code = asset_details.item_code
@@ -856,20 +855,14 @@ def get_consumed_asset_details(args):
args = frappe._dict(args)
# and the Asset the caller named: its depreciation values are returned through the unguarded
# _get_asset_value_after_depreciation. select-or-read, as in the asset.py wrapper.
if args.get("asset"):
ptype = "select" if frappe.only_has_select_perm("Asset") else "read"
frappe.has_permission("Asset", ptype, doc=args.get("asset"), throw=True)
out = frappe._dict()
asset_details = frappe._dict()
if args.asset:
erpnext.require_permission("Asset", args.asset, "select")
asset_details = frappe.db.get_value(
"Asset", args.asset, ["asset_name", "item_code", "item_name"], as_dict=1
)
if not asset_details:
frappe.throw(_("Asset {0} does not exist").format(args.asset))
out.item_code = asset_details.item_code
out.asset_name = asset_details.asset_name