ext/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-10-29 22:57:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(stock): validate disassembly qty with the rounding used to populate it

Browse Source 
A tolerance scaled by the conversion factor accepted a one-unit edit in the row UOM, e.g. an extra 1 Nos per Box of 1000.

(cherry picked from commit ad54aa2ae6)
This commit is contained in:
Mihir Kandoi
2026-10-23 12:16:52 +05:30
committed by pandiyan
parent d5477f6107
commit 54d7b85879
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
erpnext/stock/doctype/stock_entry/stock_entry.py
+4 -4
View File
@@ -1108,7 +1108,7 @@ class StockEntry(StockController):
precision = frappe.get_precision("Stock Entry Detail", "transfer_qty")
tolerance = _qty_tolerance(precision)
qty_tolerance = _qty_tolerance(frappe.get_precision("Stock Entry Detail", "qty"))
qty_precision = frappe.get_precision("Stock Entry Detail", "qty")
self.validate_no_missing_components(expected_rows, precision, tolerance)
for row in self.items:
@@ -1128,9 +1128,9 @@ class StockEntry(StockController):
title=_("Invalid Disassembly Item"),
)
# qty is rounded in the source UOM, so allow that rounding scaled to stock UOM
row_tolerance = max(tolerance, qty_tolerance * conversion_factor)
if abs(flt(row.transfer_qty, precision) - flt(expected, precision)) > row_tolerance:
# rows are populated with qty rounded in the source UOM, so expect the same rounding
expected = flt(expected / conversion_factor, qty_precision) * conversion_factor
if abs(flt(row.transfer_qty, precision) - flt(expected, precision)) > tolerance:
frappe.throw(
_(
"Row #{0}: Item {1} quantity ({2} in stock UOM) does not match the quantity "