fix(manufacturing): take field labels from meta in serial no series error

(cherry picked from commit a154980afe)

# Conflicts:
#	erpnext/manufacturing/doctype/work_order/test_work_order.py
#	erpnext/manufacturing/doctype/work_order/work_order.py
This commit is contained in:
Mihir Kandoi
2026-10-26 09:29:37 +00:00
committed by Mergify
parent d6432c9746
commit 9002132cc0
2 changed files with 8981 additions and 0 deletions
File diff suppressed because it is too large Load Diff
@@ -693,6 +693,7 @@ class WorkOrder(Document):
serial_nos = get_available_serial_nos(item_details.serial_no_series, self.qty)
=======
if not item_details.serial_no_series:
<<<<<<< HEAD
frappe.throw(
_("Set Serial No Series in Item {0} or disable {1} in {2}").format(
get_link_to_form("Item", self.production_item),
@@ -702,6 +703,9 @@ class WorkOrder(Document):
title=_("Serial No Series Missing"),
)
>>>>>>> 52f1f52 (fix(manufacturing): require serial no series on work order submit)
=======
self.throw_missing_serial_no_series()
>>>>>>> a154980 (fix(manufacturing): take field labels from meta in serial no series error)
serial_nos = get_available_serial_nos(
item_details.serial_no_series, qty or self.qty, self.production_item
@@ -827,6 +831,22 @@ class WorkOrder(Document):
if row.planned_start_time == row.planned_end_time:
frappe.throw(_("Capacity Planning Error, planned start time can not be same as end time"))
def throw_missing_serial_no_series(self):
frappe.throw(
_("Set {0} in Item {1} or disable {2} in {3}").format(
frappe.bold(_(frappe.get_meta("Item").get_label("serial_no_series"))),
get_link_to_form("Item", self.production_item),
frappe.bold(
_(
frappe.get_meta("Manufacturing Settings").get_label(
"make_serial_no_batch_from_work_order"
)
)
),
get_link_to_form("Manufacturing Settings", "Manufacturing Settings"),
)
)
def validate_cancel(self):
if self.status == "Stopped":
frappe.throw(_("Stopped Work Order cannot be cancelled, Unstop it first to cancel"))