From 0dc697044f8befee8d344837c6c0f2873db6f4dd Mon Sep 17 00:00:00 2001 From: Miguel Angel Simon Sierra Date: Sat, 19 Sep 2026 06:32:07 -0400 Subject: [PATCH] fix(scripts): the capture checker time limit covers every step The limit is now one budget per video shared by ffprobe, ffmpeg and the comparison, checked on every frame pair so a large --window cannot run past it. A timed-out tool is killed with its whole process group, so a shell-wrapper ffmpeg leaves no orphan. --timeout is capped below the Node timer limit and inherited option names are rejected. --- scripts/check-capture-reversion.mjs | 83 ++++++++++++------------ scripts/check-capture-reversion.test.mjs | 50 +++++++++++++- 2 files changed, 92 insertions(+), 41 deletions(-) diff --git a/scripts/check-capture-reversion.mjs b/scripts/check-capture-reversion.mjs index 2bf4fa739e..c0e182167c 100644 --- a/scripts/check-capture-reversion.mjs +++ b/scripts/check-capture-reversion.mjs @@ -9,6 +9,7 @@ import { fileURLToPath } from "node:url"; const WIDTH = 96; const DEFAULT_TIMEOUT_S = 120; +const MAX_TIMEOUT_S = 86400; const USAGE = "usage: node scripts/check-capture-reversion.mjs [--crop=W:H:X:Y] [--window=N] [--change=D] [--same=D] [--timeout=S]