ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-07 10:06:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(engine): skip unnecessary dimension pad (#2398)

Browse Source
This commit is contained in:
Miguel Ángel
2026-07-14 00:42:16 -04:00
committed by GitHub
parent 90be05019b
commit 0dfc85b680
6 changed files with 89 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/engine/src/services/chunkEncoder.test.ts
+30 -2
View File
@@ -894,7 +894,17 @@ describe("buildEncoderArgs color space", () => {
);
const vfIdx = args.indexOf("-vf");
expect(vfIdx).toBeGreaterThan(-1);
expect(args[vfIdx + 1]).toContain("scale=in_range=pc:out_range=tv");
expect(args[vfIdx + 1]).toBe("scale=in_range=pc:out_range=tv");
});
it("adds the pad after range conversion for odd CPU output dimensions", () => {
const args = buildEncoderArgs(
{ ...baseOptions, height: 1081, codec: "h264", preset: "medium", quality: 23 },
inputArgs,
"out.mp4",
);
const vfIdx = args.indexOf("-vf");
expect(args[vfIdx + 1]).toBe("scale=in_range=pc:out_range=tv,pad=ceil(iw/2)*2:ceil(ih/2)*2");
});
it("prepends range conversion to VAAPI filter chain", () => {
@@ -912,7 +922,14 @@ describe("buildEncoderArgs color space", () => {
it("pads odd dimensions (no range scale) for non-VAAPI GPU encoding", () => {
for (const gpu of ["nvenc", "videotoolbox", "qsv", "amf"] as const) {
const args = buildEncoderArgs(
{ ...baseOptions, codec: "h264", preset: "medium", quality: 23, useGpu: true },
{
...baseOptions,
height: 1081,
codec: "h264",
preset: "medium",
quality: 23,
useGpu: true,
},
inputArgs,
"out.mp4",
gpu,
@@ -927,10 +944,21 @@ describe("buildEncoderArgs color space", () => {
}
});
it("does not require the pad filter for even GPU output dimensions", () => {
const args = buildEncoderArgs(
{ ...baseOptions, codec: "h264", preset: "medium", quality: 23, useGpu: true },
inputArgs,
"out.mp4",
"videotoolbox",
);
expect(args).not.toContain("-vf");
});
it("pads odd dimensions for 10-bit (yuv420p10le) GPU HDR encoding", () => {
const args = buildEncoderArgs(
{
...baseOptions,
height: 1081,
codec: "h265",
preset: "medium",
quality: 23,