ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-07 10:06:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(engine): skip unnecessary dimension pad (#2398)

Browse Source
This commit is contained in:
Miguel Ángel
2026-07-14 00:42:16 -04:00
committed by GitHub
parent 90be05019b
commit 0dfc85b680
6 changed files with 89 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/engine/src/services/streamingEncoder.test.ts
+14 -1
View File
@@ -164,6 +164,14 @@ describe("buildStreamingArgs", () => {
expect(args[args.indexOf("-color_primaries:v") + 1]).toBe("bt709");
expect(args[args.indexOf("-colorspace:v") + 1]).toBe("bt709");
expect(args[args.indexOf("-color_range") + 1]).toBe("tv");
expect(args[args.indexOf("-vf") + 1]).toBe("scale=in_range=pc:out_range=tv");
});
it("adds the pad after range conversion for odd SDR output dimensions", () => {
const args = buildStreamingArgs({ ...baseSdr, height: 1081 }, "/tmp/out.mp4");
expect(args[args.indexOf("-vf") + 1]).toBe(
"scale=in_range=pc:out_range=tv,pad=ceil(iw/2)*2:ceil(ih/2)*2",
);
});
});
@@ -315,13 +323,18 @@ describe("buildStreamingArgs", () => {
// even-dim pad (and only the pad, not the SW range scale) must be added.
it("pads odd dimensions (no range scale) for non-VAAPI GPU encoding", () => {
for (const gpu of ["nvenc", "videotoolbox", "qsv", "amf"] as const) {
const args = buildStreamingArgs(baseGpu, "/tmp/out.mp4", gpu);
const args = buildStreamingArgs({ ...baseGpu, height: 1081 }, "/tmp/out.mp4", gpu);
const vfIdx = args.indexOf("-vf");
expect(args[vfIdx + 1]).toBe("pad=ceil(iw/2)*2:ceil(ih/2)*2");
expect(args[vfIdx + 1]).not.toContain("scale=in_range");
}
});
it("does not require the pad filter for even GPU output dimensions", () => {
const args = buildStreamingArgs(baseGpu, "/tmp/out.mp4", "videotoolbox");
expect(args).not.toContain("-vf");
});
it("prepends range conversion to VAAPI chain (nv12 covers even-dim)", () => {
const args = buildStreamingArgs(baseGpu, "/tmp/out.mp4", "vaapi");
const vfIdx = args.indexOf("-vf");