From 1a3330a972d98de09a93e4cf6d1a61fcc1a63cb1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miguel=20=C3=81ngel?= <miguel.sierra@heygen.com>
Date: Mon, 6 Jul 2026 18:19:35 -0400
Subject: [PATCH] fix(compiler): don't scan media tags inside comments/scripts;
 DOM-check auto-start (#1938) (#1940)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The timing compiler scanned raw HTML with tag regexes that weren't
comment-aware, so a comment or script merely mentioning `<video>`/`<audio>`
was rewritten as a real element — injecting id/data-start/data-hf-auto-start
into the comment text. That phantom attribute then tripped the probe stage's
substring check (`html.includes("data-hf-auto-start")`), launching an
unnecessary browser probe on every render with an unexplained empty reasons list.

- Mask comments, <script>, and <style> regions before the tag scan, then
  restore them verbatim (compileTimingAttrs, extractResolvedMedia).
- Replace the probe's substring match with a DOM query
  (video[data-hf-auto-start]) and add "auto-start video(s)" to the reasons list.
---
 .../core/src/compiler/timingCompiler.test.ts  |  29 ++++++++++++++++++
 packages/core/src/compiler/timingCompiler.ts  | Bin 9910 -> 10940 bytes
 .../services/render/stages/probeStage.test.ts |  22 ++++++++++++-
 .../src/services/render/stages/probeStage.ts  |  16 ++++++++--
 4 files changed, 64 insertions(+), 3 deletions(-)

diff --git a/packages/core/src/compiler/timingCompiler.test.ts b/packages/core/src/compiler/timingCompiler.test.ts
index f32f0df17..86e7dfe7c 100644
--- a/packages/core/src/compiler/timingCompiler.test.ts
+++ b/packages/core/src/compiler/timingCompiler.test.ts
@@ -128,6 +128,35 @@ describe("compileTimingAttrs", () => {
 
     expect(unresolved).toHaveLength(0);
   });
+
+  it("ignores media tags mentioned inside comments (issue #1938)", () => {
+    const html =
+      "<!-- this comment mentions a <video> and an <audio> tag -->\n<p>no media here</p>";
+    const { html: compiled, unresolved } = compileTimingAttrs(html);
+
+    // Comment text is preserved verbatim — no id/data-start/data-hf-auto-start injected.
+    expect(compiled).toBe(html);
+    expect(compiled).not.toContain("data-hf-auto-start");
+    expect(unresolved).toHaveLength(0);
+  });
+
+  it("ignores media tags inside <script> string literals", () => {
+    const html = '<script>const x = "<video src=\\"a.mp4\\">";</script>';
+    const { html: compiled, unresolved } = compileTimingAttrs(html);
+
+    expect(compiled).toBe(html);
+    expect(unresolved).toHaveLength(0);
+  });
+
+  it("still compiles real media tags alongside a comment that mentions them", () => {
+    const html =
+      '<!-- a <video> in prose -->\n<video src="a.mp4" data-start="0" data-duration="2">';
+    const { html: compiled } = compileTimingAttrs(html);
+
+    expect(compiled).toContain("<!-- a <video> in prose -->");
+    expect(compiled).toContain('id="hf-video-0"');
+    expect(compiled).toContain('data-end="2"');
+  });
 });
 
 describe("injectDurations", () => {
diff --git a/packages/core/src/compiler/timingCompiler.ts b/packages/core/src/compiler/timingCompiler.ts
index c4d74d8b8242d592e36c5e4dfde5d33e4a4beabf..eb55a112a8053c8a7ee55a633af4a36360f988a7 100644
GIT binary patch
delta 1056
zcmZWn&2G~`5bgmgksdf8F1;`m5O#555Eq)i3ZYUW)F7qhltj(Op2Vx#>u7h=P?g9J
z!G$YtfE2{3XLubRfmz#IHE{9T-^|YUGyZvW_3``FR@OrnLxLe^zUB!RQ@|J#6k376
zbCeMCa|A9F4-tYi$x9wIRUr9Hw>?NDedvoA+qH`C!%2jo*%TyB@e?W-W1KF4Nfb}D
zy<cSu0z6PDWXyt~Bc@4-#Q1^^p?NBlnK){m6L;Dk`J*PAhn(JEilk5CLUOH908_vx
zz%?xBIxwn`snQ2HT&X$2qZfNGU%9!)Bc{%XE>#E_7bvw+Yv^FXbp*4R1sJ7qh*E(g
zQc^I=#p-{&sWUz^3JFhKaym(gT?I@C%F#2hpvg)b*z^G9Ic5}dtr8HMhE6v-=$)MQ
z4h}mXx^zIR0^m0vR;&Gi8XOOI_p8<R=Q8WT*n-W0U&KF9yQXZ?U$5o}75yo1R4S9X
z2uz%iknxT&+$;P#QKpl)4oXW>?AGBjZ^6()4XeKnj<TQ&t#)|@mT*au3pYwL71^f#
z5L(b5Hm<9N8$$vkqO3{GQ+BdWcP#-AoMIO_iJ5Ju>-3D`Y{6*b-P@zr$L}9s=6tmn
z#Z*Vjjgg@O(nTU_v$=}wpaPeu=TbmE#UM-9JcBIXgI!YVrc3LD+!m9sMf;@$XAnMf
zH+)*PbLs&vb0PkIcb<$<I@}$?{yyyN<Yc7;o3UrI-OPWE<?6@Q*E?^D7}x4WnQZ^R
zI*KtLYw|1`FkBtp|9$Ij-LB0sMfc0|d)q5#``hg&H+t9q1JhP3R@7MidhloSFA5oB
A_W%F@

delta 27
jcmdlJy3KdP9`4P~{1Z4gOG_SN+5AR!H|yr}%5T{Kse%jZ

diff --git a/packages/producer/src/services/render/stages/probeStage.test.ts b/packages/producer/src/services/render/stages/probeStage.test.ts
index 5ca0d64dc..ebab7bd90 100644
--- a/packages/producer/src/services/render/stages/probeStage.test.ts
+++ b/packages/producer/src/services/render/stages/probeStage.test.ts
@@ -1,5 +1,5 @@
 import { describe, expect, it, mock } from "bun:test";
-import { hasScriptedAudioVolumeAutomation } from "./probeStage.js";
+import { hasAutoStartVideos, hasScriptedAudioVolumeAutomation } from "./probeStage.js";
 
 // ── Mocks for runProbeStage tests ────────────────────────────────────────────
 // Capture the cfg passed to createCaptureSession so we can assert it carries
@@ -224,6 +224,26 @@ describe("hasScriptedAudioVolumeAutomation", () => {
   });
 });
 
+describe("hasAutoStartVideos", () => {
+  it("detects a real auto-start video element", () => {
+    expect(hasAutoStartVideos(`<video src="a.mp4" data-hf-auto-start="">`)).toBe(true);
+  });
+
+  it("ignores the attribute mentioned in a comment (issue #1938)", () => {
+    expect(hasAutoStartVideos(`<!-- videos get data-hf-auto-start injected --><p>hi</p>`)).toBe(
+      false,
+    );
+  });
+
+  it("ignores the attribute in prose text", () => {
+    expect(hasAutoStartVideos(`<p>the data-hf-auto-start sentinel</p>`)).toBe(false);
+  });
+
+  it("returns false when there is no media", () => {
+    expect(hasAutoStartVideos(`<div class="clip"></div>`)).toBe(false);
+  });
+});
+
 describe("runProbeStage — forceScreenshot threading", () => {
   it("passes forceScreenshot:true to createCaptureSession when stage input carries it but cfg does not (low-memory mode fix #1236)", async () => {
     capturedCfgs.length = 0;
diff --git a/packages/producer/src/services/render/stages/probeStage.ts b/packages/producer/src/services/render/stages/probeStage.ts
index 3dbc45b7c..248dad439 100644
--- a/packages/producer/src/services/render/stages/probeStage.ts
+++ b/packages/producer/src/services/render/stages/probeStage.ts
@@ -114,6 +114,17 @@ export function hasScriptedAudioVolumeAutomation(html: string, audioCount: numbe
   );
 }
 
+/**
+ * True when the compiled HTML has at least one `<video>` carrying the
+ * auto-injected `data-hf-auto-start` sentinel. Uses a DOM query, not a
+ * substring scan — `html.includes("data-hf-auto-start")` false-fires on any
+ * comment or prose that merely mentions the attribute (issue #1938).
+ */
+export function hasAutoStartVideos(html: string): boolean {
+  const { document } = parseHTML(html);
+  return document.querySelector("video[data-hf-auto-start]") !== null;
+}
+
 export async function runProbeStage(input: ProbeStageInput): Promise<ProbeStageResult> {
   const {
     projectDir,
@@ -139,7 +150,7 @@ export async function runProbeStage(input: ProbeStageInput): Promise<ProbeStageR
   let lastBrowserConsole: string[] = [];
 
   const probeStart = Date.now();
-  const hasAutoStartVideos = compiled.html.includes("data-hf-auto-start");
+  const hasAutoStart = hasAutoStartVideos(compiled.html);
   const hasScriptedAudio = hasScriptedAudioVolumeAutomation(
     compiled.html,
     composition.audios.length,
@@ -147,7 +158,7 @@ export async function runProbeStage(input: ProbeStageInput): Promise<ProbeStageR
   const needsBrowser =
     composition.duration <= 0 ||
     compiled.unresolvedCompositions.length > 0 ||
-    hasAutoStartVideos ||
+    hasAutoStart ||
     hasScriptedAudio;
 
   if (needsBrowser) {
@@ -155,6 +166,7 @@ export async function runProbeStage(input: ProbeStageInput): Promise<ProbeStageR
     if (composition.duration <= 0) reasons.push("root duration unknown");
     if (compiled.unresolvedCompositions.length > 0)
       reasons.push(`${compiled.unresolvedCompositions.length} unresolved composition(s)`);
+    if (hasAutoStart) reasons.push("auto-start video(s)");
     if (hasScriptedAudio) reasons.push("scripted audio volume");
 
     log.info("Launching browser for composition probe...", {