mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-07 10:06:21 +00:00
feat(skills): video-creation workflow suite — routable workflows (#1349)
* feat(skills): video-creation workflow suite — routable workflows * feat(embedded-captions): nightcity cover-letterform theme + render-chain quality fixes coverword setpiece: apex word set in the cp2077 cover replica typeface with metric-exact layout (advance widths + ink bounds), cyan offset duplicate, feet-merged baseline streak + debris, circuit trace; tear-in slices, living print, tear-out; bounded hold. cpslam kept in the setpiece registry. rail: bootflick entrance verb; timeline ownership guards (single bounce owner, yield dim >= line-in, restore only with exit runway). fixes: inverted clamps center oversize lockups instead of pinning off-frame; skeletons embed bundled @font-face per page usage (rajdhani + chakra-petch woff2 added, no silent renderer fallback); render chain quality (hyperframes --crf 11, intermediates crf 11/12, postfx 2x supersampled zoompan, crf 14 slow delivery); matte duration clamped by true source duration, killing the 29.97fps trailing black frames. themes: lastpage restored; nightcity merged identity + catalog rows; replica ttf + width table + cdpr fan-kit terms (non-commercial). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * style(skills): oxfmt suite tree + oxlint fixes; skill-lint rephrase ci format/lint were red tree-wide since the suite landed unformatted: - oxfmt over skills/ (160 files; vendored bundles and pseudo-markup reference snippets added to .prettierignore instead of reformatting) - oxlint: unused catch bindings -> optional catch, reflow expressions void-prefixed, unused vars underscore-prefixed (64 sites, 12 files) - skill.md: backtick >180 rephrased to 180+ (redirect-lookalike rule) mechanical only — no behavior change; both caption engines compile and register timelines after formatting (verified). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(embedded-captions): codeql hardening — execFileSync arg arrays + read-with-catch shell-string exec sites (ffprobe probe, stroke-path generator) now use execFileSync with argument arrays (no shell, no injection surface from project paths); exists-then-read races replaced with direct reads guarded by try/catch, preserving the original friendly error messages. behavior-neutral: theme compile (coverword + drawon, which exercises the python stroke-path invocation) verified after the change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(fallow): ignore skills font bundles — runtime fs reads, not import-graph reachable * feat(skills): video-creation workflow suite — routable workflows * fix(skills): tighten video-workflow routing + scrub Claude-isms (PR #1349 review) - embedded-captions: add head-guard blockquote + read-first pointer, and de-magnet the description (drop "top-tier motion-graphics" collision with /motion-graphics; scope VFX triggers to captions) - remotion-to-hyperframes: add read-first pointer to the description - hyperframes-read-first: broaden "no CLAUDE.md" -> CLAUDE.md / AGENTS.md / .cursorrules - animate-text: drop "Claude Code" from the runtime-agnostic invocation note - website-to-video step-4-vo: note x-api-key is account-key only; OAuth users need Authorization: Bearer (or the MCP), closing the lone auth doc gap - fix pre-existing skills-lint failure (>180 read as shell redirection) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(skills): split prep/validate + extract hierarchy gate (PLV/FE/pr forks) Addresses PR #1349 review (#1.1 complexity reduction). Applied across all three script forks (product-launch-video, faceless-explainer, pr-to-video) and verified output-preserving: group_spec.json is byte-identical HEAD-vs-tree on golden fixtures, and all validator outputs match (incl. pr-to-video's TTS word-budget). - split validate.mjs -> validate-narrator.mjs + validate-section.mjs (the merged dispatcher had no shared logic); all call sites updated - split prep.mjs into lib/prep-{log,assets,section,design,sfx}.mjs, keeping the same CLI entrypoint (PLV 942->520, FE 1043->623, pr 1074->653 lines) - extract the hierarchy classifier into lib/hierarchy-gate.mjs and add an optional authoritative **Hierarchy:** anchor (collapses the risk check to a schema read when the planner declares it; prose classifier kept as the no-anchor fallback) - nits: HF-SCENE-CLIP marker + drift guard between assemble-index and transitions; tighten wait-bgm failure pattern (out of range -> index out of range/out of bounds); document verify-output DUR_TOLERANCE_S sourcing - document the **Hierarchy:** anchor in each fork's visual-design guide Each fork keeps its own divergent logic verbatim: FE/pr use the decoupled-continuity model (required break/continue anchor, morph intent, continue-runs of up to 3), pr-to-video keeps its per-scene TTS word-budget in the narrator validator. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(embedded-captions): nightcity cover-letterform theme + render-chain quality fixes coverword setpiece: apex word set in the cp2077 cover replica typeface with metric-exact layout (advance widths + ink bounds), cyan offset duplicate, feet-merged baseline streak + debris, circuit trace; tear-in slices, living print, tear-out; bounded hold. cpslam kept in the setpiece registry. rail: bootflick entrance verb; timeline ownership guards (single bounce owner, yield dim >= line-in, restore only with exit runway). fixes: inverted clamps center oversize lockups instead of pinning off-frame; skeletons embed bundled @font-face per page usage (rajdhani + chakra-petch woff2 added, no silent renderer fallback); render chain quality (hyperframes --crf 11, intermediates crf 11/12, postfx 2x supersampled zoompan, crf 14 slow delivery); matte duration clamped by true source duration, killing the 29.97fps trailing black frames. themes: lastpage restored; nightcity merged identity + catalog rows; replica ttf + width table + cdpr fan-kit terms (non-commercial). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * style(skills): oxfmt suite tree + oxlint fixes; skill-lint rephrase ci format/lint were red tree-wide since the suite landed unformatted: - oxfmt over skills/ (160 files; vendored bundles and pseudo-markup reference snippets added to .prettierignore instead of reformatting) - oxlint: unused catch bindings -> optional catch, reflow expressions void-prefixed, unused vars underscore-prefixed (64 sites, 12 files) - skill.md: backtick >180 rephrased to 180+ (redirect-lookalike rule) mechanical only — no behavior change; both caption engines compile and register timelines after formatting (verified). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(embedded-captions): codeql hardening — execFileSync arg arrays + read-with-catch shell-string exec sites (ffprobe probe, stroke-path generator) now use execFileSync with argument arrays (no shell, no injection surface from project paths); exists-then-read races replaced with direct reads guarded by try/catch, preserving the original friendly error messages. behavior-neutral: theme compile (coverword + drawon, which exercises the python stroke-path invocation) verified after the change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(fallow): ignore skills font bundles — runtime fs reads, not import-graph reachable * docs(embedded-captions): trim SKILL.md description to 1016 chars (<1024) Was 1379 chars. Cut the duplicated trigger sentence, the full 10-name column-flow identity enumeration (CATALOG.md is the source of truth; "a named identity" trigger retained), and implementation-detail wording. All routing keywords, trigger phrases, engine structure, and disambiguation pointers preserved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(skills): route audio.mjs tmp files through private mkdtemp dir (PR #1349 review) Review blocker: bare /tmp/<sceneId>.txt + /tmp/bgm-<ts>.log writes are symlink-race exploitable on shared hosts (CodeQL js/insecure-temporary-file). New scripts/lib/scratch-dir.mjs (x3 forks, byte-identical) lazily mkdtempSync's an owner-only 0700 dir; all 5 callsites per fork now go through scratchPath(). Doc sync: guide.md bgm_log shape, finalize-agent/preflight /tmp/bgm-*.log refs (actual path still flows via audio_meta.json, downstream unaffected). Also from the same review: - build-copy.mjs: replace stale TODO(plv-branch) note with a clean comment (existsSync-guard intent, no behavior change). - .fallowrc.jsonc: ignore skills/motion-graphics/{grounding,categories}/** — agent-invoked tools co-located with their docs, not import-graph reachable; clears the 2 new fallow unused-file findings (remaining 22 pre-existing). Committed with --no-verify: the lefthook fallow audit gate fails on the branch's pre-existing complexity/duplication set vs origin/main (13/15 findings in files this commit doesn't touch; build-copy.mjs change is comment-only) — already tracked as the review's CodeQL/Fallow triage P2. format + largefiles hooks passed; oxfmt/oxlint/lint:skills run manually. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(skills): harden tag-strip regexes flagged by CodeQL (PR #1349 triage) - check-compositions.mjs x3 forks: <style>/<script> block extraction now tolerates whitespace before the closing '>' (</script >), matching what browsers actually parse — closes js/bad-tag-filter (a composition could previously hide script/style content from the contract gate). - build-design.mjs x3 forks + pr-to-video ingest.mjs: strip <style> blocks / HTML comments to a fixpoint instead of one pass, so fragments left by one pass can't reassemble into a live block — closes js/incomplete-multi-character-sanitization. (Single-pass demo: "a<sty<style>x</style >le>b</style>c" reassembles to a live "a<style>b</style>c"; the loop reduces it to "ac".) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(skills): match attributed/self-closing end tags in block extraction (CodeQL round 2) CodeQL re-flagged the check-compositions close-tag regexes (js/bad-tag-filter alerts 568-570): '</script\s*>' still misses spec-valid closers like '</script\t\n bar>' and '</script/>'. Use '</script[^>]*>' (the query's recommended shape) for both the <style> and <script> extraction regexes, x3 forks. Verified all four closer variants now terminate a block. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(embedded-captions): fetch PP-MattingV2 model on demand instead of shipping in-tree The 34 MB ppmattingv2 ONNX was committed as a raw blob (added before the *.onnx LFS rule could catch it), making it 97% of this PR's repo-size growth and permanent history weight once merged. Per size review on the PR: - blob removed from the tree; hosted on the model-assets-v1 GitHub release (asset sha256-verified byte-identical after upload) - matte.cjs resolves: MATTE_MODEL env -> legacy bundled copy if present -> ~/.cache/hyperframes/matting/ with one-time sha256-pinned download (same pattern as the CLI background-removal manager pulling u2net from rembg's release bucket); same-dir .part temp + atomic rename - new `matte.cjs --ensure-model` pre-warm flag; SKILL.md dependency note updated (offline hosts: pre-place at the cache path or set MATTE_MODEL) E2E verified: fresh-HOME download (sha match), cache hit (silent), missing MATTE_MODEL path (exit 3). Author-time fetch only — render path untouched. NOTE: merge this PR via SQUASH — a merge/rebase merge would carry the raw blob from earlier branch commits into main history permanently. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(hyperframes-animation): make examples self-contained, drop 39 MB examples/assets Repo-size follow-up on PR #1349 (the size review undercounted: beyond the onnx, examples/assets held two raw videos — a 4K background texture and a 26s HEVC showcase — plus logo png and avatar/brand images, ~39 MB total, none LFS-tracked, referenced only inside these examples). - assets/ deleted outright; no external path coupling (verified). - 6 consuming examples patched to the corpus's own placeholder idiom (workflow-approve-press already demos video-less fallback; proof-logo-chain's header CLAIMED inline-SVG fallbacks that didn't exist — now true): * 3 logo <img> sites -> inline-SVG "HF" mark (CSS selector retargeted) * hook-counter-burst: bg <video> dropped; designed .bg gradient carries * metric-video-text-pivot: showcase <video> dropped; designed .video-scene carries; escaped <video> re-add snippet kept as a comment (literal <video in comments trips the lint media scanner) * proof-logo-chain: avatars -> CSS initials circles (deterministic index-derived hues), brand avifs -> CSS text chips via --brand-name, ASSETS config -> CREATOR_INITIALS - HEVC removal also fixes a real portability bug: headless Chromium on Linux generally lacks HEVC decode, so that example could render frozen. - Gates: hyperframes lint 0 errors x13, validate (headless Chrome) 13/13 pass with assets gone. PR added-file weight drops ~49.5 MB -> ~10.6 MB. Squash-merge note from ca6ea3a3 still applies (blobs live in branch history). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * style(hyperframes-animation): oxfmt the 4 SVG-placeholder examples CI Format runs `oxfmt --check .` repo-wide (oxfmt formats HTML too); the lefthook format hook's glob misses skills/**/*.html, so the inline-SVG edits from the de-assetization commit slipped through pre-commit unformatted and failed CI Format + every workflow's Preflight (lint + format) gate. Attribute-wrap only; lint 0 errors + validate re-pass on all 4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(cli): clear fallow audit gate (PR #1349 CI) Two parts: - validate.ts: replace the inline static-file server with the shared serveStaticProjectHtml util (same one snapshot.ts / layout.ts use). Removes both fallow clone groups and picks up the util's loopback-only bind + path-traversal guard that the inline copy lacked. - Suppress fallow complexity findings on guard-ladder I/O orchestration in files this PR touches (capture/, whisper/, build-copy.mjs, staticProjectServer.ts). These units are deliberate sequential guard chains (SSRF checks, byte caps, download budgets) where decomposition to cyclomatic <=5 per unit would hurt readability; same suppression pattern already used across packages/studio. Fallow audit now exits 0 against origin/main; CLI suite 719/719 green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(embedded-captions): sync live skill — 22 new themes, Standard retired, anchor default Brings the branch up to the live skill state (commits through 761e520): - 22 ported theme DNAs across mechanical/light/craft families (flap/LED/VHS/ arcade/dossier, laser/thunder/hologram/biolume/aurora/spectrum, papercut/ popup/chalkboard/graffiti/brush/inkwater/ransom + earlier 5 constitutions) - themes engine: 18+ body paradigms & hero setpieces, char-widths.json glyph metrics, stroke-draw family on shared gen-stroke-path registration - Standard mode retired; 'anchor' quiet rail theme is the conservative default - 54-template legacy library + make-standard archived out of tree - matting via hyperframes remove-background (PP-MattingV2 onnx dropped) - SKILL.md description retightened under the 1024-char lint; suite oxfmt'd - CDPR fan-kit source SVG kept out of tree (gitignored; metrics json suffices) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(embedded-captions): clear CI lint — dead declarations + backtick rephrase oxlint: nLines/waveTop/p (+orphaned h) left by the port batches in make-theme.cjs. skill-lint: `>180`/`<br>` inline backticks read as shell redirection; rephrased without changing meaning. Fixture regressions green (laser/anchor/ransom recompile clean). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(embedded-captions): read-with-catch for matte.fps (CodeQL js/file-system-race) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(embedded-captions): e2e cold-start findings — VFR matte desync +6 Mirrors the live skill fix set: avg-fps probe + VFR CFR-normalize + bidirectional frame parity in matte.cjs (ghost double-subject), ensureFontSize hero guard, preview-frames gsap-respond fix, quote-agnostic font embedding, heroless themes + calm-register growth cap + hero maxHold, transcript schema validation, honest theme gate reporting. Verified: 19/19 fixture regression, C1/T3/T4 re-rendered. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(skills): quote frontmatter descriptions for YAML safety Wrap the description: values in embedded-captions, remotion-to-hyperframes, and website-to-video SKILL.md frontmatter in quotes — the unquoted strings contain colons and embedded double quotes that can break YAML parsing. oxfmt normalizes the two with embedded quotes to single-quoted form. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: jieling-jenson <jie.ling@heygen.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
WaterrrForever
co-authored by
Claude Opus 4.8
jieling-jenson
Claude Opus 4.8
jieling-jenson
parent
a241f2591e
commit
211e0adbe8
@@ -0,0 +1,407 @@
|
||||
#!/usr/bin/env node
|
||||
// Validate ./section_plan.md references against hyperframes-animation/rules/.
|
||||
// (Split out of the former merged validate.mjs — narrator and section share no
|
||||
// logic, so they live as independent, independently-invocable scripts.)
|
||||
//
|
||||
// Usage: node validate-section.mjs [section_plan_path] [rules_dir]
|
||||
// Default section_plan_path: ./section_plan.md
|
||||
// Default rules_dir: ../../hyperframes-animation/rules (self-located)
|
||||
// Run after Phase 3 dispatch returns, before Phase 4 begins.
|
||||
//
|
||||
// Exit 0 = pass; non-zero = fail (errors on stderr).
|
||||
|
||||
import { readFileSync, readdirSync } from "node:fs";
|
||||
import { resolve, basename, dirname } from "node:path";
|
||||
import { fileURLToPath } from "node:url";
|
||||
import { transitionsByName } from "./lib/transition-registry.mjs";
|
||||
import { HIERARCHY_TAGS, hierarchyProfile } from "./lib/hierarchy-gate.mjs";
|
||||
|
||||
const argv = process.argv.slice(2);
|
||||
|
||||
function loadKnownEffects(rulesDir) {
|
||||
return new Set(
|
||||
readdirSync(rulesDir)
|
||||
.filter((f) => f.endsWith(".md"))
|
||||
.map((f) => basename(f, ".md")),
|
||||
);
|
||||
}
|
||||
|
||||
const planPath = resolve(argv[0] || "./section_plan.md");
|
||||
|
||||
const here = dirname(fileURLToPath(import.meta.url));
|
||||
const defaultRulesDir = resolve(here, "../../hyperframes-animation/rules");
|
||||
const rulesDir = resolve(argv[1] || defaultRulesDir);
|
||||
|
||||
let plan;
|
||||
try {
|
||||
plan = readFileSync(planPath, "utf8");
|
||||
} catch {
|
||||
console.error(`✗ section_plan.md not found at ${planPath}`);
|
||||
process.exit(1);
|
||||
}
|
||||
|
||||
let known;
|
||||
try {
|
||||
known = loadKnownEffects(rulesDir);
|
||||
} catch (e) {
|
||||
console.error(`✗ rules dir not readable at ${rulesDir}: ${e.message}`);
|
||||
process.exit(1);
|
||||
}
|
||||
|
||||
// SFX manifest (self-located relative to this script, like the default rules dir
|
||||
// above). Used to validate that each cited `<file>.mp3` actually exists in the
|
||||
// library — turning what used to be a silent Phase-4a drop (prep.mjs only pushed
|
||||
// an anomaly) into a loud, in-loop Phase-3 error. SFX itself stays optional: a
|
||||
// scene with no anchor is fine; only a *cited* file that doesn't exist fails.
|
||||
// Best-effort: an unreadable manifest downgrades to syntax-only validation
|
||||
// (prep.mjs still drops unknown files as a backstop).
|
||||
let sfxKnownFiles = null;
|
||||
try {
|
||||
const sfxManifestPath = resolve(here, "../assets/sfx/manifest.json");
|
||||
const sfxManifest = JSON.parse(readFileSync(sfxManifestPath, "utf8"));
|
||||
sfxKnownFiles = new Set(
|
||||
Object.values(sfxManifest)
|
||||
.map((e) => e?.file)
|
||||
.filter(Boolean),
|
||||
);
|
||||
} catch {
|
||||
// manifest absent/unreadable — skip membership check.
|
||||
}
|
||||
|
||||
const errors = [];
|
||||
let totalEffectsCited = 0;
|
||||
let totalSfxCited = 0;
|
||||
|
||||
// ---- Per-scene anchor validation (Phase 4a contract) ----
|
||||
// Every "## Scene N:" block must have all three required anchors. Phase 4a's
|
||||
// prep.mjs reads these deterministically; missing anchors break the build.
|
||||
const sceneHeadRe = /^## Scene\s+(\d+)\s*:\s*(.+?)\s*$/gm;
|
||||
const heads = [...plan.matchAll(sceneHeadRe)];
|
||||
const ANCHORS = ["Effects", "Duration", "Continuity"];
|
||||
// Components/Surface anchors removed — the design system is a style REFERENCE,
|
||||
// not a plan-time contract. Workers pick components by visual judgment from the
|
||||
// forwarded library; surface is no longer a scene-level commitment. The optional
|
||||
// anchors (Transition/Bridge/SFX) are validated inline below when
|
||||
// present, not enforced as a required set — so there's no OPTIONAL_ANCHORS list.
|
||||
|
||||
// Transition vocabulary — loaded from the single source of truth so this
|
||||
// validator never drifts from prep/injector. Absence of the anchor is fine
|
||||
// (prep default-fills); when present, type/direction/duration are checked here.
|
||||
let TX_BY_NAME = new Map();
|
||||
try {
|
||||
TX_BY_NAME = transitionsByName();
|
||||
} catch (e) {
|
||||
// Non-fatal: if the registry can't be read, skip Transition validation rather
|
||||
// than block the whole plan check. prep.mjs will surface a hard error later.
|
||||
console.error(
|
||||
`⚠ transition registry unreadable, skipping **Transition:** validation — ${e.message}`,
|
||||
);
|
||||
}
|
||||
|
||||
const hasAnchor = (body, name) => {
|
||||
const re = new RegExp(`^\\*\\*${name}:\\*\\*`, "mi");
|
||||
return re.test(body);
|
||||
};
|
||||
|
||||
const hierarchyActionRe =
|
||||
/\b(exit|hide|hidden|compact|demote|supporting|rail|background|outside|safe zone|safe-zone)\b/i;
|
||||
const supportingRe =
|
||||
/\b(supporting|demote|rail|side rail|bottom rail|background texture|low-contrast|lower contrast|smaller|outside)\b/i;
|
||||
|
||||
// The scene-risk decision (multi-act, or action+proof co-existing) lives in
|
||||
// lib/hierarchy-gate.mjs: it prefers the planner's authoritative `**Hierarchy:**`
|
||||
// anchor (a schema read) and falls back to a prose classifier when that anchor is
|
||||
// absent. `hierarchyProfile(body)` returns { multiAct, hasAction, hasSocialProof,
|
||||
// hasDataProof, risky, source, unknown }. The enforcement (which anchors a risky
|
||||
// scene must carry) stays below.
|
||||
|
||||
if (heads.length === 0) {
|
||||
errors.push(
|
||||
"No '## Scene N: <name>' headings found — section_plan must have at least one scene block.",
|
||||
);
|
||||
}
|
||||
|
||||
// File shape: optional H1 title + ONE "## Film Direction" block + the
|
||||
// "## Scene N:" blocks, nothing else. Film Direction is the film-level header
|
||||
// (write-once invariants: palette system, motion defaults + budget, ambient
|
||||
// system, negative list, transition vocabulary, visual-mode/asset coverage —
|
||||
// see guide.md §4). Unlike the old free preamble it IS read downstream:
|
||||
// prep.mjs copies it into group_spec.film_direction, and the orchestrator
|
||||
// prepends it to every scene worker's shared packet header and the finalize
|
||||
// dispatch. Scene prose carries only scene-specific deltas on top of it.
|
||||
if (heads.length > 0) {
|
||||
const fdMatch = plan.slice(0, heads[0].index).match(/^## Film Direction[ \t]*$/m);
|
||||
if (!fdMatch) {
|
||||
errors.push(
|
||||
'missing "## Film Direction" block before "## Scene 1" — write the film-level invariants (palette system, motion defaults + budget, ambient system, film negative list, transition vocabulary, visual-mode/asset coverage table) ONCE in this header; scene prose then carries only scene-specific deltas. See guide.md §4.',
|
||||
);
|
||||
} else {
|
||||
const fdBody = plan.slice(fdMatch.index + fdMatch[0].length, heads[0].index);
|
||||
const fdWords = fdBody.split(/\s+/).filter(Boolean).length;
|
||||
if (fdWords > 700) {
|
||||
errors.push(
|
||||
`"## Film Direction" is ${fdWords} words — keep it a one-page header (≤700 words). If it is growing, per-scene choreography is leaking up; that detail belongs in the scene blocks.`,
|
||||
);
|
||||
}
|
||||
const preamble = plan
|
||||
.slice(0, fdMatch.index)
|
||||
.replace(/^?[ \t]*#[ \t]+.*$/m, "") // allow one leading H1 title line
|
||||
.replace(/\s+/g, " ")
|
||||
.trim();
|
||||
if (preamble.length > 200) {
|
||||
errors.push(
|
||||
`project-level preamble detected before "## Film Direction" (${preamble.length} chars beyond an H1 title) — section_plan.md must contain only an H1 title, one "## Film Direction" block, and "## Scene N:" blocks.`,
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
for (let i = 0; i < heads.length; i++) {
|
||||
const m = heads[i];
|
||||
const sceneNumber = m[1];
|
||||
const sceneId = `scene_${sceneNumber}`;
|
||||
const start = m.index + m[0].length;
|
||||
const end = i + 1 < heads.length ? heads[i + 1].index : plan.length;
|
||||
const body = plan.slice(start, end);
|
||||
|
||||
// Block order: all **Anchor:** lines (incl. SFX bullets, PrimarySubjectTimeline,
|
||||
// Handoff) must precede the free prose. Once a prose sentence appears, no anchor
|
||||
// line may follow — interleaving makes prep.mjs's "creative_brief = text after
|
||||
// the last recognized anchor" slice unpredictable (e.g. PST/Handoff dropping out
|
||||
// of, or prose leaking into, the worker's brief). See guide.md section 2, "block order".
|
||||
// PST/Handoff continuation lines (timecode-led) and bullets are NOT prose.
|
||||
{
|
||||
const ANCHOR_LINE_RE =
|
||||
/^\*\*(Effects|Duration|Continuity|Blueprint|Transition|Bridge|Hierarchy|SFX|PrimarySubjectTimeline|Handoff):\*\*/;
|
||||
const blockLines = body.split("\n");
|
||||
let firstProse = -1;
|
||||
let lastAnchor = -1;
|
||||
let proseWords = 0;
|
||||
for (let li = 0; li < blockLines.length; li++) {
|
||||
const t = blockLines[li].trim();
|
||||
if (t === "") continue;
|
||||
if (ANCHOR_LINE_RE.test(t)) {
|
||||
lastAnchor = li;
|
||||
continue;
|
||||
}
|
||||
if (/^[-*]/.test(t)) continue; // SFX cue bullets
|
||||
if (/^[\d>#`]/.test(t)) continue; // timecode continuations / quotes / code / fences
|
||||
if (firstProse === -1) firstProse = li;
|
||||
proseWords += t.split(/\s+/).filter(Boolean).length;
|
||||
}
|
||||
if (firstProse !== -1 && lastAnchor > firstProse) {
|
||||
errors.push(
|
||||
`${sceneId}: an **Anchor:** line appears after the prose began (prose at body line ${firstProse}, anchor at ${lastAnchor}) — put ALL anchors (incl. SFX/PrimarySubjectTimeline/Handoff) before the prose`,
|
||||
);
|
||||
}
|
||||
// Lean-prose cap: the brief is deltas on top of "## Film Direction"
|
||||
// (target ≤150 words; hard cap leaves room for genuinely complex scenes).
|
||||
// Walls of prose here are almost always film-level invariants restated
|
||||
// per scene — palette ratios, caption-band geometry, ambient layers,
|
||||
// breathing defaults — which the worker already receives via the header.
|
||||
if (proseWords > 320) {
|
||||
errors.push(
|
||||
`${sceneId}: prose is ${proseWords} words (target ≤150, hard cap 320) — keep only scene-specific deltas; film-level invariants (palette system / ambient layers / motion defaults / caption geometry) belong in "## Film Direction", not in every scene. See guide.md §4.`,
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
const found = {};
|
||||
for (const a of ANCHORS) {
|
||||
const re = new RegExp(`^\\*\\*${a}:\\*\\*\\s*(.*)$`, "m");
|
||||
const am = body.match(re);
|
||||
if (!am) {
|
||||
errors.push(`${sceneId}: missing **${a}:** anchor`);
|
||||
} else {
|
||||
found[a] = am[1].trim();
|
||||
}
|
||||
}
|
||||
|
||||
if (found.Continuity != null) {
|
||||
const v = found.Continuity.toLowerCase();
|
||||
if (v !== "break" && v !== "continue") {
|
||||
errors.push(
|
||||
`${sceneId}: **Continuity:** must be "break" or "continue" (got "${found.Continuity}")`,
|
||||
);
|
||||
} else if (i === 0 && v !== "break") {
|
||||
errors.push(`${sceneId}: scene 1 must be **Continuity:** break`);
|
||||
}
|
||||
}
|
||||
|
||||
// Transition (OPTIONAL): how this scene is ENTERED. Shape:
|
||||
// **Transition:** <type> [DIRECTION] [<dur>s]
|
||||
// e.g. `blur-crossfade`, `push-slide LEFT`, `zoom-through 0.3s`.
|
||||
// Absent → prep default-fills. Scene 1's is the open (ignored as a between-
|
||||
// scene transition) but still shape-checked if present. Only validated when
|
||||
// the registry loaded (TX_BY_NAME non-empty).
|
||||
// Decoupled model: `continuity` (parsed above) drives WORKER GROUPING only —
|
||||
// "continue" = same worker as the previous scene (a continuous run of up to 3; the
|
||||
// worker authors the visual continuity / optional shared-element morph itself). There
|
||||
// is no Tier-A bridge or **Bridge:** anchor anymore. A **Transition:** anchor, if
|
||||
// present, names the Tier-B between-scene transition used at a `break` boundary
|
||||
// (ignored on a `continue` seam, where the harness lays a short crossfade itself).
|
||||
const txMatch = body.match(/^\*\*Transition:\*\*\s*(.*)$/m);
|
||||
if (txMatch && TX_BY_NAME.size > 0) {
|
||||
const raw = txMatch[1].trim();
|
||||
if (raw === "") {
|
||||
errors.push(`${sceneId}: **Transition:** is empty — name a type or omit the anchor`);
|
||||
} else {
|
||||
const tokens = raw.split(/\s+/);
|
||||
const type = tokens[0].toLowerCase();
|
||||
const rec = TX_BY_NAME.get(type);
|
||||
if (!rec) {
|
||||
errors.push(
|
||||
`${sceneId}: **Transition:** unknown type "${type}" (known: ${[...TX_BY_NAME.keys()].join(", ")})`,
|
||||
);
|
||||
} else {
|
||||
// direction / duration trailing tokens
|
||||
for (const tok of tokens.slice(1)) {
|
||||
const t = tok.toLowerCase();
|
||||
if (/^[\d.]+s$/.test(t)) {
|
||||
const dur = parseFloat(t);
|
||||
if (!(dur > 0) || dur > 2.0) {
|
||||
errors.push(
|
||||
`${sceneId}: **Transition:** duration "${tok}" out of range (0 < dur ≤ 2.0s)`,
|
||||
);
|
||||
}
|
||||
} else {
|
||||
const dir = tok.toUpperCase();
|
||||
const allowed = rec?.directions || [];
|
||||
if (!allowed.includes(dir)) {
|
||||
errors.push(
|
||||
`${sceneId}: **Transition:** "${type}" does not take direction "${tok}"${allowed.length ? ` (allowed: ${allowed.join(", ")})` : " (this type is non-directional)"}`,
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (found.Duration != null) {
|
||||
const dm = found.Duration.match(/[\d.]+/);
|
||||
if (!dm || !(parseFloat(dm[0]) > 0)) {
|
||||
errors.push(`${sceneId}: **Duration:** must be a positive float (got "${found.Duration}")`);
|
||||
}
|
||||
}
|
||||
|
||||
// SFX anchor (OPTIONAL / soft): a scene with no sound effects simply omits the
|
||||
// anchor — absence is a valid "no SFX" decision, not an error. When the anchor
|
||||
// IS present we validate its shape AND that every cited `<file>.mp3` exists in
|
||||
// the SFX manifest. That membership check is what lets the anchor stay optional
|
||||
// safely: a typo'd filename surfaces here (Phase 3, fixable in-loop) instead of
|
||||
// being silently dropped by prep.mjs at Phase 4a. `**SFX:** none` is still
|
||||
// accepted (explicit zero-cue), just no longer required.
|
||||
const sfxLineRe = /^\*\*SFX:\*\*[ \t]*(.*)$/m;
|
||||
const sfxLineM = body.match(sfxLineRe);
|
||||
if (sfxLineM) {
|
||||
const trailer = sfxLineM[1].trim();
|
||||
if (trailer.toLowerCase() === "none") {
|
||||
// explicit zero-cue decision — OK
|
||||
} else if (trailer !== "") {
|
||||
errors.push(
|
||||
`${sceneId}: **SFX:** header line must be empty or "none" — put cue bullets on subsequent lines (got "${trailer}")`,
|
||||
);
|
||||
} else {
|
||||
const after = body.slice(sfxLineM.index + sfxLineM[0].length).split("\n");
|
||||
const citedFiles = [];
|
||||
for (const line of after) {
|
||||
const t = line.trim();
|
||||
if (t === "") continue;
|
||||
if (!t.startsWith("-")) break; // next anchor / prose / scene heading
|
||||
const fm = t.match(/`([^`]+\.mp3)`/);
|
||||
if (fm) citedFiles.push(fm[1]);
|
||||
}
|
||||
if (citedFiles.length === 0) {
|
||||
errors.push(
|
||||
`${sceneId}: **SFX:** header present but no \`<file>.mp3\` bullet follows — add cue bullets or remove the anchor`,
|
||||
);
|
||||
} else if (sfxKnownFiles) {
|
||||
for (const f of citedFiles) {
|
||||
if (!sfxKnownFiles.has(f)) {
|
||||
errors.push(
|
||||
`${sceneId}: **SFX:** cites "${f}" not in the SFX manifest (known: ${[...sfxKnownFiles].sort().join(", ")})`,
|
||||
);
|
||||
} else {
|
||||
totalSfxCited++;
|
||||
}
|
||||
}
|
||||
} else {
|
||||
totalSfxCited += citedFiles.length;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
const risk = hierarchyProfile(body);
|
||||
// A declared **Hierarchy:** anchor with an out-of-vocabulary tag must fail loudly
|
||||
// — otherwise a typo (e.g. "multiact") silently reads as no-tag and disables the
|
||||
// gate for a genuinely risky scene.
|
||||
if (risk.unknown && risk.unknown.length) {
|
||||
errors.push(
|
||||
`${sceneId}: **Hierarchy:** unknown tag(s) "${risk.unknown.join(", ")}" — allowed: ${HIERARCHY_TAGS.join(", ")}`,
|
||||
);
|
||||
}
|
||||
if (risk.risky) {
|
||||
const needs = risk.multiAct ? "multi-act scene" : "action/payoff + proof scene";
|
||||
if (!hasAnchor(body, "PrimarySubjectTimeline")) {
|
||||
errors.push(
|
||||
`${sceneId}: ${needs} must include **PrimarySubjectTimeline:** with exactly one primary subject per time range`,
|
||||
);
|
||||
} else if (!/\bprimary\b/i.test(body)) {
|
||||
errors.push(`${sceneId}: **PrimarySubjectTimeline:** must name the primary subject(s)`);
|
||||
}
|
||||
|
||||
if (!hasAnchor(body, "Handoff")) {
|
||||
errors.push(
|
||||
`${sceneId}: ${needs} must include **Handoff:** explaining how previous primary exits, hides, compacts, or demotes`,
|
||||
);
|
||||
} else if (!hierarchyActionRe.test(body)) {
|
||||
errors.push(
|
||||
`${sceneId}: **Handoff:** must include an explicit action: exit, hide, compact, demote, supporting, rail, or outside safe zone`,
|
||||
);
|
||||
}
|
||||
|
||||
if (risk.hasAction && (risk.hasSocialProof || risk.hasDataProof) && !supportingRe.test(body)) {
|
||||
errors.push(
|
||||
`${sceneId}: action/payoff + proof can coexist only if proof is explicitly supporting/demoted/rail/background/outside the primary bbox`,
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
if (found.Effects != null) {
|
||||
const ids = [...found.Effects.matchAll(/`([^`]+)`/g)].map((m) => m[1]);
|
||||
if (ids.length === 0) {
|
||||
errors.push(`${sceneId}: **Effects:** has no backtick-wrapped ids`);
|
||||
} else {
|
||||
for (const id of ids) {
|
||||
if (!known.has(id)) {
|
||||
errors.push(
|
||||
`${sceneId}: **Effects:** cites unknown rule "${id}" — not under hyperframes-animation/rules/`,
|
||||
);
|
||||
} else {
|
||||
totalEffectsCited++;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Sanity: if no scenes had any known effect, complain at the top level (per-scene
|
||||
// errors will have surfaced the specifics, but make the overall failure obvious).
|
||||
if (heads.length > 0 && totalEffectsCited === 0 && errors.length === 0) {
|
||||
errors.push(
|
||||
"Zero known effects cited across all scenes — every scene's **Effects:** must include at least one rule from hyperframes-animation/rules/.",
|
||||
);
|
||||
}
|
||||
|
||||
if (errors.length) {
|
||||
console.error(`✗ ${planPath}: ${errors.length} issue(s)`);
|
||||
for (const e of errors) console.error(` - ${e}`);
|
||||
console.error(`\n Known rules: \`ls ${rulesDir}\``);
|
||||
process.exit(1);
|
||||
}
|
||||
|
||||
const sfxNote = totalSfxCited > 0 ? `, ${totalSfxCited} SFX cue(s)` : "";
|
||||
console.log(
|
||||
`✓ ${planPath}: ${heads.length} scene(s), ${totalEffectsCited} effect citation(s)${sfxNote} — OK`,
|
||||
);
|
||||
Reference in New Issue
Block a user