From 256b84a41bc32913870953c06e05f4ab25e963f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel?= Date: Thu, 5 Nov 2026 20:44:35 +0000 Subject: [PATCH] fix(core): check's no-draw seeks no longer upload graded images to the GPU (#7264) --- .../src/capture/colorGrading.chromium.test.ts | 28 +++++++++++++++++++ packages/core/src/runtime/colorGrading.ts | 8 ++++++ 2 files changed, 36 insertions(+) diff --git a/packages/cli/src/capture/colorGrading.chromium.test.ts b/packages/cli/src/capture/colorGrading.chromium.test.ts index 060ff33e9b..16f570767a 100644 --- a/packages/cli/src/capture/colorGrading.chromium.test.ts +++ b/packages/cli/src/capture/colorGrading.chromium.test.ts @@ -9,6 +9,7 @@ import { type HfHueCurvePoint, } from "@hyperframes/core/color-grading"; import { findSystemBrowser } from "../browser/manager.js"; +import { seekInPage } from "./captureCompositionFrame.js"; interface GradingTestApi { setGrading(target: string, grading: HfColorGrading): boolean; @@ -195,6 +196,33 @@ describe.skipIf(!runsChromium)("color grading curves in Chromium", () => { expect(actual).toEqual([128, 0, 0, 255]); expect(browserErrors).toEqual([]); }); + + // fails without the fix: every no-draw seek re-uploaded the image, a GPU copy each until check's batch ended. + it("uploads no source frame during check's no-draw seeks, and one on the next drawn seek", async () => { + const uploads = await page.evaluate(`(() => { + const proto = WebGLRenderingContext.prototype; + const upload = proto.texImage2D; + let count = 0; + proto.texImage2D = function (...args) { + if (args.length === 6) count += 1; + return Reflect.apply(upload, this, args); + }; + window.__timelines = { main: { pause() {}, seek() { window.__gradingTestRuntime.redraw(); } } }; + const seek = ${seekInPage}; + try { + for (let time = 1; time <= 8; time++) seek(time, true, false, true); + const gated = count; + count = 0; + seek(9, true, false, false); + return [gated, count]; + } finally { + proto.texImage2D = upload; + delete window.__timelines; + } + })()`); + expect(uploads).toEqual([0, 1]); + expect(browserErrors).toEqual([]); + }); }); describe.skipIf(!runsChromium)("a grade group in Chromium", () => { diff --git a/packages/core/src/runtime/colorGrading.ts b/packages/core/src/runtime/colorGrading.ts index b86052ff58..9020c1e9b7 100644 --- a/packages/core/src/runtime/colorGrading.ts +++ b/packages/core/src/runtime/colorGrading.ts @@ -3347,11 +3347,19 @@ function readAnimatedGrading(entry: ColorGradingEntry): ResolvedHfColorGrading { return animated; } +const CLI_SEEK_DRAW_GATE = Symbol.for("hyperframes.webglDrawGate"); + +function drawsGated(): boolean { + const gate: unknown = Reflect.get(window, CLI_SEEK_DRAW_GATE); + return typeof gate === "object" && gate !== null && Reflect.get(gate, "skip") === true; +} + function uploadSourceTexture( gl: WebGLRenderingContext, texture: WebGLTexture, source: TexImageSource, ): void { + if (drawsGated()) return; gl.activeTexture(gl.TEXTURE0); gl.bindTexture(gl.TEXTURE_2D, texture); gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, true);