From 2679bcdee71aa0b1d706fd845f399fa07fc2c48f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel?= Date: Wed, 4 Nov 2026 19:44:23 +0000 Subject: [PATCH] ci(studio): the timeline viewport gate runs one pinned Chrome build, not the runner's (#7180) The runner image ships Chrome 156.0.8078.47 or .79 run to run, and .79 renders one more thumbnail on open, so the studio-open ceilings failed on changes that never touched Studio. The ceilings file now records the major it is measured on. --- .github/workflows/ci.yml | 8 ++++++++ packages/studio/tests/e2e/perf-ceilings.json | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f5de16d6d9..fd7203fe3b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -980,6 +980,14 @@ jobs: - run: bun run --filter '@hyperframes/{parsers,lint,studio-server}' build - run: bun run --cwd packages/core build - run: bun run --cwd packages/core build:hyperframes-runtime + - name: Set up the Chrome build the work-count ceilings were measured on + # The runner image's Chrome moves under the gate: 156.0.8078.79 renders one more thumbnail than .47. + # Bump this with the ceilings in packages/studio/tests/e2e/perf-ceilings.json, never alone. + id: chrome + uses: browser-actions/setup-chrome@c785b87e244131f27c9f19c1a33e2ead956ab7ce # v1 + with: + chrome-version: 156.0.8078.47 + - run: echo "CHROME_PATH=${{ steps.chrome.outputs.chrome-path }}" >> "$GITHUB_ENV" - name: Install the fixture as a Studio project # Studio resolves projects from packages/studio/data/projects, which is # gitignored. The fixture composition is tracked under tests/e2e, so diff --git a/packages/studio/tests/e2e/perf-ceilings.json b/packages/studio/tests/e2e/perf-ceilings.json index 7117e7ef8e..ed6c6f8d52 100644 --- a/packages/studio/tests/e2e/perf-ceilings.json +++ b/packages/studio/tests/e2e/perf-ceilings.json @@ -1,6 +1,6 @@ { "studio-open": { - "browser": "155", + "browser": "156", "counts": { "thumbnailRenders": 13, "total.frameNavigations": 7,