From 2798d026f7163cefcf8af7ccccee8581e9a36c00 Mon Sep 17 00:00:00 2001 From: Miguel Angel Simon Sierra Date: Thu, 1 Oct 2026 10:43:01 -0700 Subject: [PATCH] fix(studio): a drag on a centred element no longer flashes off-centre on release --- packages/studio/src/hooks/gsapDragPositionCommit.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/studio/src/hooks/gsapDragPositionCommit.ts b/packages/studio/src/hooks/gsapDragPositionCommit.ts index 794e335cc2..6641af79bc 100644 --- a/packages/studio/src/hooks/gsapDragPositionCommit.ts +++ b/packages/studio/src/hooks/gsapDragPositionCommit.ts @@ -1,4 +1,5 @@ import type { GsapAnimation } from "@hyperframes/core/gsap-parser"; +import { PROPERTY_GROUPS } from "@hyperframes/parsers/gsap-constants"; import type { DomEditSelection } from "../components/editor/domEditingTypes"; import { usePlayerStore } from "../player/store/playerStore"; import { resolveTweenStart, resolveTweenDuration } from "../utils/globalTimeCompiler"; @@ -179,7 +180,9 @@ async function commitFlatViaKeyframes( if (runtime && ts !== null) { const { gsapLib, el, mainTl } = runtime; const draggedValues: Record = {}; - for (const key of Object.keys(properties)) { + // Clearing x/y clears GSAP's whole transform, and the seek does not bring back an xPercent + // set outside the timeline, so the restore below carries every position channel. + for (const key of new Set([...Object.keys(properties), ...PROPERTY_GROUPS.position])) { const v = Number(gsapLib.getProperty(el, key)); if (Number.isFinite(v)) draggedValues[key] = v; }