{
const result = await lintHyperframeHtml(html);
const finding = result.findings.find((f) => f.code === "timed_element_missing_clip_class");
expect(finding).toBeDefined();
- expect(finding?.severity).toBe("error");
+ // A warning, not an error: the runtime hides the element either way (see
+ // the message), so a missing marker class is an authoring-convention gap.
+ expect(finding?.severity).toBe("warning");
+ expect(finding?.message).not.toContain("visible for the entire composition");
});
it("does not flag element that has class='clip'", async () => {
@@ -464,12 +467,16 @@ describe("composition rules", () => {
expect(finding).toBeUndefined();
});
- it("does not flag audio or video elements", async () => {
+ it("does not flag the media primitives: audio, video, img", async () => {
+ // All three are authored without class="clip" in the canonical clip block
+ // (packages/core/docs/core.md). `img` used to be the only one of the three
+ // that errored, so the documented example failed its own linter.
const html = `
![]()
` alone errored on the documented pattern while its two siblings on
+ // the adjacent lines passed.
+ const skipTags = new Set(["audio", "img", "video", "script", "style", "template"]);
for (const tag of tags) {
if (skipTags.has(tag.name)) continue;
// Skip composition hosts
@@ -534,11 +539,18 @@ export const compositionRules: Array<(ctx: LintContext) => HyperframeLintFinding
const elementId = readAttr(tag.raw, "id") || undefined;
findings.push({
code: "timed_element_missing_clip_class",
- severity: "error",
- message: `<${tag.name}${elementId ? ` id="${elementId}"` : ""}> has timing attributes but no class="clip". The element will be visible for the entire composition instead of only during its scheduled time range.`,
+ // Not an error: the runtime drives timed visibility off the `data-start`
+ // ATTRIBUTE, not this class — `syncTimedElementVisibility` walks
+ // `querySelectorAll("[data-start]")` and toggles `style.visibility`
+ // regardless of class (pinned by the runtime's own init test, which
+ // uses a bare `
+ 
+
+`;
+ const result = await lintHyperframeHtml(html);
+ const blocking = result.findings.filter((f) => f.severity !== "info");
+ expect(blocking.map((f) => `${f.severity}:${f.code}`)).toEqual([]);
+ });
+
it("does not flag element with only data-track-index (layer container, no timing)", async () => {
const html = `
diff --git a/packages/lint/src/rules/composition.ts b/packages/lint/src/rules/composition.ts
index 61a558ee9..2b4ea76f9 100644
--- a/packages/lint/src/rules/composition.ts
+++ b/packages/lint/src/rules/composition.ts
@@ -515,7 +515,12 @@ export const compositionRules: Array<(ctx: LintContext) => HyperframeLintFinding
// fallow-ignore-next-line complexity
({ tags }) => {
const findings: HyperframeLintFinding[] = [];
- const skipTags = new Set(["audio", "video", "script", "style", "template"]);
+ // `img` sits here for the same reason `video` and `audio` already did: the
+ // three media primitives are authored without `class="clip"` in the
+ // canonical clip block (packages/core/docs/core.md), so requiring it on the
+ // `
` with no `class="clip"`).
+ // The class is an authoring convention the tooling reads, so a missing
+ // one is worth flagging but does not break the render.
+ severity: "warning",
+ message: `<${tag.name}${elementId ? ` id="${elementId}"` : ""}> has timing attributes but no class="clip". The runtime still hides it outside its time range, but Studio and the GSAP clip-ownership rules use .clip to recognise a clip, so leaving it off makes the element harder to edit and to lint.`,
elementId,
fixHint:
- 'Add class="clip" to the element. The HyperFrames runtime uses .clip to control visibility based on data-start/data-duration.',
+ 'Add class="clip" to the element so Studio and the linter can recognise it as a clip.',
snippet: truncateSnippet(tag.raw),
});
}
diff --git a/skills-manifest.json b/skills-manifest.json
index bdb412717..e2fb3aa96 100644
--- a/skills-manifest.json
+++ b/skills-manifest.json
@@ -78,7 +78,7 @@
"files": 2
},
"talking-head-recut": {
- "hash": "214eda4c0f2bedb1",
+ "hash": "7ac85a5f44467d6b",
"files": 28
}
}
diff --git a/skills/talking-head-recut/SKILL.md b/skills/talking-head-recut/SKILL.md
index 275c7bf12..29407d045 100644
--- a/skills/talking-head-recut/SKILL.md
+++ b/skills/talking-head-recut/SKILL.md
@@ -950,10 +950,11 @@ ffmpeg -y -i "$VIDEO_PATH" -c:v libx264 -crf 18 -g 30 -keyint_min 30 \
-
-
-
-
+
+
+
+
+