mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-18 16:08:56 +00:00
fix(cli): exit 2 for remaining flag validation errors (#6639)
* fix(cli): exit 2 for remaining flag validation errors Flag and argument checks that commands make themselves still exited 1 and reported runtime_error under --json. They now take the existing usage-error path (failUsage / CliUsageError): exit 2 and a usage_error envelope. This covers lambda and cloudrun render/render-batch (--width/--height, --fps, positive-number, enum and --output-resolution flags, unknown subcommands), capture, feedback, benchmark --runs, tts, init, snapshot, compare, grade-compare, check, normalize-audio, media-treatment, play/present --port, models, docs, browser and telemetry unknown subcommands, cloud render conflicting inputs, cloud delete without --no-confirm, and inline --variables. A few checks now run before project or stack lookup so a bad flag is reported first. Runtime failures (missing files, network, render errors) still exit 1. An unattended spinner now writes its start and progress text as plain stderr lines, not only the outcome, so tools watching init can see "Transcoding". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(cli): reject a bad snapshot --frames, quiet spinner progress, drop added comments - `snapshot --frames abc` (or 0, -3, 2.5) is now a usage error: exit 2, and a usage_error envelope under --json. It used to fall back to 5 frames silently. - An unattended spinner prints its start line once and its outcome, but no longer one line per progress update, which flooded stderr during remove-background and the Chrome download. - Removes the comment lines this branch added, so the comment ratchet passes. - The render --json test now expects exit 2 and usage_error for bad inline --variables. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
b84762230f
commit
2d3033c719
@@ -21,6 +21,7 @@
|
||||
|
||||
import { type CanvasResolution, resolveResolutionFlagPair } from "@hyperframes/core";
|
||||
import { VALID_CANVAS_RESOLUTIONS } from "@hyperframes/core";
|
||||
import { CliUsageError } from "./commandResult.js";
|
||||
|
||||
/**
|
||||
* Free-text prefix the thrown error is scoped to (e.g. `"[cloudrun render]"`,
|
||||
@@ -60,7 +61,7 @@ export function parseOutputResolutionFlag(
|
||||
const { outputResolution, outputResolutionAspectAgnostic } = resolveResolutionFlagPair(asString);
|
||||
if (outputResolution) return { outputResolution, outputResolutionAspectAgnostic };
|
||||
const aliasHint = options.aliasHint ?? "1080p, 4k, uhd, hd, …";
|
||||
throw new Error(
|
||||
throw new CliUsageError(
|
||||
`${options.surfaceLabel} --output-resolution must be one of ${VALID_CANVAS_RESOLUTIONS.join("|")} ` +
|
||||
`(or an alias: ${aliasHint}); got ${asString}`,
|
||||
);
|
||||
|
||||
Reference in New Issue
Block a user