mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-19 11:26:02 +00:00
fix(cli): wire aspect-agnostic resolution through cloudrun/lambda/batch + preflight recompute
Addresses R2 CHANGES_REQUESTED from Miga + Rames on PR #2529: 1. Sibling-surface gap (blocker): `hyperframes cloudrun render{,-batch}`, `hyperframes lambda render{,-batch}` all advertised the same tier-only aliases (`1080p` / `hd` / `4k` / `uhd`) but normalized them to `landscape` and never set `outputResolutionAspectAgnostic`. The distributed plumbing PR #2529 added received `undefined` from those callers, so portrait `1080p` still hit the original aspect-mismatch on Cloud Run / Lambda. Fix: introduce `resolveResolutionFlagPair` in `@hyperframes/parsers` (the single source of truth for the two-step normalize + aspect-agnostic detect) and route every distributed entrypoint through a shared `parseOutputResolutionFlag` CLI util so the alias signal now reaches `SerializableDistributedRenderConfig`. Studio Server keeps its canonical-only HTTP contract; that intent is now pinned in tests. 2. Preflight recompute (hardening): the earlier "downgrade aspect-mismatch" preflight cleared un-remapped mismatches, so IG 4:5 (non-preset aspect, no sibling) and portrait-4K comp + `--resolution 1080p` (remap + downsample) both slipped through to fail late in `resolveDeviceScaleFactor`. Now `checkRenderResolutionPreflight` computes the effective preset via `suggestMatchingPreset` (mirroring the compile stage's `adaptAspectAgnosticResolution`) and re-checks against that — only genuinely-fixable mismatches clear early. New tests pin both regressed input classes. 3. Docker forwarding boundary test (Miga's important #2): pinned `1080p` survives verbatim as `--resolution 1080p` in the Docker args so the in-container CLI can re-run `isAspectAgnosticResolutionAlias`. 4. Doc-nit (Miga): parsers/src/types.ts no longer references the nonexistent `resolveResolutionForComposition` — points at the actual remap helpers. Fallow: cloudrun.ts / lambda.ts share 390 lines of pre-existing structural symmetry (parallel AWS + GCP dispatchers), and lambda/render.ts + render-batch.ts declare parallel RenderArgs interfaces. Both re-flagged after threading the aspect-agnostic field through each surface; ignored with justification in .fallowrc.jsonc. lambda.ts's `run` and lambda/render.ts's `waitForCompletion` are pre-existing CRAP-score hotspots untouched by this PR — added under health.ignore. Co-Authored-By: Claude <noreply@anthropic.com> — Via
This commit is contained in:
@@ -2,7 +2,12 @@ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
|
||||
import { tmpdir } from "node:os";
|
||||
import { join } from "node:path";
|
||||
import { parseBatchFile, runWithConcurrencyLimit } from "./render-batch.js";
|
||||
import {
|
||||
buildLambdaBatchRenderConfig,
|
||||
parseBatchFile,
|
||||
runWithConcurrencyLimit,
|
||||
type RenderBatchArgs,
|
||||
} from "./render-batch.js";
|
||||
|
||||
let tmpDir: string;
|
||||
|
||||
@@ -137,3 +142,38 @@ describe("parseBatchFile", () => {
|
||||
expectExitOne('{"outputKey":"renders/a.mp4","variables":[1,2,3]}\n');
|
||||
});
|
||||
});
|
||||
|
||||
// See `../cloudrun.test.ts` / `./render.test.ts` for the sibling wire-config
|
||||
// coverage. Repeating it at every entrypoint is deliberate: cross-scaffold
|
||||
// drift is exactly what shipped PR #2529 R2 CHANGES_REQUESTED.
|
||||
describe("buildLambdaBatchRenderConfig — aspect-agnostic wire threading", () => {
|
||||
const baseArgs: RenderBatchArgs = {
|
||||
projectDir: "/tmp/hf-batch",
|
||||
stackName: "hf-test",
|
||||
batch: "/tmp/batch.jsonl",
|
||||
fps: 30,
|
||||
width: 1080,
|
||||
height: 1920,
|
||||
format: "mp4",
|
||||
json: false,
|
||||
};
|
||||
|
||||
it("threads outputResolutionAspectAgnostic=true through for portrait 1080p", () => {
|
||||
// The batch entrypoint fans out N Step Functions executions from a
|
||||
// single wire config, so a dropped alias flag multiplies into N broken
|
||||
// renders — pin it here.
|
||||
const config = buildLambdaBatchRenderConfig({
|
||||
...baseArgs,
|
||||
outputResolution: "landscape",
|
||||
outputResolutionAspectAgnostic: true,
|
||||
});
|
||||
expect(config.outputResolution).toBe("landscape");
|
||||
expect(config.outputResolutionAspectAgnostic).toBe(true);
|
||||
});
|
||||
|
||||
it("keeps the aspect-agnostic key absent when the flag is a canonical preset", () => {
|
||||
const config = buildLambdaBatchRenderConfig({ ...baseArgs, outputResolution: "portrait-4k" });
|
||||
expect(config.outputResolution).toBe("portrait-4k");
|
||||
expect(config.outputResolutionAspectAgnostic).toBeUndefined();
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user