From 2f321e0b0bb13eedefe3f8d206df33956347a809 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel?= Date: Wed, 4 Nov 2026 21:25:49 +0000 Subject: [PATCH] ci(studio): the studio-open journey counts the same thumbnails on every runner image (#7187) At 900 px the root composition card sat on the edge of the list's thumbnail margin, so a small layout change between runner images decided whether it asked for a thumbnail. A 1400 px window puts every card well inside it. --- .github/workflows/ci.yml | 2 +- packages/studio/tests/e2e/perf-ceilings.json | 8 ++++++-- packages/studio/tests/e2e/studio-open-counts.mjs | 4 +++- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fd7203fe3b..727aebe4db 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -981,7 +981,7 @@ jobs: - run: bun run --cwd packages/core build - run: bun run --cwd packages/core build:hyperframes-runtime - name: Set up the Chrome build the work-count ceilings were measured on - # The runner image's Chrome moves under the gate: 156.0.8078.79 renders one more thumbnail than .47. + # The ceilings are counted on one Chrome build, so a Chrome release cannot move them. # Bump this with the ceilings in packages/studio/tests/e2e/perf-ceilings.json, never alone. id: chrome uses: browser-actions/setup-chrome@c785b87e244131f27c9f19c1a33e2ead956ab7ce # v1 diff --git a/packages/studio/tests/e2e/perf-ceilings.json b/packages/studio/tests/e2e/perf-ceilings.json index ed6c6f8d52..6ef906b0e0 100644 --- a/packages/studio/tests/e2e/perf-ceilings.json +++ b/packages/studio/tests/e2e/perf-ceilings.json @@ -2,10 +2,14 @@ "studio-open": { "browser": "156", "counts": { - "thumbnailRenders": 13, + "thumbnailRenders": 14, "total.frameNavigations": 7, "total.requests.document": 2, - "total.requests.thumbnail": 14 + "total.requests.thumbnail": 15 + }, + "raised": { + "thumbnailRenders": "The journey's window grew from 900 to 1400 px so every composition card, the root's too, asks for its thumbnail on any runner image. Studio does no new work.", + "total.requests.thumbnail": "The journey's window grew from 900 to 1400 px so every composition card, the root's too, asks for its thumbnail on any runner image. Studio does no new work." } } } diff --git a/packages/studio/tests/e2e/studio-open-counts.mjs b/packages/studio/tests/e2e/studio-open-counts.mjs index cd7f92bcfe..3d168e5a17 100644 --- a/packages/studio/tests/e2e/studio-open-counts.mjs +++ b/packages/studio/tests/e2e/studio-open-counts.mjs @@ -61,7 +61,9 @@ const browser = await puppeteer.launch({ }); try { const page = await browser.newPage(); - await page.setViewport({ width: 1600, height: 900 }); + // Tall enough that every composition card is well inside the list's 200 px thumbnail margin. At 900 px the root card + // sat on that edge, and the runner image's fonts decided whether it asked for a thumbnail. + await page.setViewport({ width: 1600, height: 1400 }); const counters = await startWorkCounters(browser, page); const thumbnailsInFlight = new Set(); const thumbnailOutcomes = [];