feat(studio): automate and un-automate each effect parameter (#3026)

* feat(core): audio FX registry

One declarative description of every effect that can be applied to an audio
track: fourteen across filters, dynamics, non-linear and time, each exposing
its full parameter surface rather than a curated subset.

Parameters carry the range, step, unit and scale a control needs, so a panel
can generate its UI from this rather than hard-coding a form per effect, and a
value that survives `normalizeAudioFxParams` is always safe to realise.
Everything is declared in the units a person thinks in — dB, ms, Hz.

Parsing rejects an unknown effect id rather than skipping the node. A chain
that quietly loses an effect renders something other than what was authored,
which is worse than refusing to load it.

Data only: no audio is produced here. The graph that realises each effect is
referenced by the `web` id and lands in the next change, which keeps this
module free of browser globals so the engine and the linter can import it.

* fix(core): stop declaring knobs that move nothing

Three parameters were declared with ranges, defaults and hints, and read by no
builder — dials an author could turn with no audible result.

- `chorus.decay` and `bitcrush.aa`: removed. FFmpeg's chorus feeds a decay back
  into its delay line and a bitcrusher's anti-alias needs a real filter; adding
  either is new DSP, not a fix, so the honest move is to stop advertising them.
- `lowshelf.q` / `highshelf.q`: removed. The Web Audio spec leaves Q unused for
  shelving filters, so the control moved nothing — and because the shared Q
  helper marks it automatable, an author could draw an envelope on it and hear
  nothing at all.

`phaser.decay` and `gate.knee` stay: the first drives the sweep depth, and the
second is now read by the gate's processor.

A test asserts each of these directly, since the existing exposure invariant only
checks that a flagged parameter reaches an AudioParam — a parameter the node then
ignores passes it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(core): Web Audio graphs for the FX registry

One graph builder per `web` id, turning the registry's declarations into
running audio.

Every node exposes `update`, so turning a dial re-parameterises the live graph
rather than rebuilding it: an AudioParam change lands on the next 128-sample
quantum, about 2.7 ms at 48 kHz. `buildFxChain` reports whether an update could
be applied in place — adding or bypassing an effect, or switching a filter
between one and two poles (which changes the node type from BiquadFilterNode to
IIRFilterNode), changes the graph's shape and returns false so the caller
rebuilds.

Four effects have no native node and run as AudioWorklet processors:
compressor, limiter, gate and bitcrush. The module is registered from a data:
URL rather than a blob:, because a blob inherits the page origin and is opaque
on a file:// page, where it fails with an unhelpful AbortError.

Reverb has no single node either. `synthesizeReverbImpulse` generates a tail
from the room parameters, seeded so the same room sounds the same on every
machine, and the ConvolverNode uses it.

Tests cover the wiring — which nodes get built, how they connect, parameter
application and clamping, in-place update versus rebuild, disposal — against a
fake AudioContext, since happy-dom has no Web Audio.

* fix(core): reverb level, phaser wiring, per-channel dynamics, one-pole rebuild

Four defects in the graph builders, all found by review rather than by ear.

**Reverb was unusable at its own defaults.** A ConvolverNode applies the
impulse's gain whole — the graph sets `normalize = false` so a room is
deterministic rather than browser-defined — but the impulse was raw decaying
noise. Measured L2 at the registry default (size 0.7 / damping 0.5): 46.4, or
+33.3 dB, putting the wet path ~24 dB over dry at the default `wet: 0.35`. It is
now normalised to unit energy, so the wet knob means what it says. Preview and
render both convolve this buffer, so they stayed identical throughout — equally
deafening before, equally correct now.

**Phaser in_gain/out_gain trim the signal entering and leaving the effect**, not
a wet/dry pair. Wired to the wet and dry legs, "Input" muted the dry path and
the two defaults summed to 1.14, so inserting a phaser raised the track level.
They are now input and output trims with the legs summed at unity. Its declared
waveform is also honoured: `lfo.type` was never assigned, so the default
"Triangular" was silently a sine.

**The dynamics worklets held one envelope across a channel-major loop.** The
followers advance per sample, so on stereo a 20 ms attack behaved as 10 ms, and
the right channel's gain came from an envelope that had already traversed the
left — the two ducked differently from the same input and the image pumped.
State is now per channel, as is the gate's smoothed gain and bitcrush's
sample-hold counter, which previously advanced only on the last channel and left
every earlier one frozen for a whole quantum. The gate also honours the knee it
declares instead of chattering on material sitting at the threshold.

**A one-pole filter's cutoff was swallowed in preview.** Its coefficients are
fixed at construction, so `update` cannot push a new frequency — but the shape
signature carried only type and pole count, so a cutoff change looked like a
values-only edit and went into a no-op updater. Preview kept filtering at the
old frequency while the render used the new one: a preview/render divergence in
exactly the two effects that do not use a BiquadFilterNode.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(engine): render audio FX in an OfflineAudioContext

Reads `data-fx-chain` off an audio element and runs the chain over the trimmed
WAV before volume automation is baked in — effects should see the raw signal,
and the envelope belongs on their output.

The processing happens in an OfflineAudioContext inside the headless browser
the engine already drives, running the same graph builders the studio previews
with. That is the point of the approach: one implementation per effect, so the
render agreeing with the preview is a property of the architecture rather than
a tolerance to police. Reimplementing each effect as an FFmpeg filter would
mean two implementations to keep in step, and for the dynamics processors and
modulated delays there is no filter that behaves the same way.

`build:audio-fx-runtime` bundles the graph builders into an injectable IIFE,
following the same pattern as the existing runtime artifacts, so the browser
runs exactly the code the studio does.

The page loads from a file:// URL rather than about:blank because AudioWorklet
is only exposed in a secure context — the compressor, limiter, gate and
bitcrush processors would otherwise fail to register with an opaque error.
file:// qualifies and needs no listening socket.

The chain is serialised into the attribute the way colour grading carries its
config, so there is no side-car file to resolve or lose.

An FX failure is fatal for the whole mix rather than a per-track soft failure.
Every other audio failure mode degrades gracefully — the track drops, siblings
continue — but substituting the dry signal for a processed one ships a render
that sounds plausible and is not what the author set up. Since the per-element
work races under Promise.all, an internal AbortController chained off the
caller's signal aborts in-flight siblings before workDir is removed.

* feat(core): voiceover carve analysis

Finds the bands a voice occupies so a music bed can be dipped there, letting
the voice sit in front without ducking the whole track.

Carve is a relationship between two tracks rather than an effect on one, so it
stays out of the FX chain. What it emits is an ordinary chain of peaking
filters, so a carve composes with whatever else is on the track and needs no
separate rendering path.

Selection is weighted toward intelligibility rather than raw voice energy.
Ranking purely by power lands on the fundamental almost every time, because
that is where a voice is loudest — but the masking that actually hurts a
voiceover happens higher up, and dipping 160 Hz mostly just thins the bed. The
bias is a control, not a constant: at 0 it follows raw energy, at 1 it weights
toward 1-3 kHz.

Ranking happens in dB, which matters more than it looks. Speech spreads 20-30 dB
across these bands — it falls off roughly 6 dB per octave above the fundamental
— so a weighting has to be on that scale to move anything at all. A
multiplicative weight of `1 - bias + bias * shaped` is bounded below by
`1 - bias`, capping its influence at 10*log10(1/(1 - bias)): 5.2 dB at the 0.7
default, 3 dB at 0.5. That is no influence against a real voice — every bias
short of ~0.95 would rank exactly like bias 0 and carve the fundamental, the
outcome the bias exists to prevent, while looking decisive against a fixture
whose bands sit 2 dB apart. So the bias is a dB penalty, zero at 2 kHz and worth
up to 30 dB at full strength, and relative cut depths come from a dB difference
rather than a ratio of weighted linear powers.

The bias reweights ranking without overriding the spectrum — a band the voice
has no energy in is not worth carving, and scores -Infinity rather than
competing — so a strongly low-pitched voice can still select low at full bias.
What the tests hold is that biasing never selects lower than the unbiased
ranking, that the DEFAULT bias reaches the presence region on a voice with a
realistic tilt, and that bias 0 still follows raw power exactly.

Includes a radix-2 FFT rather than a dependency; one Welch-style averaged
spectrum over third-octave bands does not justify pulling in a DSP library.

* fix(engine): keep the FX render 16-bit, stereo, and correctly sized

Three defects in the offline FX path, none of which any test could see.

**Float output silently disabled sample-accurate volume automation.** The writer
emitted 32-bit IEEE float; the very next mixer step bakes the volume envelope
into the samples and accepts only 16-bit PCM, returning null otherwise. So
enabling any effect downgraded that track to the ffmpeg expression path — capped
at 32 straight segments, quantising a curved envelope, and on a dense one falling
back to base volume. It now writes 16-bit PCM, clamped rather than wrapped so a
limiter at 0 dB or a resonant filter cannot turn overshoot into a click. A test
asserts the baker accepts the writer's own output and actually fades it.

**Everything was folded to mono.** `prepareAudioTrack` goes out of its way to
emit stereo — its pan filter exists to dodge ffmpeg's 3 dB mono-to-stereo
rematrix — and this folded it, then wrote one channel. So adding a single peaking
EQ collapsed a bed's width and cost ~3 dB in the render, while preview stayed
stereo. Channels now travel as one plane each, through an OfflineAudioContext of
the same width, and come back interleaved.

**Small results decoded the wrong length.** `new Float32Array(buf.buffer)`
discards byteOffset and byteLength, and Node pools small allocations: a 400-byte
payload sits at offset 8 inside an 8 KiB pool, so a clip under ~1024 samples
decoded as 2048 samples of unrelated memory — and the empty-result guard could
not see it. The reader has the mirror-image fix: a float data chunk on an odd
boundary (ffmpeg's pcm_f32le writes fmt(18) + fact, landing `data` at 58) now
copies instead of throwing RangeError on an unaligned view.

The tail limitation is now stated rather than mis-stated: the context is exactly
as long as the input, so a reverb or delay still ringing is cut there. The old
comment claimed the opposite. How far a tail may run past a clip's end changes
the clip's length in the mix, so it is a product decision, not one to make here.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(producer): report an FX render failure as an audio error

`processCompositionAudio` reports per-track failures in its result, but an FX
failure it cannot degrade past — a browser that will not launch, a chain that
will not build — rejects instead. `runAudioStage` had no try, so that rejection
escaped to the orchestrator as an unclassified pipeline exception, losing the
stage/owner/retryable classification this stage exists to attach, and skipping
its abort check on the way out.

It now lands in `audioError` alongside every other cause, while an abort still
keeps its own shape rather than being reported as an audio problem.

Not done here: committing the generated `audio-fx-runtime-inline.ts` so a fresh
clone typechecks packages/engine without building first. The bundle is built from
the stub, and the stub changes three times across this stack — so the artifact
differs per branch and would conflict on every restack. Its model,
position-edits-render-inline.ts, is committed only because it is stable. Building
before testing is this monorepo's existing contract (studio's tests need core's
dist too), so the gap is not specific to audio FX and is better closed by a build
ordering gate than by committing a per-branch artifact.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* test(engine): skip the browser FX render cases when there is no browser

CI's `Test` job was red on this PR with four failures, all the same cause:

  Failed to launch the browser process: spawn
  /home/runner/.cache/hyperframes/chrome/chrome-headless-shell

The job installs ffmpeg and no browser, deliberately — every other suite
that needs an external binary already guards on it
(`describe.skipIf(!HAS_FFMPEG)`). These cases were the only ones assuming
a Chrome, so they failed on an absent dependency rather than on anything
about the code.

Guards on `resolveHeadlessShellPath()` — the same resolver
`acquireBrowser` launches through, so the check cannot drift from the
thing it guards the way a hard-coded cache path would. A configured path
that does not exist throws; that is caught and read as "cannot run here".

Checked both directions rather than just the green one: with a browser all
11 cases run and pass, and with `HYPERFRAMES_BROWSER_PATH` pointed at a
missing binary exactly 3 skip and the other 8 still run. A guard that
silently skipped everything would have looked identical in CI.

They keep their value where it exists — every developer machine, and any
job that has run `hyperframes browser ensure`.

Not touched: the CodeQL failure on this PR is a run from 2026-08-07, five
days and several force-pushes stale. None of the 17 open repo alerts are
in files this PR changes; it re-runs on this push.

* chore(engine): suppress the temp-file alert with the reason it is safe

CodeQL flags `writeWav`'s `writeFileSync` as js/insecure-temporary-file
(high) — the one new alert on #3021, and the reason its CodeQL check is
red.

It is a false positive, and the comment says why rather than just silencing
it: `path` is always inside a directory made by `mkdtempSync`, never a
name assembled directly under `tmpdir()`. Both callers are covered — the
browser host page writes into `mkdtempSync(join(tmpdir(), "hf-fx-host-"))`,
and the render output goes to the producer work dir, itself
`mkdtempSync(join(tempRoot, "producer-project-"))`. mkdtemp picks the
random suffix and creates the directory 0700 in one syscall, so the
predictable filename inside it cannot be pre-created or symlinked by
another user, which is the attack the rule is about. The analyzer sees the
dataflow reach `tmpdir()` and not the mkdtemp in between.

Suppressed inline rather than dismissed in the UI, so the justification
lives next to the code and the rule stays live for anything added later in
this file. Matches the repo's existing convention — `planV2.ts:222`
carries an `lgtm[js/insecure-temporary-file]` for a different reason on
the same rule.

Correcting myself: I first reported this alert as not real, having
intersected the PR's files against the default-branch alert list, which
does not contain PR-ref alerts. Querying ?ref=refs/pull/3021/merge returns
it straight away.

* feat(core): register the audio-fx-rack canary at 0%

Lands the rollout switch dark, per the registry's own procedure: "Start at
percentage: 0 and merge that — a canary at 0 is dead code you can land
safely and ramp without a code review."

Declared at the bottom of the stack so every branch above can read it. The
gate itself goes in at wa-4-fx-panel, where the rack first appears.

Scope is deliberate and stated in the description: it gates the AUTHORING
surface only. A composition that already carries `data-fx-chain` still
plays and renders it. A canary should stage who can REACH a feature, not
make an attribute somebody already wrote silently inert — an agent that
writes a chain through the skill would otherwise produce a file whose audio
processing vanishes with no error.

* feat(studio): audio FX panel generated from the registry

Controls for the whole chain: add, remove, reorder, bypass, and every knob each
effect declares.

Nothing in the panel knows what a compressor is. The registry supplies each
parameter's range, step, unit and scale and the panel renders what it finds, so
adding an effect or a knob upstream needs no change here, and the panel cannot
offer a value the renderer would reject — a typed-in figure is clamped into the
declared range on the way through.

Frequency and time controls span three or four decades, so those declare a log
scale and the slider maps exponentially; a linear slider would spend most of
its travel somewhere useless.

Reorder is a first-class control because chain order changes the sound: a
reverb before a compressor is not the same as after.

Carve gets its own block rather than an entry in the add menu, with a picker
for the voice track to listen to. It processes this track based on another one,
which is how a sidechain control works — it lives on the track that changes,
and names the source.

* feat(studio): show the Audio FX section on audio tracks

Adds `audioFx` to the editing-affordances contract and renders the FX panel in
the inspector when an `<audio>` element is selected.

The section is audio-only. A `<video>` carries its sound on a separate
`<audio>` element, so an FX chain on the video would have nothing to process.

Chain and carve settings are written straight back onto the element as
serialised attributes, the way colour grading carries its config, so
persistence is an ordinary attribute write and needs no new server route. A
chain that cannot be parsed renders as empty rather than breaking the panel,
and the attribute is left untouched until the user changes something.

The collapsed group summarises what is on the track ("2 effects + carve") so
the state is visible without expanding it.

Wired into PropertyPanelFlat rather than PropertyPanel: STUDIO_FLAT_INSPECTOR_ENABLED
defaults to true, so the flat inspector is what actually renders.

* refactor(studio): lift audioFxSummary out of PropertyPanelFlat

`PropertyPanelFlat.tsx` is 612 lines here against the repo's 600-line cap,
so the required File size check is red — the sole reason this PR is
blocked. The review says as much: "mechanical fix (~5 min), not a design
problem. Code itself is LGTM."

Moves `audioFxSummary` to `audioFxSummary.ts`, the same file a later
branch creates for it. Deliberately the smallest cut that clears the cap
rather than the whole `AudioFxGroup` extraction: every later commit in the
stack edits AudioFxGroup, so moving it here would collide with each of
them, while almost nothing touches this function.

595 lines.

* feat(studio): put the audio FX rack behind its canary

Gates the rack on `isCanaryEnabled("audio-fx-rack")`, which is registered
at 0% — so the whole 47-PR stack can land without showing anyone a feature
that has not been measured yet.

The gate sits on the AUTHORING surface and nowhere else. The runtime and
the render still honour a `data-fx-chain` already on an element, so a
composition written through the skill or by `carve.mjs` keeps its
processing rather than going silently dry for anyone outside the cohort. A
canary should stage who can REACH a feature, not make an attribute somebody
already wrote stop working with no error.

Gated at the panel rather than in `resolveEditingSections`: the affordance
resolver is a pure function in core describing what an element CAN support,
and rollout state is not a property of an `<audio>` tag.

Pinned the 0% with a test, and checked it fails at 25 — a ramp should have
to break something that says "this ships dark" out loud.

One gap, stated rather than papered over: the gate itself has no unit test.
I wrote one and deleted it, because `PropertyPanel.test.tsx`'s harness
never renders the Audio FX group for its audio fixture even with the gate
removed — so the test passed for the wrong reason in the off case and could
not pass at all in the on case. A test that cannot fail for the right
reason is worse than none. Verifying the gate needs the panel harness to
mount that section first, which is its own change.

* feat(core,studio): hear the FX chain in preview, and run the carve analysis

Splices an element's FX chain into the playback graph so preview stops being
silent about effects, and wires the carve button that was previously inert.

The chain goes between the decoded source and its gain stage: effects see the
raw signal and volume automation rides on their output, matching the order the
offline render uses. Since preview and render call the same graph builders,
what is heard while scrubbing is what gets written.

The splice lives in the transport rather than on the `<audio>` element. The
transport plays each track from a decoded AudioBuffer and mutes the element to
avoid doubling, so capturing the element with createMediaElementSource would
have processed a stream nothing is listening to — it looked like it worked
because the call succeeded, and the audio was unchanged.

A chain that cannot be built plays dry rather than silencing the track, which
is the right failure in preview: the author keeps working and hears the source.
The render still refuses, because shipping the dry signal there would be wrong.

Carve now analyses for real: it decodes the chosen voice track, ranks its bands
and writes the resulting peaking filters onto this track. Generated nodes are
tagged `fromCarve`, so re-running replaces the previous carve instead of
stacking another set on top of hand-added effects.

Known limitation: the graph is built when a source is scheduled, so a knob
turned mid-playback takes effect on the next play or seek rather than
immediately. Live re-parameterisation needs the transport to hold the handle
and forward updates.

* fix(studio,core): stop parameter drags from restarting playback

Dragging a knob wrote the chain through the persisting attribute path on every
input event. That path refreshes the preview, which reloads the composition and
reschedules audio — so a single drag reloaded dozens of times and playback
stuttered the whole way.

Drags now go through `onSetAttributeLive`, the same path colour grading uses for
scrubs: it coalesces undo entries and sets `skipRefresh`, so no reload happens.
The persisting write fires once, when the gesture ends — pointer-up or blur for
a slider, Enter or blur for a typed value. A select commits immediately since
there is no drag to wait for.

While dragging, the control is driven from local state. Waiting for the value to
round-trip through the element attribute made the knob lag behind the pointer.

For the change to be audible without a reload, the graph now follows the
attribute: the chain installed by the transport observes the element and
re-parameterises itself in place, so a value change lands on the next
128-sample quantum. A shape change (effect added, bypassed, pole count) cannot
be patched into a running graph, so it still waits for the next schedule rather
than cutting the audio mid-play.

The regression test drags a slider through several values and asserts the
persisting handler is untouched until release.

* fix(core): register FX worklets before building nodes that need them

An AudioWorkletNode cannot be constructed before its processor is registered —
it throws, and the surrounding chain is lost with it. `attachElementFxChain`
built the chain first and only then called `ensureAudioFxWorklets`, so every
worklet-backed effect (compressor, limiter, gate, bitcrush) threw on
construction and the track fell back to dry. Instrumenting the preview showed
`hf-compressor: InvalidStateError` with addModule never called at all.

When the module has not landed yet the track now plays dry and the graph is
swapped in once registration resolves, so the effect arrives a moment late
instead of never.

Registration is also tracked per context rather than in one module-level
promise. A processor registered on one AudioContext does not exist on another,
so the shared promise made every context after the first believe it was ready
when it was not — the studio's transport owns its own context, which is exactly
that case.

With the worklets actually running, the compressor's per-sample log10 and pow
became real audio-thread work. Samples below the knee have a gain of exactly
unity and need neither, so the envelope is now compared in the linear domain
and the transcendentals only run for samples that are actually being
compressed.

* refactor(studio): split the FX node row out of FxSection

Clears the health findings the FX stack left behind: the chain-node render
callback was a 70-line closure over half of FxSection's state, and the two
reorder arrows were the same button written twice.

Also drops two exports with no consumers, and registers the audio FX runtime
stub as an entry point — it is bundled by file path, so nothing imports it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(studio): lift the audio FX group out of PropertyPanelFlat

`PropertyPanelFlat.tsx` was 672 lines against the repo's 600-line cap, so
the required File size check was red — the sole reason #3014 and #3022 are
blocked. Both reviews say the same thing: "mechanical fix, not a design
problem. Code itself is LGTM."

Moves `AudioFxGroup` and `audioFxSummary` into
`propertyPanelAudioFxGroup.tsx`, which is where a later branch puts them
anyway — done here so the file is under the cap from the point it first
crosses it, rather than ten branches later.

533 lines now. The four audio imports it no longer needs go with it.

Not fixed here: three `FxSection carve` tests fail on this branch with
"Cannot read properties of undefined (reading 'toFixed')". Confirmed
pre-existing by stashing this change and re-running — that is the separate
`Test` failure the review also flags.

* feat(core): automation envelope model for audio tracks

Adds the data model behind Ableton-style automation lanes: breakpoint
envelopes over track volume or one knob of one effect in the track's FX
chain, stored on the element as `data-automation`.

Times are clip-local, so an envelope travels with the clip when it moves —
the clip-envelope model rather than arrangement automation.

`sampleAutomationLane` is the single interpolator. The lane drawing, the
preview scheduler and the render bake all call it, so the picture and the
sound cannot disagree about the curve. Log-scaled parameters interpolate in
log space, matching what their own knob already promises.

FX nodes gain a stable `id`, minted by count rather than randomly so the
document is the same on every machine. Lanes address nodes by id, so
reordering a chain never re-points a lane at a different effect, and a lane
whose effect was deleted is dropped rather than left to reattach.

Also warns when a track carries both a volume lane and a GSAP volume tween,
since only the lane is heard and the tween silently does nothing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(core): expose the AudioParams behind automatable FX knobs

Marks the knobs an automation lane can drive and has each graph builder hand
back the AudioParam behind them, so a scheduler can write to a running effect
without knowing what the effect is.

A knob is not always one AudioParam. A wet/dry mix is two gains moving in
opposition, and a knob in milliseconds drives a delay time in seconds, so
each target carries the mapping out of the knob's own declared unit.

What stays unautomatable is stated where it is decided: a WaveShaper curve, a
convolution impulse and a one-pole filter's coefficients are all rebuilt
wholesale rather than scheduled, and the four worklet effects take values by
postMessage rather than through AudioParams.

The registry flag is written by hand, so a test builds every effect and
checks the exposure both ways — nothing flagged is missing, nothing exposed
is unflagged. A flag that lied would offer a lane that silently did nothing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(core): play automation envelopes in preview

Schedules each lane onto the AudioParams behind its knob using native ramps
and value curves. Nothing evaluates the envelope per frame: it is handed to
the audio thread once, so it stays sample-accurate however busy the main
thread is, and the offline render will schedule it the same way.

Timing comes from the transport, so an envelope survives seeking into the
middle of a clip, a clip that has not started yet, and a playback rate that
compresses clip seconds into context seconds.

A straight line is only scheduled as a ramp when nothing bends it — no
curvature, a linear parameter scale, and no unit mapping. Log-scaled
parameters and mapped ones are sampled instead, since a delay knob in
milliseconds and a wet/dry pair moving in opposition are not linear in the
parameter they drive.

Lanes with nowhere to write are skipped rather than reported: a one-pole
filter exposes no frequency param, and the worklet effects expose none at
all. Editing an envelope mid-playback re-aims it at the live playhead rather
than restarting the track.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(engine): bake automation envelopes into the render

The offline render schedules FX lanes with the same scheduler preview uses,
inside the OfflineAudioContext that already runs the same graph builders. The
input WAV is the clip's own audio from its first sample, so clip-local time
is offline time and the envelope needs no offset.

Volume lanes take the existing PCM bake rather than a second mechanism: the
lane is converted to keyframes, so a straight fade stays two of them and only
a bent segment is sampled — the baker interpolates linearly and would
otherwise quietly straighten the curve. A volume lane supersedes keyframes
probed from the timeline, which `lint` already warns about.

A browser test sweeps a lowpass from below a 2 kHz tone to well above it and
measures both ends. Parsing the envelope is not the same as scheduling it,
and only running the real thing tells the two apart.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(core): make the volume lane audible in preview

The envelope was scheduled onto the transport's gain AudioParam, but the
runtime rewrites that gain every tick from `data-volume` and the GSAP-seeked
value — so it was erased within a frame. Volume automation was correct in the
render and inaudible while previewing.

The lane now feeds the per-tick path where the probed volume keyframes already
sit, checked ahead of them so the two cannot fight, and the transport no
longer schedules volume at all: one mechanism instead of two racing.

The cost is honest — in preview the level steps per tick rather than per
sample, exactly as the existing keyframe path does. The render still bakes it
into the PCM sample-accurately, and FX parameters are still scheduled on their
own AudioParams, since nothing rewrites those.

Parsed lanes are cached by attribute text: the runtime asks once per tick per
track, and parsing there would run the JSON parser 60 times a second for a
value that only changes on an edit.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(core): apply chain edits to the running graph

A structural edit — an effect added, removed, bypassed, or a filter's pole
count switched — was dropped. `buildFxChain`'s update reports false when the
change is not merely new values, and the attribute observer ignored that, so
the edit only took hold when the persisting write reloaded the composition.
That reload restarted every playing track, which is what was heard as the
audio chopping.

The graph is now swapped in place: the old effects are detached, the new ones
built and connected between the same source and gain, and any lanes
re-scheduled onto the new nodes. The source node is never touched, so playback
does not restart.

A track with no chain is watched too, rather than wired through and forgotten,
so adding its first effect is heard the same way. That means the function
always returns a disposer instead of null for the empty case.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(studio): the geometry and plumbing behind automation lanes

Everything an automation lane needs before there is a lane to look at, kept
apart from the component so the maths can be read and tested without a pointer.

`automationLaneGeometry` is pure: which parameters a clip can automate (its
fader, then each automatable knob of each effect that carries a node id), how a
value maps to a position in the lane, and how a lane is edited. Two decisions
live here and are worth review:

- A log-read knob maps on its own log scale, so the middle of a 100 Hz–20 kHz
  lane is the geometric mean. Dragging and drawing then agree with what the
  knob's own scale already promises.
- `withLane` replaces a lane in place rather than appending. A lane with no
  explicitly chosen parameter shows whichever comes first, so moving the edited
  one to the end would switch the lane out from under the pointer on the first
  edit.

`automationLaneData` parses the two attributes, cached by their text so the
identity only changes when the text does — the lane holds an optimistic draft
while a point is dragged and compares against that identity, and a fresh object
on every playhead tick would throw the drag away. It binds automation to the
chain the way preview and the render bind it, so a lane whose effect was deleted
is dropped rather than drawn against the wrong axis.

`useAutomationLanes` routes edits through the DOM edit session, targeting the
selected element because that is what the attribute commit path writes to.

Row height reserves each lane at its own height rather than counting it as
another keyframe lane, and `TimelinePropertyLanes` gains a footer slot so the
lanes share the keyframe disclosure — and its `aria-controls`.

`TimelineElement` moves to its own module: playerStore had reached the 600-line
studio ceiling exactly and could not carry another field. It is re-exported from
there, so no importer changes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

* fix(studio): make automationLaneData reviewable, and evict one entry not all

The cache key held a literal NUL byte instead of its escape, so git classified
the whole module as binary: it landed as `Bin 0 -> 2677 bytes` with zero
diffable lines, invisible to review, to grep, and to any textual merge. The
escape is behaviour-identical.

With the file readable, two things in it needed fixing.

Eviction cleared the entire map. Clearing changes the identity of every lane's
automation at once, and a lane compares its drag draft against that identity —
so one unrelated element arriving at the limit would release an in-progress drag
and snap the point back. It now drops the oldest entry, and a hit is re-inserted
so it counts as recently used.

Nothing tested this module, which is what let the binary blob through. Now
covered: identity stability, re-parsing when the chain changes but the
automation text does not, a hot entry surviving 40 evictions, and an unreadable
attribute reading as nothing.

The geometry module's exports are ignored for dead-code while its consumer sits
one PR upstack, following the convention already used for the fast-capture
stack.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(studio): carry the audio FX attributes onto every timeline row

Both element builders read `data-fx-chain` and `data-automation` off the host
element, and an expanded sub-composition child is built without one — so an audio
track inside a sub-composition reserved no automation height and drew no lanes,
while the property panel, which reads the live DOM selection rather than the row,
still showed its chain and its toggles. `hostElementState` exists to re-inherit
exactly this class of host-only field; it now covers these two alongside
`hidden`, `timelineLocked` and `timelineRole`.

`parseTimelineFromDOM` had the same gap and now reads both directly.

Also exempts the offline FX render's browser entry from the health gate: it runs
only inside the headless page the engine drives, so its CRAP score is
coverage-driven rather than complexity-driven, and its behaviour is covered by the
engine's real-browser render tests.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(studio): the automation lane itself

Draws each automated parameter as its own lane under the audio clip, on the same
disclosure caret the keyframe lanes use — that caret is the DAW automation
triangle. One lane per parameter rather than a selector to swap between them, so
two envelopes can be read and edited without hiding either.

Double-click the line to add a point, drag to shape it, right-click a point to
remove it.

Three things here took more than one attempt, and the comments say why:

- **A dragged point did not move.** The live write deliberately skips the preview
  refresh — that is what keeps dragging from restarting playback — so the stored
  value does not move under the pointer. The lane keeps a local draft.
- **Releasing snapped it back.** The draft was dropped when the drag ended, which
  is before the persisted write comes around; it now lives until the automation
  it was drawn over actually changes.
- **A press was eaten.** Not stopping propagation let the timeline start its own
  gesture and swallow the second half of a double-click. The lane owns the press
  once it is live — and when it is not, it selects its clip instead, since lanes
  sit below the clip bar where the timeline's own selection handler never sees
  them.

The envelope is inset by the grab radius so a point at the clip's first or last
frame is drawn whole rather than half outside the lane, and clip time still lines
up with screen position because the inset and the offset cancel.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

* fix(studio): let a track disclose its automation without a tween

The lane was mounted inside the property-lanes wrapper, which renders only for a
track's GSAP keyframe clip — so an audio clip with no tween resolved to nothing:
no disclosure caret, no reserved height, no lanes. Verified on a composition with
one `<audio>`, an envelope, and no tweens anywhere: 0 carets, 0 lanes. The
attribute still wrote and the render still baked it, so the feature failed
silently for exactly the tracks it exists for. Same composition now: 1 caret, and
expanding it draws the Volume lane.

Automation counts as something to disclose. `resolveTrackKeyframeClip` takes a
counter alongside the keyframe lane counts and qualifies a clip on either; the
header asks the same counter about the clip it already holds. A function rather
than another map threaded through the props: every caller then reads one cached
parse, so the height a row reserves and the lanes drawn in it cannot drift apart.

That drift is also fixed for the lane's own offset, which passed the raw tween
count where every other consumer uses distinct property groups. Two tweens on one
property drew one keyframe lane but pushed the automation lane down by two,
spilling into the next track; one tween on two properties did the inverse and
drew it over a diamond lane, stealing its pointer events. It now reads the same
`laneCounts` map the reserved height and the drawn lanes use.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(studio): automate a parameter without reloading the preview

The write path and the volume half of the panel surface.

**A commit that persists without reloading.** For attributes the runtime applies
to the live graph itself — an FX chain, its automation — a reload would only
interrupt playback to reach the state the preview already has. `skipRefresh` and
`refreshAfter` were already independent options; this exposes the combination
that skips the reload but still re-reads the selection.

Both halves are needed, and they were fighting each other. Without the reload,
audio no longer chops on an edit. Without the resync, the panel keeps reading the
selection snapshot it was built with, so a second edit computes from a pre-edit
value and appears to do nothing — deleting one effect made every later delete a
no-op. `handleDomAttributeLiveCommit` is untouched and still used for knob
dragging, where a per-move re-render is exactly what you do not want.

**Volume.** An automated track's slider is disabled, since a level set there
would be overwritten by the envelope on the next tick, and the toggle beside it
adds or deletes the lane. Adding seeds it with a single point at the level the
slider already shows, so automating a track never changes how loud it is.

**One shared reader** for both panel sections, which is what surfaced that
resolving against an absent chain would have deleted every FX lane the moment
someone automated a volume: the volume section does not parse the chain, so
"no chain" now means "do not resolve" rather than "drop what cannot be resolved".

The toggle itself lives with the FX controls it is shared with, and says
`Automated` / `Automate` through the studio's own Tooltip rather than a native
browser hover.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

* fix(studio): stop the last two automation writes reloading the preview

The quiet commit added here was only used by the FX group. Two writers still went
through the refreshing one, so they reloaded the preview and restarted every
playing track — the exact chop the live write during a drag exists to avoid:

- releasing a dragged breakpoint, so the audio hitched at the end of every point
  you moved;
- clicking the volume toggle, while the same click on an effect parameter was
  already silent.

Both are quiet now: still persisted, still resyncing the selection so a following
edit computes from the value just written.

Also fixes the seeded volume. `Number(dataAttributes.volume ?? "1")` is 0 for an
attribute that is present but empty, so automating such a track started its lane
at silence while the engine read the same empty value as unity.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(studio): automate and un-automate each effect parameter

The per-parameter surface in the FX panel.

An automated parameter's control is disabled — a value typed there would be
overwritten by the envelope on the next tick, so the lane is the value now — and
the toggle beside it adds or deletes that parameter's lane. Adding seeds the lane
with a single point at the value the control already holds, so switching to an
envelope never changes the sound, only where the value comes from.

Parameters no envelope can drive have no toggle at all: the worklet-backed
dynamics expose no AudioParams, a WaveShaper's curve and a convolution impulse
are rebuilt wholesale rather than scheduled. Neither does a chain node with no
id, since a lane addresses nodes by id — so adding an effect now mints one.

Carve moves onto the same non-reloading write, and decodes its source in an
`OfflineAudioContext`: opening a second output device mid-playback makes the
running track glitch while the hardware is reconfigured. Turning carve off now
also drops the filters it generated, which otherwise kept dipping the bed with
nothing in the panel to explain it.

`AudioFxGroup` moves into its own module — PropertyPanelFlat was at its size
budget — which also gave the panel's write behaviour somewhere to be tested: what
it writes, seeded at the current value, preserving the lanes it is not touching,
and clearing the attribute when the last one goes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

* feat(studio): only offer voiceover carve when there is a voice to carve against

Carve is a relationship between two tracks — it analyses another track's voice
and dips this bed where that voice sits. In a composition with a single audio
track there is nothing to listen to, so the block offered an empty source picker
and an Analyse button that could never do anything.

It is now shown only when the composition holds another audio track, and still
shown when carve is already configured: hiding a live setting because its voice
track was removed would leave the bed being dipped from out of sight.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* test(studio): cover carve visibility through the real element

The panel derives carve's source list from the selected element's document, so
a selection with no element has no sources — which the new visibility rule
correctly reads as 'nothing to carve against'. The suite mounted exactly that,
so it was asserting on a hidden block.

Selections now carry a real <audio> with a sibling track, and the two cases the
rule exists for are pinned directly.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(studio): keep FX panel writes from clobbering each other

Three writes in the audio panel each read the source file, mutate one
attribute and write it back. Fired without ordering they read the same
content and the last one lands, dropping the others.

- Deleting an effect left its automation lanes in the attribute. Ids are
  minted lowest-free, so the next effect added took the same id and
  inherited the dead envelope: disabled and "Automated" without the
  author ever automating it, and baked into the render.
- Switching carve off wrote the chain (dropping the filters it generated)
  and the carve settings at once, so either the filters stayed with no
  carve to explain them or the settings survived with no filters.
- The three carve dials committed per input event, patching the source
  and resyncing the selection dozens of times per drag. They now preview
  live and persist on release, like the FX knobs already do.

Volume automation reads through the quiet commit too, so removing a lane
resyncs the panel instead of leaving the slider disabled.

* feat(engine): render audio FX in an OfflineAudioContext

Reads `data-fx-chain` off an audio element and runs the chain over the trimmed
WAV before volume automation is baked in — effects should see the raw signal,
and the envelope belongs on their output.

The processing happens in an OfflineAudioContext inside the headless browser
the engine already drives, running the same graph builders the studio previews
with. That is the point of the approach: one implementation per effect, so the
render agreeing with the preview is a property of the architecture rather than
a tolerance to police. Reimplementing each effect as an FFmpeg filter would
mean two implementations to keep in step, and for the dynamics processors and
modulated delays there is no filter that behaves the same way.

`build:audio-fx-runtime` bundles the graph builders into an injectable IIFE,
following the same pattern as the existing runtime artifacts, so the browser
runs exactly the code the studio does.

The page loads from a file:// URL rather than about:blank because AudioWorklet
is only exposed in a secure context — the compressor, limiter, gate and
bitcrush processors would otherwise fail to register with an opaque error.
file:// qualifies and needs no listening socket.

The chain is serialised into the attribute the way colour grading carries its
config, so there is no side-car file to resolve or lose.

An FX failure is fatal for the whole mix rather than a per-track soft failure.
Every other audio failure mode degrades gracefully — the track drops, siblings
continue — but substituting the dry signal for a processed one ships a render
that sounds plausible and is not what the author set up. Since the per-element
work races under Promise.all, an internal AbortController chained off the
caller's signal aborts in-flight siblings before workDir is removed.

* feat(core): voiceover carve analysis

Finds the bands a voice occupies so a music bed can be dipped there, letting
the voice sit in front without ducking the whole track.

Carve is a relationship between two tracks rather than an effect on one, so it
stays out of the FX chain. What it emits is an ordinary chain of peaking
filters, so a carve composes with whatever else is on the track and needs no
separate rendering path.

Selection is weighted toward intelligibility rather than raw voice energy.
Ranking purely by power lands on the fundamental almost every time, because
that is where a voice is loudest — but the masking that actually hurts a
voiceover happens higher up, and dipping 160 Hz mostly just thins the bed. The
bias is a control, not a constant: at 0 it follows raw energy, at 1 it weights
toward 1-3 kHz.

Ranking happens in dB, which matters more than it looks. Speech spreads 20-30 dB
across these bands — it falls off roughly 6 dB per octave above the fundamental
— so a weighting has to be on that scale to move anything at all. A
multiplicative weight of `1 - bias + bias * shaped` is bounded below by
`1 - bias`, capping its influence at 10*log10(1/(1 - bias)): 5.2 dB at the 0.7
default, 3 dB at 0.5. That is no influence against a real voice — every bias
short of ~0.95 would rank exactly like bias 0 and carve the fundamental, the
outcome the bias exists to prevent, while looking decisive against a fixture
whose bands sit 2 dB apart. So the bias is a dB penalty, zero at 2 kHz and worth
up to 30 dB at full strength, and relative cut depths come from a dB difference
rather than a ratio of weighted linear powers.

The bias reweights ranking without overriding the spectrum — a band the voice
has no energy in is not worth carving, and scores -Infinity rather than
competing — so a strongly low-pitched voice can still select low at full bias.
What the tests hold is that biasing never selects lower than the unbiased
ranking, that the DEFAULT bias reaches the presence region on a voice with a
realistic tilt, and that bias 0 still follows raw power exactly.

Includes a radix-2 FFT rather than a dependency; one Welch-style averaged
spectrum over third-octave bands does not justify pulling in a DSP library.

* fix(engine): keep the FX render 16-bit, stereo, and correctly sized

Three defects in the offline FX path, none of which any test could see.

**Float output silently disabled sample-accurate volume automation.** The writer
emitted 32-bit IEEE float; the very next mixer step bakes the volume envelope
into the samples and accepts only 16-bit PCM, returning null otherwise. So
enabling any effect downgraded that track to the ffmpeg expression path — capped
at 32 straight segments, quantising a curved envelope, and on a dense one falling
back to base volume. It now writes 16-bit PCM, clamped rather than wrapped so a
limiter at 0 dB or a resonant filter cannot turn overshoot into a click. A test
asserts the baker accepts the writer's own output and actually fades it.

**Everything was folded to mono.** `prepareAudioTrack` goes out of its way to
emit stereo — its pan filter exists to dodge ffmpeg's 3 dB mono-to-stereo
rematrix — and this folded it, then wrote one channel. So adding a single peaking
EQ collapsed a bed's width and cost ~3 dB in the render, while preview stayed
stereo. Channels now travel as one plane each, through an OfflineAudioContext of
the same width, and come back interleaved.

**Small results decoded the wrong length.** `new Float32Array(buf.buffer)`
discards byteOffset and byteLength, and Node pools small allocations: a 400-byte
payload sits at offset 8 inside an 8 KiB pool, so a clip under ~1024 samples
decoded as 2048 samples of unrelated memory — and the empty-result guard could
not see it. The reader has the mirror-image fix: a float data chunk on an odd
boundary (ffmpeg's pcm_f32le writes fmt(18) + fact, landing `data` at 58) now
copies instead of throwing RangeError on an unaligned view.

The tail limitation is now stated rather than mis-stated: the context is exactly
as long as the input, so a reverb or delay still ringing is cut there. The old
comment claimed the opposite. How far a tail may run past a clip's end changes
the clip's length in the mix, so it is a product decision, not one to make here.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(producer): report an FX render failure as an audio error

`processCompositionAudio` reports per-track failures in its result, but an FX
failure it cannot degrade past — a browser that will not launch, a chain that
will not build — rejects instead. `runAudioStage` had no try, so that rejection
escaped to the orchestrator as an unclassified pipeline exception, losing the
stage/owner/retryable classification this stage exists to attach, and skipping
its abort check on the way out.

It now lands in `audioError` alongside every other cause, while an abort still
keeps its own shape rather than being reported as an audio problem.

Not done here: committing the generated `audio-fx-runtime-inline.ts` so a fresh
clone typechecks packages/engine without building first. The bundle is built from
the stub, and the stub changes three times across this stack — so the artifact
differs per branch and would conflict on every restack. Its model,
position-edits-render-inline.ts, is committed only because it is stable. Building
before testing is this monorepo's existing contract (studio's tests need core's
dist too), so the gap is not specific to audio FX and is better closed by a build
ordering gate than by committing a per-branch artifact.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* test(engine): skip the browser FX render cases when there is no browser

CI's `Test` job was red on this PR with four failures, all the same cause:

  Failed to launch the browser process: spawn
  /home/runner/.cache/hyperframes/chrome/chrome-headless-shell

The job installs ffmpeg and no browser, deliberately — every other suite
that needs an external binary already guards on it
(`describe.skipIf(!HAS_FFMPEG)`). These cases were the only ones assuming
a Chrome, so they failed on an absent dependency rather than on anything
about the code.

Guards on `resolveHeadlessShellPath()` — the same resolver
`acquireBrowser` launches through, so the check cannot drift from the
thing it guards the way a hard-coded cache path would. A configured path
that does not exist throws; that is caught and read as "cannot run here".

Checked both directions rather than just the green one: with a browser all
11 cases run and pass, and with `HYPERFRAMES_BROWSER_PATH` pointed at a
missing binary exactly 3 skip and the other 8 still run. A guard that
silently skipped everything would have looked identical in CI.

They keep their value where it exists — every developer machine, and any
job that has run `hyperframes browser ensure`.

Not touched: the CodeQL failure on this PR is a run from 2026-08-07, five
days and several force-pushes stale. None of the 17 open repo alerts are
in files this PR changes; it re-runs on this push.

* chore(engine): suppress the temp-file alert with the reason it is safe

CodeQL flags `writeWav`'s `writeFileSync` as js/insecure-temporary-file
(high) — the one new alert on #3021, and the reason its CodeQL check is
red.

It is a false positive, and the comment says why rather than just silencing
it: `path` is always inside a directory made by `mkdtempSync`, never a
name assembled directly under `tmpdir()`. Both callers are covered — the
browser host page writes into `mkdtempSync(join(tmpdir(), "hf-fx-host-"))`,
and the render output goes to the producer work dir, itself
`mkdtempSync(join(tempRoot, "producer-project-"))`. mkdtemp picks the
random suffix and creates the directory 0700 in one syscall, so the
predictable filename inside it cannot be pre-created or symlinked by
another user, which is the attack the rule is about. The analyzer sees the
dataflow reach `tmpdir()` and not the mkdtemp in between.

Suppressed inline rather than dismissed in the UI, so the justification
lives next to the code and the rule stays live for anything added later in
this file. Matches the repo's existing convention — `planV2.ts:222`
carries an `lgtm[js/insecure-temporary-file]` for a different reason on
the same rule.

Correcting myself: I first reported this alert as not real, having
intersected the PR's files against the default-branch alert list, which
does not contain PR-ref alerts. Querying ?ref=refs/pull/3021/merge returns
it straight away.

* test(engine): probe ffmpeg and Chrome instead of assuming them

Two failures on #3021's Test job, both about the environment rather than
the code under test.

**Bare `ffmpeg` is not on PATH in CI.** The 16-bit fixture shelled out to
`execFileSync("ffmpeg", ...)` and died with ENOENT. The job does provide
ffmpeg, through `prepare-ffmpeg-bin`, which is what `getFfmpegBinary()`
resolves — every other ffmpeg-dependent suite in this package already goes
through it. Now this one does too, and the case is `skipIf(!HAS_FFMPEG)`
so a contributor without ffmpeg skips rather than fails.

**The browser guard trusted the wrong thing.** It asked
`resolveHeadlessShellPath()` and treated a returned path as "a browser is
here". CI's cache holds a chrome-headless-shell that resolves and then
fails to spawn — a partial download is indistinguishable from a working
one by `existsSync`, which is all that resolver checks. So the three
browser cases ran anyway and failed on the launch.

It now runs `--version` and requires exit 0, which is the same probe the
ffmpeg suites use: ask the binary, do not infer from the filesystem.

Checked both directions rather than just the green one. With a working
browser all 11 cases run and pass; with `HYPERFRAMES_BROWSER_PATH` pointed
at a binary that exits non-zero — CI's exact situation — exactly 3 skip
and the other 8 still run. A guard that quietly skipped everything would
have looked identical on the CI summary.

* feat(core): register the audio-fx-rack canary at 0%

Lands the rollout switch dark, per the registry's own procedure: "Start at
percentage: 0 and merge that — a canary at 0 is dead code you can land
safely and ramp without a code review."

Declared at the bottom of the stack so every branch above can read it. The
gate itself goes in at wa-4-fx-panel, where the rack first appears.

Scope is deliberate and stated in the description: it gates the AUTHORING
surface only. A composition that already carries `data-fx-chain` still
plays and renders it. A canary should stage who can REACH a feature, not
make an attribute somebody already wrote silently inert — an agent that
writes a chain through the skill would otherwise produce a file whose audio
processing vanishes with no error.

* feat(studio): audio FX panel generated from the registry

Controls for the whole chain: add, remove, reorder, bypass, and every knob each
effect declares.

Nothing in the panel knows what a compressor is. The registry supplies each
parameter's range, step, unit and scale and the panel renders what it finds, so
adding an effect or a knob upstream needs no change here, and the panel cannot
offer a value the renderer would reject — a typed-in figure is clamped into the
declared range on the way through.

Frequency and time controls span three or four decades, so those declare a log
scale and the slider maps exponentially; a linear slider would spend most of
its travel somewhere useless.

Reorder is a first-class control because chain order changes the sound: a
reverb before a compressor is not the same as after.

Carve gets its own block rather than an entry in the add menu, with a picker
for the voice track to listen to. It processes this track based on another one,
which is how a sidechain control works — it lives on the track that changes,
and names the source.

* feat(studio): show the Audio FX section on audio tracks

Adds `audioFx` to the editing-affordances contract and renders the FX panel in
the inspector when an `<audio>` element is selected.

The section is audio-only. A `<video>` carries its sound on a separate
`<audio>` element, so an FX chain on the video would have nothing to process.

Chain and carve settings are written straight back onto the element as
serialised attributes, the way colour grading carries its config, so
persistence is an ordinary attribute write and needs no new server route. A
chain that cannot be parsed renders as empty rather than breaking the panel,
and the attribute is left untouched until the user changes something.

The collapsed group summarises what is on the track ("2 effects + carve") so
the state is visible without expanding it.

Wired into PropertyPanelFlat rather than PropertyPanel: STUDIO_FLAT_INSPECTOR_ENABLED
defaults to true, so the flat inspector is what actually renders.

* refactor(studio): lift audioFxSummary out of PropertyPanelFlat

`PropertyPanelFlat.tsx` is 612 lines here against the repo's 600-line cap,
so the required File size check is red — the sole reason this PR is
blocked. The review says as much: "mechanical fix (~5 min), not a design
problem. Code itself is LGTM."

Moves `audioFxSummary` to `audioFxSummary.ts`, the same file a later
branch creates for it. Deliberately the smallest cut that clears the cap
rather than the whole `AudioFxGroup` extraction: every later commit in the
stack edits AudioFxGroup, so moving it here would collide with each of
them, while almost nothing touches this function.

595 lines.

* feat(core,studio): hear the FX chain in preview, and run the carve analysis

Splices an element's FX chain into the playback graph so preview stops being
silent about effects, and wires the carve button that was previously inert.

The chain goes between the decoded source and its gain stage: effects see the
raw signal and volume automation rides on their output, matching the order the
offline render uses. Since preview and render call the same graph builders,
what is heard while scrubbing is what gets written.

The splice lives in the transport rather than on the `<audio>` element. The
transport plays each track from a decoded AudioBuffer and mutes the element to
avoid doubling, so capturing the element with createMediaElementSource would
have processed a stream nothing is listening to — it looked like it worked
because the call succeeded, and the audio was unchanged.

A chain that cannot be built plays dry rather than silencing the track, which
is the right failure in preview: the author keeps working and hears the source.
The render still refuses, because shipping the dry signal there would be wrong.

Carve now analyses for real: it decodes the chosen voice track, ranks its bands
and writes the resulting peaking filters onto this track. Generated nodes are
tagged `fromCarve`, so re-running replaces the previous carve instead of
stacking another set on top of hand-added effects.

Known limitation: the graph is built when a source is scheduled, so a knob
turned mid-playback takes effect on the next play or seek rather than
immediately. Live re-parameterisation needs the transport to hold the handle
and forward updates.

* fix(studio,core): stop parameter drags from restarting playback

Dragging a knob wrote the chain through the persisting attribute path on every
input event. That path refreshes the preview, which reloads the composition and
reschedules audio — so a single drag reloaded dozens of times and playback
stuttered the whole way.

Drags now go through `onSetAttributeLive`, the same path colour grading uses for
scrubs: it coalesces undo entries and sets `skipRefresh`, so no reload happens.
The persisting write fires once, when the gesture ends — pointer-up or blur for
a slider, Enter or blur for a typed value. A select commits immediately since
there is no drag to wait for.

While dragging, the control is driven from local state. Waiting for the value to
round-trip through the element attribute made the knob lag behind the pointer.

For the change to be audible without a reload, the graph now follows the
attribute: the chain installed by the transport observes the element and
re-parameterises itself in place, so a value change lands on the next
128-sample quantum. A shape change (effect added, bypassed, pole count) cannot
be patched into a running graph, so it still waits for the next schedule rather
than cutting the audio mid-play.

The regression test drags a slider through several values and asserts the
persisting handler is untouched until release.

* feat(studio): put the audio FX rack behind its canary

Gates the rack on `isCanaryEnabled("audio-fx-rack")`, which is registered
at 0% — so the whole 47-PR stack can land without showing anyone a feature
that has not been measured yet.

The gate sits on the AUTHORING surface and nowhere else. The runtime and
the render still honour a `data-fx-chain` already on an element, so a
composition written through the skill or by `carve.mjs` keeps its
processing rather than going silently dry for anyone outside the cohort. A
canary should stage who can REACH a feature, not make an attribute somebody
already wrote stop working with no error.

Gated at the panel rather than in `resolveEditingSections`: the affordance
resolver is a pure function in core describing what an element CAN support,
and rollout state is not a property of an `<audio>` tag.

Pinned the 0% with a test, and checked it fails at 25 — a ramp should have
to break something that says "this ships dark" out loud.

One gap, stated rather than papered over: the gate itself has no unit test.
I wrote one and deleted it, because `PropertyPanel.test.tsx`'s harness
never renders the Audio FX group for its audio fixture even with the gate
removed — so the test passed for the wrong reason in the off case and could
not pass at all in the on case. A test that cannot fail for the right
reason is worse than none. Verifying the gate needs the panel harness to
mount that section first, which is its own change.

* fix(core): register FX worklets before building nodes that need them

An AudioWorkletNode cannot be constructed before its processor is registered —
it throws, and the surrounding chain is lost with it. `attachElementFxChain`
built the chain first and only then called `ensureAudioFxWorklets`, so every
worklet-backed effect (compressor, limiter, gate, bitcrush) threw on
construction and the track fell back to dry. Instrumenting the preview showed
`hf-compressor: InvalidStateError` with addModule never called at all.

When the module has not landed yet the track now plays dry and the graph is
swapped in once registration resolves, so the effect arrives a moment late
instead of never.

Registration is also tracked per context rather than in one module-level
promise. A processor registered on one AudioContext does not exist on another,
so the shared promise made every context after the first believe it was ready
when it was not — the studio's transport owns its own context, which is exactly
that case.

With the worklets actually running, the compressor's per-sample log10 and pow
became real audio-thread work. Samples below the knee have a gain of exactly
unity and need neither, so the envelope is now compared in the linear domain
and the transcendentals only run for samples that are actually being
compressed.

* refactor(studio): split the FX node row out of FxSection

Clears the health findings the FX stack left behind: the chain-node render
callback was a 70-line closure over half of FxSection's state, and the two
reorder arrows were the same button written twice.

Also drops two exports with no consumers, and registers the audio FX runtime
stub as an entry point — it is bundled by file path, so nothing imports it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(core): automation envelope model for audio tracks

Adds the data model behind Ableton-style automation lanes: breakpoint
envelopes over track volume or one knob of one effect in the track's FX
chain, stored on the element as `data-automation`.

Times are clip-local, so an envelope travels with the clip when it moves —
the clip-envelope model rather than arrangement automation.

`sampleAutomationLane` is the single interpolator. The lane drawing, the
preview scheduler and the render bake all call it, so the picture and the
sound cannot disagree about the curve. Log-scaled parameters interpolate in
log space, matching what their own knob already promises.

FX nodes gain a stable `id`, minted by count rather than randomly so the
document is the same on every machine. Lanes address nodes by id, so
reordering a chain never re-points a lane at a different effect, and a lane
whose effect was deleted is dropped rather than left to reattach.

Also warns when a track carries both a volume lane and a GSAP volume tween,
since only the lane is heard and the tween silently does nothing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(studio): lift the audio FX group out of PropertyPanelFlat

`PropertyPanelFlat.tsx` was 672 lines against the repo's 600-line cap, so
the required File size check was red — the sole reason #3014 and #3022 are
blocked. Both reviews say the same thing: "mechanical fix, not a design
problem. Code itself is LGTM."

Moves `AudioFxGroup` and `audioFxSummary` into
`propertyPanelAudioFxGroup.tsx`, which is where a later branch puts them
anyway — done here so the file is under the cap from the point it first
crosses it, rather than ten branches later.

533 lines now. The four audio imports it no longer needs go with it.

Not fixed here: three `FxSection carve` tests fail on this branch with
"Cannot read properties of undefined (reading 'toFixed')". Confirmed
pre-existing by stashing this change and re-running — that is the separate
`Test` failure the review also flags.

* feat(core): expose the AudioParams behind automatable FX knobs

Marks the knobs an automation lane can drive and has each graph builder hand
back the AudioParam behind them, so a scheduler can write to a running effect
without knowing what the effect is.

A knob is not always one AudioParam. A wet/dry mix is two gains moving in
opposition, and a knob in milliseconds drives a delay time in seconds, so
each target carries the mapping out of the knob's own declared unit.

What stays unautomatable is stated where it is decided: a WaveShaper curve, a
convolution impulse and a one-pole filter's coefficients are all rebuilt
wholesale rather than scheduled, and the four worklet effects take values by
postMessage rather than through AudioParams.

The registry flag is written by hand, so a test builds every effect and
checks the exposure both ways — nothing flagged is missing, nothing exposed
is unflagged. A flag that lied would offer a lane that silently did nothing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(core): play automation envelopes in preview

Schedules each lane onto the AudioParams behind its knob using native ramps
and value curves. Nothing evaluates the envelope per frame: it is handed to
the audio thread once, so it stays sample-accurate however busy the main
thread is, and the offline render will schedule it the same way.

Timing comes from the transport, so an envelope survives seeking into the
middle of a clip, a clip that has not started yet, and a playback rate that
compresses clip seconds into context seconds.

A straight line is only scheduled as a ramp when nothing bends it — no
curvature, a linear parameter scale, and no unit mapping. Log-scaled
parameters and mapped ones are sampled instead, since a delay knob in
milliseconds and a wet/dry pair moving in opposition are not linear in the
parameter they drive.

Lanes with nowhere to write are skipped rather than reported: a one-pole
filter exposes no frequency param, and the worklet effects expose none at
all. Editing an envelope mid-playback re-aims it at the live playhead rather
than restarting the track.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(core): make the volume lane audible in preview

The envelope was scheduled onto the transport's gain AudioParam, but the
runtime rewrites that gain every tick from `data-volume` and the GSAP-seeked
value — so it was erased within a frame. Volume automation was correct in the
render and inaudible while previewing.

The lane now feeds the per-tick path where the probed volume keyframes already
sit, checked ahead of them so the two cannot fight, and the transport no
longer schedules volume at all: one mechanism instead of two racing.

The cost is honest — in preview the level steps per tick rather than per
sample, exactly as the existing keyframe path does. The render still bakes it
into the PCM sample-accurately, and FX parameters are still scheduled on their
own AudioParams, since nothing rewrites those.

Parsed lanes are cached by attribute text: the runtime asks once per tick per
track, and parsing there would run the JSON parser 60 times a second for a
value that only changes on an edit.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(engine): bake automation envelopes into the render

The offline render schedules FX lanes with the same scheduler preview uses,
inside the OfflineAudioContext that already runs the same graph builders. The
input WAV is the clip's own audio from its first sample, so clip-local time
is offline time and the envelope needs no offset.

Volume lanes take the existing PCM bake rather than a second mechanism: the
lane is converted to keyframes, so a straight fade stays two of them and only
a bent segment is sampled — the baker interpolates linearly and would
otherwise quietly straighten the curve. A volume lane supersedes keyframes
probed from the timeline, which `lint` already warns about.

A browser test sweeps a lowpass from below a 2 kHz tone to well above it and
measures both ends. Parsing the envelope is not the same as scheduling it,
and only running the real thing tells the two apart.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(core): apply chain edits to the running graph

A structural edit — an effect added, removed, bypassed, or a filter's pole
count switched — was dropped. `buildFxChain`'s update reports false when the
change is not merely new values, and the attribute observer ignored that, so
the edit only took hold when the persisting write reloaded the composition.
That reload restarted every playing track, which is what was heard as the
audio chopping.

The graph is now swapped in place: the old effects are detached, the new ones
built and connected between the same source and gain, and any lanes
re-scheduled onto the new nodes. The source node is never touched, so playback
does not restart.

A track with no chain is watched too, rather than wired through and forgotten,
so adding its first effect is heard the same way. That means the function
always returns a disposer instead of null for the empty case.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(studio): drop the FX panel's dead __testables export

Fallow audit flagged it — no test imports the module.

* fix(core,studio): clear the remaining Fallow audit findings on the FX panel

- Split FxSection's per-node row into FxNodeRow + FxNodeControls so the
  CRAP score (31.6, threshold 30) splits across two smaller units instead
  of moving wholesale with one extraction.
- Dedupe the repeated "open the add menu, read its items" block in
  propertyPanelFxSection.test.tsx into openAddMenuItems().
- Merge build-audio-fx-runtime.ts and build-position-edits-render.ts into
  one build-inline-artifact.ts, config-selected by CLI arg — the two
  scripts were a byte-for-byte clone save for names.
- Exempt canary.test.ts's rawFnv (a deliberate independent
  reimplementation used to cross-check canaryBucket, per its own
  docstring) and the property-panel test files' shared renderInto/mount
  scaffolding (pre-existing across 9 files, 2 outside this stack) in
  .fallowrc.jsonc, consistent with this file's existing exemptions for
  the same class of intentional/pre-existing duplication.

* fix(ci): allowlist the build-script consolidation in the no-main-deletions guard

build-audio-fx-runtime.ts and build-position-edits-render.ts were merged into
build-inline-artifact.ts to kill a fallow duplication finding; the deletion
guard flagged that as an accidental loss since main still has both originals.

* fix(core): dedupe the wet/dry mix math between delayFeedback and chorusLfo

Both effect builders set wet.gain to the mix and dry.gain to its complement
in identical two-line blocks; fallow kept re-flagging it as a 10-line clone
on every unrelated change. Extracted setWetDryMix.

* fix(core): remove the build-audio-fx-runtime.ts stray resurrected by a main merge

An earlier merge with main brought this deleted file back (git's merge/delete
handling on an unchanged-on-one-side file); package.json already points at
build-inline-artifact.ts, so it sat unreachable and duplicating that file's
config, both of which fallow flagged.

* fix(studio): pull TimelineLanes under the 600-line cap

TimelineLanes.tsx hit 620 lines. Extracted the three per-clip pointer
gestures (resize-start, pointer-down move-arm, click/razor-split) into
createClipGestureHandlers — one factory call per rendered clip instead of
~120 lines of inline handler bodies in the render loop. 529 lines now.

* fix(studio): split the extracted pointerdown handler under the CRAP threshold

Moving the ~120-line gesture logic into timelineClipGestureHandlers.ts
concentrated it into two functions fallow flagged (onPointerDown at CRAP
63.6, onResizeStart at 31.6). Split the decision logic (which gesture a
pointerdown implies) into a pure resolvePointerDownAction, then split
its own intent-blocking check into isIntentBlocked. onResizeStart's guard
moved into canStartResize. Every function now scores under 30.

* fix(studio): drop the unused DomEditSelection import in PropertyPanelFlat

CI caught it on PR #3026 (wa-12-panel-params); a later refactor in the
stack removed the last use of the type here without removing the import.

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

packages/studio/src/components/editor/PropertyPanelFlat.tsx

@@ -16,6 +16,7 @@ import { FlatMotionSection } from "./propertyPanelFlatMotionSection";
 import { isCanaryEnabled } from "../../telemetry/canary";
 import { audioFxSummary } from "./audioFxSummary";
 import { AudioFxGroup } from "./propertyPanelAudioFxGroup";
+import { useVolumeAutomation } from "./useVolumeAutomation";
 import { FlatMediaSection } from "./propertyPanelFlatMediaSection";
 import { deriveElementTiming } from "./propertyPanelFlatTimingDerivation";
 import { createGsapLivePreview } from "./gsapLivePreview";
@@ -67,6 +68,7 @@ export function PropertyPanelFlat({
   onSetAttribute,
   onSetAttributes,
   onSetAttributeLive,
+  onSetAttributeQuiet,
   onApplyColorGradingScope,
   onSetHtmlAttribute,
   onRemoveBackground,
@@ -255,6 +257,8 @@ export function PropertyPanelFlat({
   const showMotionEffects = gsapEffectHandlers !== null;
   const showMotionGroup = showMotionTiming || showMotionEffects;
 
+  const volumeAutomation = useVolumeAutomation(element, onSetAttributeQuiet ?? onSetAttributeLive);
+
   const groups: FlatGroupDescriptor[] = [];
   if (isTextEditable) {
     groups.push({
@@ -434,7 +438,7 @@ export function PropertyPanelFlat({
       content: (
         <AudioFxGroup
           element={element}
-          onSetAttribute={onSetAttribute}
+          onSetAttributeQuiet={onSetAttributeQuiet ?? onSetAttributeLive}
           onSetAttributeLive={onSetAttributeLive}
         />
       ),
@@ -454,6 +458,7 @@ export function PropertyPanelFlat({
           onSetAttribute={onSetAttribute}
           onSetHtmlAttribute={onSetHtmlAttribute}
           onRemoveBackground={onRemoveBackground}
+          {...volumeAutomation}
         />
       ),
     });

packages/studio/src/components/editor/propertyPanelAudioFxGroup.test.tsx

@@ -0,0 +1,358 @@
+// @vitest-environment happy-dom
+import { act } from "react";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { createRoot } from "react-dom/client";
+import { AudioFxGroup } from "./propertyPanelAudioFxGroup.js";
+import type { DomEditSelection } from "./domEditingTypes";
+
+(globalThis as unknown as { IS_REACT_ACT_ENVIRONMENT: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
+
+const CHAIN = JSON.stringify({
+  version: 1,
+  nodes: [{ type: "lowpass", id: "n1", params: { frequency: 900, q: 1.2, poles: "2" } }],
+});
+
+// Each mount appends its tracks to the document; without clearing, a later
+// "only one audio track" case would still find the previous test's sibling.
+afterEach(() => {
+  document.body.innerHTML = "";
+});
+
+/**
+ * A selected `<audio>` with a sibling track, so carve — which needs another
+ * track to listen to — is offered. Pass `alone` for a composition holding just
+ * this one.
+ */
+function audioSelection(dataAttributes: Record<string, string>, alone = false): DomEditSelection {
+  const bed = document.createElement("audio");
+  bed.id = "bed";
+  document.body.append(bed);
+  if (!alone) {
+    const voice = document.createElement("audio");
+    voice.id = "vo";
+    document.body.append(voice);
+  }
+  return { dataAttributes, id: "bed", element: bed } as unknown as DomEditSelection;
+}
+
+function mount(dataAttributes: Record<string, string>, alone = false) {
+  // Every write is quiet: persisted without the preview reload that would
+  // restart every playing track, but with a selection resync so the panel sees
+  // what it just wrote.
+  const onSetAttributeQuiet = vi.fn();
+  const onSetAttributeLive = vi.fn();
+  const host = document.createElement("div");
+  document.body.append(host);
+  const selection = audioSelection(dataAttributes, alone);
+  act(() => {
+    createRoot(host).render(
+      <AudioFxGroup
+        element={selection}
+        onSetAttributeQuiet={onSetAttributeQuiet}
+        onSetAttributeLive={onSetAttributeLive}
+      />,
+    );
+  });
+  return { host, onSetAttributeQuiet, onSetAttributeLive };
+}
+
+const rowFor = (host: HTMLElement, label: string): HTMLElement | null => {
+  for (const row of Array.from(host.querySelectorAll<HTMLElement>(".hf-fx-row"))) {
+    if (row.querySelector(".hf-fx-label")?.textContent === label) return row;
+  }
+  return null;
+};
+
+const parseWrite = (call: unknown[]) => JSON.parse(String(call[1]));
+
+describe("AudioFxGroup automation", () => {
+  it("renders the chain's parameters", () => {
+    const { host } = mount({ "fx-chain": CHAIN });
+    expect(rowFor(host, "Cutoff")).toBeTruthy();
+    expect(rowFor(host, "Q")).toBeTruthy();
+  });
+
+  it("seeds a new lane at the value the control already holds", () => {
+    // Switching to an envelope must not change the sound — only where the value
+    // comes from. The chain has frequency at 900, not the registry default.
+    const { host, onSetAttributeQuiet } = mount({ "fx-chain": CHAIN });
+    const button = rowFor(host, "Cutoff")!.querySelector(".hf-fx-automate") as HTMLButtonElement;
+    act(() => button.click());
+    const [attr, value] = onSetAttributeQuiet.mock.calls[0];
+    expect(attr).toBe("data-automation");
+    expect(JSON.parse(String(value))).toEqual({
+      version: 1,
+      lanes: [{ target: "fx.n1.frequency", points: [{ t: 0, v: 900 }] }],
+    });
+  });
+
+  it("keeps lanes it is not touching when adding one", () => {
+    const { host, onSetAttributeQuiet } = mount({
+      "fx-chain": CHAIN,
+      automation: JSON.stringify({
+        version: 1,
+        lanes: [{ target: "volume", points: [{ t: 0, v: 0.5 }] }],
+      }),
+    });
+    act(() => (rowFor(host, "Q")!.querySelector(".hf-fx-automate") as HTMLButtonElement).click());
+    expect(
+      parseWrite(onSetAttributeQuiet.mock.calls[0]).lanes.map((l: { target: string }) => l.target),
+    ).toEqual(["volume", "fx.n1.q"]);
+  });
+
+  it("disables a control the timeline already drives", () => {
+    const { host } = mount({
+      "fx-chain": CHAIN,
+      automation: JSON.stringify({
+        version: 1,
+        lanes: [{ target: "fx.n1.frequency", points: [{ t: 0, v: 400 }] }],
+      }),
+    });
+    const cutoff = rowFor(host, "Cutoff")!;
+    expect(cutoff.querySelector<HTMLInputElement>('input[type="range"]')?.disabled).toBe(true);
+    expect(cutoff.hasAttribute("data-automated")).toBe(true);
+    expect(
+      rowFor(host, "Q")!.querySelector<HTMLInputElement>('input[type="range"]')?.disabled,
+    ).toBe(false);
+  });
+
+  it("deletes just that lane, handing the value back to the control", () => {
+    const { host, onSetAttributeQuiet } = mount({
+      "fx-chain": CHAIN,
+      automation: JSON.stringify({
+        version: 1,
+        lanes: [
+          { target: "fx.n1.frequency", points: [{ t: 0, v: 400 }] },
+          { target: "volume", points: [{ t: 0, v: 0.5 }] },
+        ],
+      }),
+    });
+    act(() =>
+      (rowFor(host, "Cutoff")!.querySelector(".hf-fx-automate") as HTMLButtonElement).click(),
+    );
+    expect(
+      parseWrite(onSetAttributeQuiet.mock.calls[0]).lanes.map((l: { target: string }) => l.target),
+    ).toEqual(["volume"]);
+  });
+
+  it("clears the attribute when the last lane goes", () => {
+    const { host, onSetAttributeQuiet } = mount({
+      "fx-chain": CHAIN,
+      automation: JSON.stringify({
+        version: 1,
+        lanes: [{ target: "fx.n1.frequency", points: [{ t: 0, v: 400 }] }],
+      }),
+    });
+    act(() =>
+      (rowFor(host, "Cutoff")!.querySelector(".hf-fx-automate") as HTMLButtonElement).click(),
+    );
+    // Null rather than "": the live path removes an attribute it is given null for.
+    expect(onSetAttributeQuiet.mock.calls[0][1]).toBeNull();
+  });
+
+  it("ignores a lane for an effect that is no longer in the chain", () => {
+    const { host } = mount({
+      "fx-chain": CHAIN,
+      automation: JSON.stringify({
+        version: 1,
+        lanes: [{ target: "fx.gone.frequency", points: [{ t: 0, v: 400 }] }],
+      }),
+    });
+    // Nothing is automated, so every control stays live.
+    expect(
+      rowFor(host, "Cutoff")!.querySelector<HTMLInputElement>('input[type="range"]')?.disabled,
+    ).toBe(false);
+  });
+});
+
+describe("AudioFxGroup carve", () => {
+  const carvedChain = JSON.stringify({
+    version: 1,
+    nodes: [
+      { type: "peaking", id: "n1", fromCarve: true, params: { frequency: 900, gain: -6, q: 1.4 } },
+      { type: "lowpass", id: "n2", params: { frequency: 400, q: 0.9, poles: "2" } },
+    ],
+  });
+
+  const carveOn = JSON.stringify({
+    source: "vo",
+    maxCutDb: 6,
+    bands: 3,
+    q: 1.4,
+    intelligibilityBias: 0.7,
+  });
+
+  const carveToggle = (host: HTMLElement): HTMLButtonElement => {
+    const block = host.querySelector(".hf-fx-carve")!;
+    return block.querySelector(".hf-fx-bypass") as HTMLButtonElement;
+  };
+
+  it("removes the filters it generated when carve is switched off", async () => {
+    // Leaving them behind would keep dipping the bed with no carve to explain it.
+    const { host, onSetAttributeQuiet } = mount({
+      "fx-chain": carvedChain,
+      "fx-carve": carveOn,
+    });
+    await act(async () => {
+      carveToggle(host).click();
+    });
+    const chainWrite = onSetAttributeQuiet.mock.calls.find((c) => c[0] === "data-fx-chain");
+    expect(chainWrite).toBeTruthy();
+    const kept = JSON.parse(String(chainWrite![1])).nodes;
+    expect(kept.map((n: { type: string }) => n.type)).toEqual(["lowpass"]);
+    // And the carve settings themselves go — after the chain write, not
+    // alongside it: both are read-modify-writes of the same file, so fired
+    // together the later one reads pre-edit content and drops the earlier.
+    expect(onSetAttributeQuiet.mock.calls.map((c) => c[0])).toEqual([
+      "data-fx-chain",
+      "data-fx-carve",
+    ]);
+    expect(onSetAttributeQuiet.mock.calls.find((c) => c[0] === "data-fx-carve")?.[1]).toBeNull();
+  });
+
+  it("leaves a hand-built chain alone when carve is switched off", () => {
+    const handBuilt = JSON.stringify({
+      version: 1,
+      nodes: [{ type: "lowpass", id: "n1", params: { frequency: 400, q: 0.9, poles: "2" } }],
+    });
+    const { host, onSetAttributeQuiet } = mount({ "fx-chain": handBuilt, "fx-carve": carveOn });
+    act(() => carveToggle(host).click());
+    expect(onSetAttributeQuiet.mock.calls.some((c) => c[0] === "data-fx-chain")).toBe(false);
+  });
+
+  it("drags a carve dial live and persists once on release", () => {
+    // Without the split every pointermove patched the source file and resynced
+    // the selection, which is what makes the audio stutter mid-drag.
+    const { host, onSetAttributeQuiet, onSetAttributeLive } = mount({
+      "fx-chain": carvedChain,
+      "fx-carve": carveOn,
+    });
+    const dial = host.querySelector<HTMLInputElement>(".hf-fx-carve input[type=range]");
+    expect(dial).not.toBeNull();
+    act(() => {
+      // React's value tracker swallows a plain assignment, so go through the
+      // prototype setter the way the other panel tests do.
+      Object.getOwnPropertyDescriptor(HTMLInputElement.prototype, "value")?.set?.call(dial, "0.5");
+      dial?.dispatchEvent(new Event("input", { bubbles: true }));
+    });
+    expect(onSetAttributeLive.mock.calls.map((c) => c[0])).toEqual(["data-fx-carve"]);
+    expect(onSetAttributeQuiet.mock.calls.some((c) => c[0] === "data-fx-carve")).toBe(false);
+    act(() => dial?.dispatchEvent(new PointerEvent("pointerup", { bubbles: true })));
+    expect(onSetAttributeQuiet.mock.calls.some((c) => c[0] === "data-fx-carve")).toBe(true);
+  });
+
+  it("writes carve settings live, so enabling it does not reload the preview", () => {
+    const { host, onSetAttributeQuiet } = mount({ "fx-chain": carvedChain });
+    act(() => carveToggle(host).click());
+    const write = onSetAttributeQuiet.mock.calls.find((c) => c[0] === "data-fx-carve");
+    expect(write).toBeTruthy();
+    expect(JSON.parse(String(write![1])).bands).toBeGreaterThan(0);
+  });
+});
+
+describe("AudioFxGroup successive edits", () => {
+  const three = JSON.stringify({
+    version: 1,
+    nodes: [
+      { type: "peaking", id: "n1", params: { frequency: 900, gain: -6, q: 1.4 } },
+      { type: "lowpass", id: "n2", params: { frequency: 400, q: 0.9, poles: "2" } },
+      { type: "delay", id: "n3", params: { time: 250, feedback: 0.3, mix: 0.4 } },
+    ],
+  });
+
+  const removeButtons = (host: HTMLElement) =>
+    Array.from(host.querySelectorAll<HTMLButtonElement>(".hf-fx-remove"));
+
+  /**
+   * The panel computes each edit from the attribute it is holding. Written
+   * without a selection resync, the second delete worked from the pre-delete
+   * chain and wrote the same result — so after deleting one effect, no further
+   * delete did anything.
+   */
+  it("deletes a second effect after the first, not from a stale chain", () => {
+    const first = mount({ "fx-chain": three });
+    act(() => removeButtons(first.host)[0]!.click());
+    const afterFirst = JSON.parse(String(first.onSetAttributeQuiet.mock.calls[0][1]));
+    expect(afterFirst.nodes.map((n: { id: string }) => n.id)).toEqual(["n2", "n3"]);
+
+    // The resync hands the panel what it just wrote; the next delete starts there.
+    const second = mount({ "fx-chain": JSON.stringify(afterFirst) });
+    act(() => removeButtons(second.host)[0]!.click());
+    const afterSecond = JSON.parse(String(second.onSetAttributeQuiet.mock.calls[0][1]));
+    expect(afterSecond.nodes.map((n: { id: string }) => n.id)).toEqual(["n3"]);
+
+    const third = mount({ "fx-chain": JSON.stringify(afterSecond) });
+    act(() => removeButtons(third.host)[0]!.click());
+    // The last one leaves no chain at all.
+    expect(third.onSetAttributeQuiet.mock.calls[0][1]).toBeNull();
+  });
+
+  it("writes with the commit that resyncs the selection, not the silent one", () => {
+    // Both skip the preview reload; only this one re-reads the selection, which
+    // is what makes a following edit see the current value.
+    const { host, onSetAttributeQuiet } = mount({ "fx-chain": three });
+    act(() => removeButtons(host)[0]!.click());
+    expect(onSetAttributeQuiet).toHaveBeenCalledTimes(1);
+    expect(onSetAttributeQuiet.mock.calls[0][0]).toBe("data-fx-chain");
+  });
+});
+
+describe("AudioFxGroup carve visibility", () => {
+  it("offers carve when the composition holds another audio track", () => {
+    const { host } = mount({ "fx-chain": CHAIN });
+    expect(host.querySelector(".hf-fx-carve")).toBeTruthy();
+  });
+
+  it("does not offer carve for the only audio track in the composition", () => {
+    // Nothing to listen to, so the picker would be empty and Analyse inert.
+    const { host } = mount({ "fx-chain": CHAIN }, true);
+    expect(host.querySelector(".hf-fx-carve")).toBeNull();
+  });
+});
+
+describe("AudioFxGroup deleting an effect", () => {
+  const twoNodes = JSON.stringify({
+    version: 1,
+    nodes: [
+      { type: "lowpass", id: "n1", params: { frequency: 400, q: 0.9, poles: "2" } },
+      { type: "peaking", id: "n2", params: { frequency: 900, gain: -6, q: 1 } },
+    ],
+  });
+
+  it("takes the deleted node's lanes with it", () => {
+    // resolveAutomation only hides an orphan at read time. Left in the attribute,
+    // and with ids minted lowest-free, the next effect added takes the same id and
+    // inherits the dead envelope — disabled and "Automated" without the author
+    // ever automating it, and baked into the render.
+    const { host, onSetAttributeQuiet } = mount({
+      "fx-chain": twoNodes,
+      automation: JSON.stringify({
+        version: 1,
+        lanes: [
+          { target: "fx.n1.frequency", points: [{ t: 0, v: 400 }] },
+          { target: "fx.n2.gain", points: [{ t: 0, v: -6 }] },
+          { target: "volume", points: [{ t: 0, v: 1 }] },
+        ],
+      }),
+    });
+    const remove = host.querySelectorAll<HTMLButtonElement>(".hf-fx-remove")[0]!;
+    act(() => remove.click());
+    const automationWrite = onSetAttributeQuiet.mock.calls.find((c) => c[0] === "data-automation");
+    expect(automationWrite).toBeTruthy();
+    expect(
+      JSON.parse(String(automationWrite![1])).lanes.map((l: { target: string }) => l.target),
+    ).toEqual(["fx.n2.gain", "volume"]);
+  });
+
+  it("leaves automation alone when the deleted node had none", () => {
+    const { host, onSetAttributeQuiet } = mount({
+      "fx-chain": twoNodes,
+      automation: JSON.stringify({
+        version: 1,
+        lanes: [{ target: "fx.n2.gain", points: [{ t: 0, v: -6 }] }],
+      }),
+    });
+    act(() => host.querySelectorAll<HTMLButtonElement>(".hf-fx-remove")[0]!.click());
+    expect(onSetAttributeQuiet.mock.calls.some((c) => c[0] === "data-automation")).toBe(false);
+  });
+});

packages/studio/src/components/editor/propertyPanelAudioFxGroup.tsx

@@ -1,9 +1,10 @@
 /**
  * The audio FX panel's bridge to the element/attribute world.
  *
- * Chain and carve are serialised onto the element the way colour grading carries
- * its config, so persistence is an ordinary attribute write with no new server
- * route. Split out of PropertyPanelFlat, which is at its size budget.
+ * Chain, carve and automation are all serialised onto the element the way colour
+ * grading carries its config, so persistence is an ordinary attribute write with
+ * no new server route. Split out of PropertyPanelFlat, which is at its size
+ * budget, and self-contained enough to test on its own.
  */
 
 import { useState } from "react";
@@ -20,8 +21,24 @@ import {
   normalizeCarveSettings,
   type HfCarveSettings,
 } from "@hyperframes/core/audio-carve";
-import type { DomEditSelection } from "./domEditing";
-import { FxSection, type AudioTrackOption } from "./propertyPanelFxSection";
+import { fxAutomationTarget, type HfAutomation } from "@hyperframes/core/audio-automation";
+import {
+  automatedTargetsOf,
+  automationAttrValue,
+  HF_AUDIO_AUTOMATION_ATTR,
+  readPanelAutomation,
+  resolveAutomationRange,
+  withoutLane,
+  withSeededLane,
+} from "./propertyPanelAutomation";
+import type { DomEditSelection } from "./domEditingTypes";
+
+/**
+ * Rate the carve source is decoded at. Analysis is self-consistent because it
+ * reads the decoded buffer's own rate, so this only has to be a sane audio rate.
+ */
+const DECODE_SAMPLE_RATE = 48000;
+import { FxSection, type AudioTrackOption } from "./propertyPanelFxSection.js";
 
 /**
  * Bridges the FX panel to the element/attribute world. Chain and carve are
@@ -30,11 +47,22 @@ import { FxSection, type AudioTrackOption } from "./propertyPanelFxSection";
  */
 export function AudioFxGroup({
   element,
-  onSetAttribute,
+  onSetAttributeQuiet,
   onSetAttributeLive,
 }: {
   element: DomEditSelection;
-  onSetAttribute: (attr: string, value: string) => void | Promise<void>;
+  /**
+   * Every write here is quiet: it persists to the source and skips the preview
+   * reload, because the runtime applies chain and automation edits to the
+   * running graph — a reload would only interrupt the audio to reach the same
+   * state, which is heard as the track chopping.
+   *
+   * It does re-read the selection afterwards, which this panel depends on: each
+   * edit is computed from the current attribute, so without the resync a second
+   * edit would work from a pre-edit value and appear to do nothing.
+   */
+  onSetAttributeQuiet: (attr: string, value: string | null) => void | Promise<void>;
+  /** Continuous, non-persisting write for a dial being dragged. */
   onSetAttributeLive: (attr: string, value: string | null) => void | Promise<void>;
 }) {
   const chain = ((): HfAudioFxChain => {
@@ -49,6 +77,76 @@ export function AudioFxGroup({
     }
   })();
 
+  const automation = readPanelAutomation(element.dataAttributes?.["automation"], chain);
+  const automatedTargets = automatedTargetsOf(automation);
+
+  // Written through the live path on purpose. It persists to the source just
+  // like the refreshing one, but skips the preview reload — and a reload
+  // restarts every playing track, which is heard as the audio chopping. The
+  // runtime follows the attribute and swaps the graph in place instead.
+  const writeAutomation = (next: HfAutomation): void => {
+    void onSetAttributeQuiet(HF_AUDIO_AUTOMATION_ATTR, automationAttrValue(next) || null);
+  };
+
+  /**
+   * Start automating one effect parameter.
+   *
+   * The lane is seeded with a single point at the value the control currently
+   * holds, so switching to an envelope never changes the sound — it only moves
+   * where the value comes from. The author then adds points in the timeline.
+   */
+  const automateParam = (nodeId: string, paramKey: string): void => {
+    const target = fxAutomationTarget(nodeId, paramKey);
+    const node = chain.nodes.find((n) => n.id === nodeId);
+    const range = resolveAutomationRange(target, chain);
+    if (!node || !range) return;
+    const raw = node.params?.[paramKey];
+    writeAutomation(
+      withSeededLane(automation, target, typeof raw === "number" ? raw : range.default),
+    );
+  };
+
+  /** Stop automating it, handing the value back to the panel control. */
+  const removeParamAutomation = (nodeId: string, paramKey: string): void => {
+    writeAutomation(withoutLane(automation, fxAutomationTarget(nodeId, paramKey)));
+  };
+
+  /**
+   * Turn carve on or off.
+   *
+   * Switching off drops the filters it generated — left behind they keep dipping
+   * the bed with nothing in the panel to explain them — but that is a second
+   * attribute, and each write is a read-modify-write against the same source
+   * file. Fired together, both read the same content and the later one drops the
+   * earlier: either the carve settings went and the filters stayed, or the
+   * reverse. Awaiting the first means the second reads the file it produced.
+   *
+   * One commit carrying both would also close the window where a failure of just
+   * the second leaves them half-applied; that needs a multi-attribute quiet
+   * commit, which does not exist yet.
+   */
+  const setCarve = async (next: HfCarveSettings | null): Promise<void> => {
+    if (!next) {
+      const kept = chain.nodes.filter((n) => !n.fromCarve);
+      if (kept.length !== chain.nodes.length) {
+        await onSetAttributeQuiet(
+          HF_AUDIO_FX_ATTR,
+          kept.length ? serializeAudioFxChain({ version: 1, nodes: kept }) : null,
+        );
+      }
+    }
+    await onSetAttributeQuiet(HF_AUDIO_CARVE_ATTR, next ? JSON.stringify(next) : null);
+  };
+
+  /** Every lane belonging to a node that is going away. */
+  const removeNodeAutomation = (nodeId: string): void => {
+    const prefix = `fx.${nodeId}.`;
+    const kept = automation.lanes.filter((lane) => !lane.target.startsWith(prefix));
+    if (kept.length !== automation.lanes.length) {
+      writeAutomation({ version: 1, lanes: kept });
+    }
+  };
+
   const carve = ((): HfCarveSettings | null => {
     const raw = element.dataAttributes?.["fx-carve"];
     if (!raw) return null;
@@ -84,25 +182,28 @@ export function AudioFxGroup({
     try {
       const res = await fetch(new URL(src, doc!.baseURI).href);
       const bytes = await res.arrayBuffer();
+      // Decoded in an OfflineAudioContext, not a live one. Opening a second
+      // output device mid-playback makes the running track glitch while the
+      // hardware is reconfigured; an offline context touches no device.
       const Ctor =
-        window.AudioContext ??
-        (window as unknown as { webkitAudioContext?: typeof AudioContext }).webkitAudioContext;
+        window.OfflineAudioContext ??
+        (window as unknown as { webkitOfflineAudioContext?: typeof OfflineAudioContext })
+          .webkitOfflineAudioContext;
       if (!Ctor) return;
-      const ctx = new Ctor();
-      try {
-        const buffer = await ctx.decodeAudioData(bytes);
-        const bands = analyseCarveBands(buffer.getChannelData(0), buffer.sampleRate, carve);
-        const carved = carveBandsToChain(bands);
-        // Carve output is tagged so a re-run replaces it instead of stacking.
-        const kept = chain.nodes.filter((n) => !n.fromCarve);
-        const next = {
-          version: 1,
-          nodes: [...carved.nodes.map((n) => ({ ...n, fromCarve: true })), ...kept],
-        };
-        onSetAttribute(HF_AUDIO_FX_ATTR, serializeAudioFxChain(next));
-      } finally {
-        void ctx.close().catch(() => undefined);
-      }
+      const decoder = new Ctor(1, 1, DECODE_SAMPLE_RATE);
+      const buffer = await decoder.decodeAudioData(bytes);
+      const bands = analyseCarveBands(buffer.getChannelData(0), buffer.sampleRate, carve);
+      const carved = carveBandsToChain(bands);
+      // Carve output is tagged so a re-run replaces it instead of stacking.
+      const kept = chain.nodes.filter((n) => !n.fromCarve);
+      const next = {
+        version: 1,
+        nodes: [...carved.nodes.map((n) => ({ ...n, fromCarve: true })), ...kept],
+      };
+      // Live, like every other chain write: the runtime swaps the graph in
+      // place, so a reload would only interrupt the audio to reach the same
+      // filters.
+      onSetAttributeQuiet(HF_AUDIO_FX_ATTR, serializeAudioFxChain(next));
     } catch {
       // Leave the chain as it was; the button simply re-enables.
     } finally {
@@ -113,18 +214,28 @@ export function AudioFxGroup({
   return (
     <FxSection
       chain={chain}
+      automatedTargets={automatedTargets}
+      onAutomateParam={automateParam}
+      onRemoveParamAutomation={removeParamAutomation}
+      onRemoveNodeAutomation={removeNodeAutomation}
       onChainChange={(next) =>
-        onSetAttribute(HF_AUDIO_FX_ATTR, next.nodes.length ? serializeAudioFxChain(next) : "")
+        // Live for the same reason as automation above: adding, removing or
+        // bypassing an effect is applied to the running graph, so a reload would
+        // only interrupt the audio to reach the same state.
+        onSetAttributeQuiet(
+          HF_AUDIO_FX_ATTR,
+          next.nodes.length ? serializeAudioFxChain(next) : null,
+        )
       }
       onChainPreview={(next) =>
-        // Live writes skip the preview refresh, so dragging a knob no longer
-        // reloads the composition and restarts playback on every pixel.
+        // Live writes skip the preview refresh entirely, so dragging a knob no
+        // longer reloads the composition and restarts playback on every pixel.
+        // The gesture-end write above is the one that resyncs.
         onSetAttributeLive(HF_AUDIO_FX_ATTR, next.nodes.length ? serializeAudioFxChain(next) : null)
       }
       carve={carve}
-      onCarveChange={(next) =>
-        onSetAttribute(HF_AUDIO_CARVE_ATTR, next ? JSON.stringify(next) : "")
-      }
+      onCarveChange={(next) => void setCarve(next)}
+      onCarvePreview={(next) => onSetAttributeLive(HF_AUDIO_CARVE_ATTR, JSON.stringify(next))}
       sourceOptions={sourceOptions}
       onAnalyseCarve={() => void analyse()}
       analysing={analysing}

packages/studio/src/components/editor/propertyPanelFxSection.test.tsx

@@ -45,6 +45,9 @@ function mount(overrides: Partial<Parameters<typeof FxSection>[0]> = {}) {
       onAnalyseCarve={overrides.onAnalyseCarve ?? noop}
       analysing={overrides.analysing}
       disabled={overrides.disabled}
+      automatedTargets={overrides.automatedTargets}
+      onAutomateParam={overrides.onAutomateParam}
+      onRemoveParamAutomation={overrides.onRemoveParamAutomation}
     />,
   );
   return { host, onChainChange, onChainPreview, onCarveChange };
@@ -245,3 +248,161 @@ describe("FxSection carve", () => {
     }
   });
 });
+
+describe("automation in the panel", () => {
+  const automatable = (chain: HfAudioFxChain, over = {}) =>
+    mount({
+      chain,
+      automatedTargets: new Set<string>(),
+      onAutomateParam: vi.fn(),
+      onRemoveParamAutomation: vi.fn(),
+      ...over,
+    });
+
+  const idChain = (type: string, id = "n1"): HfAudioFxChain => ({
+    version: 1,
+    nodes: [{ type, id, enabled: true, params: defaultAudioFxParams(type) }],
+  });
+
+  const rowFor = (host: HTMLElement, label: string): HTMLElement | null => {
+    for (const row of Array.from(host.querySelectorAll<HTMLElement>(".hf-fx-row"))) {
+      if (row.querySelector(".hf-fx-label")?.textContent === label) return row;
+    }
+    return null;
+  };
+
+  it("offers an automate button only for parameters an envelope can drive", () => {
+    // Saturate: `output` is a make-up gain, but the curve's type and threshold
+    // are rebuilt wholesale and cannot be scheduled.
+    const { host } = automatable(idChain("saturate"));
+    expect(rowFor(host, "Output")?.querySelector(".hf-fx-automate")).toBeTruthy();
+    expect(rowFor(host, "Threshold")?.querySelector(".hf-fx-automate")).toBeNull();
+  });
+
+  it("offers nothing for a worklet effect, which exposes no AudioParams", () => {
+    const { host } = automatable(idChain("compressor"));
+    expect(host.querySelectorAll(".hf-fx-automate").length).toBe(0);
+  });
+
+  it("asks to automate a parameter by node id and key", () => {
+    const onAutomateParam = vi.fn();
+    const { host } = automatable(idChain("lowpass", "n7"), { onAutomateParam });
+    const button = rowFor(host, "Cutoff")!.querySelector(".hf-fx-automate") as HTMLButtonElement;
+    expect(button.hasAttribute("title")).toBe(false);
+    act(() => button.click());
+    expect(onAutomateParam).toHaveBeenCalledWith("n7", "frequency");
+  });
+
+  it("disables an automated control, since a value typed here would be overwritten", () => {
+    const { host } = automatable(idChain("lowpass"), {
+      automatedTargets: new Set(["fx.n1.frequency"]),
+    });
+    const row = rowFor(host, "Cutoff")!;
+    expect(row.querySelector<HTMLInputElement>('input[type="range"]')?.disabled).toBe(true);
+    expect(row.querySelector<HTMLInputElement>('input[type="number"]')?.disabled).toBe(true);
+    expect(row.hasAttribute("data-automated")).toBe(true);
+    // A sibling parameter on the same effect stays editable.
+    const q = rowFor(host, "Q")!;
+    expect(q.querySelector<HTMLInputElement>('input[type="range"]')?.disabled).toBe(false);
+  });
+
+  it("turns the automated parameter's button into a delete", () => {
+    const onRemoveParamAutomation = vi.fn();
+    const { host } = automatable(idChain("lowpass"), {
+      automatedTargets: new Set(["fx.n1.frequency"]),
+      onRemoveParamAutomation,
+    });
+    const button = rowFor(host, "Cutoff")!.querySelector(".hf-fx-automate") as HTMLButtonElement;
+    expect(button.getAttribute("aria-pressed")).toBe("true");
+    expect(button.getAttribute("aria-label")).toMatch(/remove/i);
+    // The wording lives in the Tooltip component, which only renders its bubble
+    // on hover; the button itself carries no native title hover.
+    expect(button.hasAttribute("title")).toBe(false);
+    act(() => button.click());
+    expect(onRemoveParamAutomation).toHaveBeenCalledWith("n1", "frequency");
+  });
+
+  it("shows the wording in a tooltip bubble, not a native browser hover", async () => {
+    vi.useFakeTimers();
+    try {
+      const { host } = automatable(idChain("lowpass"), {
+        automatedTargets: new Set(["fx.n1.frequency"]),
+      });
+      const button = rowFor(host, "Cutoff")!.querySelector(".hf-fx-automate") as HTMLButtonElement;
+      // Tooltip positions itself from the trigger's box and gives up on a 0x0
+      // one, which is every element in happy-dom.
+      vi.spyOn(button, "getBoundingClientRect").mockReturnValue({
+        x: 100,
+        y: 300,
+        left: 100,
+        top: 300,
+        right: 116,
+        bottom: 316,
+        width: 16,
+        height: 16,
+        toJSON: () => ({}),
+      } as DOMRect);
+      // React synthesises pointer-enter from pointerover and delegates focus via
+      // focusin; focus is also how a keyboard user reaches the same tooltip.
+      act(() => {
+        button.dispatchEvent(new Event("focusin", { bubbles: true }));
+      });
+      act(() => {
+        vi.advanceTimersByTime(600);
+      });
+      const bubble = document.querySelector('[role="tooltip"]');
+      expect(bubble?.textContent).toBe("Automated");
+    } finally {
+      vi.useRealTimers();
+    }
+  });
+
+  it("cannot automate a node with no id, which a lane could not address", () => {
+    const { host } = automatable({
+      version: 1,
+      nodes: [{ type: "lowpass", enabled: true, params: defaultAudioFxParams("lowpass") }],
+    });
+    expect(host.querySelectorAll(".hf-fx-automate").length).toBe(0);
+  });
+
+  it("gives a newly added effect an id, so its parameters can be automated", () => {
+    const onChainChange = vi.fn();
+    const { host } = mount({ chain: { version: 1, nodes: [] }, onChainChange });
+    const add = host.querySelector(".hf-fx-add") as HTMLButtonElement;
+    act(() => add.click());
+    const item = Array.from(host.querySelectorAll<HTMLButtonElement>(".hf-fx-add-item")).find(
+      (b) => b.textContent === "Low-pass",
+    )!;
+    act(() => item.click());
+    expect(onChainChange.mock.calls[0][0].nodes[0].id).toBe("n1");
+  });
+});
+
+describe("voiceover carve visibility", () => {
+  const carveBlock = (host: HTMLElement) => host.querySelector(".hf-fx-carve");
+
+  it("is hidden when the composition has no other audio track to listen to", () => {
+    // Carve dips this bed where another track's voice sits. Alone, the control
+    // could only offer an empty picker.
+    const { host } = mount({ chain: chainOf("lowpass"), sourceOptions: [] });
+    expect(carveBlock(host)).toBeNull();
+  });
+
+  it("is shown once there is another audio track", () => {
+    const { host } = mount({
+      chain: chainOf("lowpass"),
+      sourceOptions: [{ id: "vo", label: "vo" }],
+    });
+    expect(carveBlock(host)).toBeTruthy();
+  });
+
+  it("stays shown for an existing carve whose voice track has gone", () => {
+    // Otherwise the setting would keep dipping the bed from out of sight.
+    const { host } = mount({
+      chain: chainOf("lowpass"),
+      sourceOptions: [],
+      carve: { ...DEFAULT_CARVE, source: "vo" },
+    });
+    expect(carveBlock(host)).toBeTruthy();
+  });
+});

packages/studio/src/components/editor/propertyPanelFxSection.tsx

@@ -13,12 +13,15 @@ import {
   defaultAudioFxParams,
   getAudioFxDef,
   HF_AUDIO_FX,
+  mintAudioFxNodeId,
   type HfAudioFxChain,
+  type HfAudioFxDef,
   type HfAudioFxGroup,
   type HfAudioFxNode,
   type HfAudioFxParamValues,
 } from "@hyperframes/core/audio-fx";
 import { DEFAULT_CARVE, type HfCarveSettings } from "@hyperframes/core/audio-carve";
+import { fxAutomationTarget } from "@hyperframes/core/audio-automation";
 import { FxParams, FxParamRow } from "./propertyPanelFxControls.js";
 
 const GROUP_ORDER: HfAudioFxGroup[] = ["filter", "dynamics", "nonlinear", "time"];
@@ -37,6 +40,9 @@ export interface AudioTrackOption {
 interface FxNodeRowProps {
   node: HfAudioFxNode;
   index: number;
+  automatedTargets?: ReadonlySet<string>;
+  onAutomateParam?(nodeId: string, paramKey: string): void;
+  onRemoveParamAutomation?(nodeId: string, paramKey: string): void;
   open: boolean;
   /** Last in the chain, so it cannot move further down. */
   last: boolean;
@@ -142,10 +148,73 @@ function FxNodeHeader({
   );
 }
 
+/**
+ * Which of an effect's knobs already have a lane.
+ *
+ * A lane addresses a node by id, so a node the panel has not yet given one
+ * cannot be automated at all. Adding an effect mints the id, so this only
+ * affects chains written before ids existed.
+ */
+function automatedKeysOf(
+  node: HfAudioFxNode,
+  params: readonly { key: string }[],
+  automatedTargets: ReadonlySet<string> | undefined,
+): Set<string> {
+  if (!node.id || !automatedTargets) return new Set();
+  const nodeId = node.id;
+  return new Set(
+    params.filter((p) => automatedTargets.has(fxAutomationTarget(nodeId, p.key))).map((p) => p.key),
+  );
+}
+
+/** An open effect's knobs, with whatever automation surface applies to them. */
+function FxNodeParams({
+  node,
+  def,
+  index,
+  disabled,
+  automatedTargets,
+  onUpdate,
+  onPreview,
+  onAutomateParam,
+  onRemoveParamAutomation,
+}: {
+  node: HfAudioFxNode;
+  def: HfAudioFxDef;
+  index: number;
+  disabled: boolean;
+  automatedTargets?: ReadonlySet<string>;
+  onUpdate(index: number, patch: Partial<HfAudioFxNode>): void;
+  onPreview(index: number, params: HfAudioFxParamValues): void;
+  onAutomateParam?(nodeId: string, paramKey: string): void;
+  onRemoveParamAutomation?(nodeId: string, paramKey: string): void;
+}) {
+  const nodeId = node.id;
+  return (
+    <FxParams
+      def={def}
+      params={node.params ?? defaultAudioFxParams(node.type)}
+      disabled={disabled}
+      onChange={(params: HfAudioFxParamValues) => onPreview(index, params)}
+      onCommit={(params: HfAudioFxParamValues) => onUpdate(index, { params })}
+      automatedKeys={automatedKeysOf(node, def.params, automatedTargets)}
+      onAutomate={nodeId && onAutomateParam ? (key) => onAutomateParam(nodeId, key) : undefined}
+      onRemoveAutomation={
+        nodeId && onRemoveParamAutomation
+          ? (key) => onRemoveParamAutomation(nodeId, key)
+          : undefined
+      }
+    />
+  );
+}
+
 /** One effect in the chain: its header controls, and its knobs when open. */
 function FxNodeRow({
   node,
   index,
+  automatedTargets,
+  onAutomateParam,
+  onRemoveParamAutomation,
   open,
   last,
   disabled,
@@ -176,12 +245,16 @@ function FxNodeRow({
         onRemove={() => onRemove(index)}
       />
       {open ? (
-        <FxParams
+        <FxNodeParams
+          node={node}
           def={def}
-          params={node.params ?? defaultAudioFxParams(node.type)}
-          disabled={disabled || bypassed}
-          onChange={(params: HfAudioFxParamValues) => onPreview(index, params)}
-          onCommit={(params: HfAudioFxParamValues) => onUpdate(index, { params })}
+          index={index}
+          disabled={Boolean(disabled) || bypassed}
+          automatedTargets={automatedTargets}
+          onUpdate={onUpdate}
+          onPreview={onPreview}
+          onAutomateParam={onAutomateParam}
+          onRemoveParamAutomation={onRemoveParamAutomation}
         />
       ) : null}
     </div>
@@ -190,12 +263,24 @@ function FxNodeRow({
 
 export interface FxSectionProps {
   chain: HfAudioFxChain;
+  /** Targets this track already automates, as `fx.<nodeId>.<param>` strings. */
+  automatedTargets?: ReadonlySet<string>;
+  /** Add a lane for one effect parameter, seeded at its current value. */
+  onAutomateParam?(nodeId: string, paramKey: string): void;
+  /** Delete one effect parameter's lane. */
+  onRemoveParamAutomation?(nodeId: string, paramKey: string): void;
+  /** Delete every lane belonging to a node that is being removed. */
+  onRemoveNodeAutomation?(nodeId: string): void;
   /** Structural edits and gesture-end writes; this is the one that persists. */
   onChainChange(chain: HfAudioFxChain): void;
   /** Continuous updates while a control is being dragged. */
   onChainPreview?(chain: HfAudioFxChain): void;
   carve: HfCarveSettings | null;
+  /** Gesture-end write; this is the one that persists. */
   onCarveChange(carve: HfCarveSettings | null): void;
+  /** Continuous updates while a carve slider is dragged. Without this every
+   *  pointermove patched the source file and resynced the selection. */
+  onCarvePreview?(carve: HfCarveSettings): void;
   /** Other audio elements that could act as the carve source. */
   sourceOptions: AudioTrackOption[];
   /** Re-run analysis against the current source audio. */
@@ -206,15 +291,27 @@ export interface FxSectionProps {
 
 export function FxSection({
   chain,
+  automatedTargets,
+  onAutomateParam,
+  onRemoveParamAutomation,
+  onRemoveNodeAutomation,
   onChainChange,
   onChainPreview,
   carve,
   onCarveChange,
+  onCarvePreview,
   sourceOptions,
   onAnalyseCarve,
   analysing,
   disabled,
 }: FxSectionProps) {
+  // Falls back to the persisting write when no preview handler is supplied, which
+  // keeps the control working rather than going dead.
+  const previewCarve = onCarvePreview ?? onCarveChange;
+
+  // Nothing to carve against means nothing to show — see the block below.
+  const showCarve = sourceOptions.length > 0 || carve !== null;
+
   const [adding, setAdding] = useState(false);
   const [openNode, setOpenNode] = useState<number | null>(0);
 
@@ -240,11 +337,14 @@ export function FxSection({
 
   const addEffect = useCallback(
     (type: string) => {
-      mutate([...chain.nodes, { type, enabled: true, params: defaultAudioFxParams(type) }]);
+      mutate([
+        ...chain.nodes,
+        { type, id: mintAudioFxNodeId(chain), enabled: true, params: defaultAudioFxParams(type) },
+      ]);
       setOpenNode(chain.nodes.length);
       setAdding(false);
     },
-    [chain.nodes, mutate],
+    [chain, mutate],
   );
 
   const updateNode = useCallback(
@@ -255,10 +355,17 @@ export function FxSection({
 
   const removeNode = useCallback(
     (index: number) => {
+      // The node's lanes go with it. `resolveAutomation` only hides an orphan at
+      // read time; left in the attribute, and with ids minted lowest-free, the
+      // next effect added takes the same id and inherits the dead envelope —
+      // arriving with its control disabled and "Automated" without the author
+      // ever automating it, and baked into the render.
+      const removedId = chain.nodes[index]?.id;
+      if (removedId) onRemoveNodeAutomation?.(removedId);
       mutate(chain.nodes.filter((_, i) => i !== index));
       setOpenNode(null);
     },
-    [chain.nodes, mutate],
+    [chain.nodes, mutate, onRemoveNodeAutomation],
   );
 
   const moveNode = useCallback(
@@ -287,6 +394,9 @@ export function FxSection({
               key={`${node.type}-${i}`}
               node={node}
               index={i}
+              automatedTargets={automatedTargets}
+              onAutomateParam={onAutomateParam}
+              onRemoveParamAutomation={onRemoveParamAutomation}
               open={openNode === i}
               last={i === chain.nodes.length - 1}
               disabled={disabled}
@@ -332,98 +442,109 @@ export function FxSection({
         </button>
       )}
 
-      <div className="hf-fx-carve space-y-1 rounded-[4px] border border-panel-border-input p-1.5">
-        <div className="hf-fx-carve-head flex min-h-6 items-center justify-between">
-          <span className="hf-fx-carve-title text-[11px] font-semibold text-panel-text-1">
-            Voiceover carve
-          </span>
-          <button
-            type="button"
-            className="hf-fx-bypass rounded-[3px] border border-panel-border-input px-1.5 py-0.5 font-mono text-[9px] text-panel-text-4 hover:text-panel-text-0 disabled:opacity-40"
-            aria-pressed={carve !== null}
-            disabled={disabled}
-            onClick={() => onCarveChange(carve ? null : { ...DEFAULT_CARVE })}
-          >
-            {carve ? "On" : "Off"}
-          </button>
-        </div>
-        {carve ? (
-          <>
-            <label className="hf-fx-row flex min-h-6 items-center gap-2">
-              <span className="hf-fx-label w-[86px] flex-shrink-0 truncate text-[10px] text-panel-text-4">
-                Listen to
-              </span>
-              <select
-                className="hf-fx-select min-w-0 flex-1 rounded-[3px] bg-panel-surface px-1 py-0.5 font-mono text-[10px] text-panel-text-0"
-                value={carve.source}
-                disabled={disabled}
-                onChange={(e) => onCarveChange({ ...carve, source: e.target.value })}
-              >
-                <option value="">Select a voice track…</option>
-                {sourceOptions.map((o) => (
-                  <option key={o.id} value={o.id}>
-                    {o.label}
-                  </option>
-                ))}
-              </select>
-            </label>
-            <FxParamRow
-              param={{
-                kind: "number",
-                key: "maxCutDb",
-                label: "Depth",
-                unit: "dB",
-                min: 0,
-                max: 24,
-                step: 0.5,
-                default: DEFAULT_CARVE.maxCutDb,
-              }}
-              value={carve.maxCutDb}
-              disabled={disabled}
-              onChange={(_k, v) => onCarveChange({ ...carve, maxCutDb: Number(v) })}
-            />
-            <FxParamRow
-              param={{
-                kind: "number",
-                key: "bands",
-                label: "Bands",
-                unit: "",
-                min: 1,
-                max: 6,
-                step: 1,
-                default: DEFAULT_CARVE.bands,
-              }}
-              value={carve.bands}
-              disabled={disabled}
-              onChange={(_k, v) => onCarveChange({ ...carve, bands: Number(v) })}
-            />
-            <FxParamRow
-              param={{
-                kind: "number",
-                key: "intelligibilityBias",
-                label: "Speech bias",
-                unit: "",
-                min: 0,
-                max: 1,
-                step: 0.05,
-                default: DEFAULT_CARVE.intelligibilityBias,
-                hint: "At 0 the deepest cuts follow raw voice energy, which lands on the fundamental. Higher weights selection toward 1-3 kHz, where a bed actually masks a voice.",
-              }}
-              value={carve.intelligibilityBias}
-              disabled={disabled}
-              onChange={(_k, v) => onCarveChange({ ...carve, intelligibilityBias: Number(v) })}
-            />
+      {/* Carve is a relationship between two tracks: it dips this bed where
+          another track's voice sits. With no other audio track in the
+          composition there is nothing to listen to, so the control would only
+          offer an empty picker. Still shown when carve is already configured,
+          so an existing setting cannot be stranded out of sight after its voice
+          track is removed. */}
+      {showCarve ? (
+        <div className="hf-fx-carve space-y-1 rounded-[4px] border border-panel-border-input p-1.5">
+          <div className="hf-fx-carve-head flex min-h-6 items-center justify-between">
+            <span className="hf-fx-carve-title text-[11px] font-semibold text-panel-text-1">
+              Voiceover carve
+            </span>
             <button
               type="button"
-              className="hf-fx-analyse mt-1 w-full rounded-[3px] bg-panel-surface py-1 text-[10px] text-panel-text-1 hover:text-panel-text-0 disabled:opacity-40"
-              disabled={disabled || analysing || !carve.source || !onAnalyseCarve}
-              onClick={() => onAnalyseCarve?.()}
+              className="hf-fx-bypass rounded-[3px] border border-panel-border-input px-1.5 py-0.5 font-mono text-[9px] text-panel-text-4 hover:text-panel-text-0 disabled:opacity-40"
+              aria-pressed={carve !== null}
+              disabled={disabled}
+              onClick={() => onCarveChange(carve ? null : { ...DEFAULT_CARVE })}
             >
-              {analysing ? "Analysing…" : "Analyse and apply"}
+              {carve ? "On" : "Off"}
             </button>
-          </>
-        ) : null}
-      </div>
+          </div>
+          {carve ? (
+            <>
+              <label className="hf-fx-row flex min-h-6 items-center gap-2">
+                <span className="hf-fx-label w-[86px] flex-shrink-0 truncate text-[10px] text-panel-text-4">
+                  Listen to
+                </span>
+                <select
+                  className="hf-fx-select min-w-0 flex-1 rounded-[3px] bg-panel-surface px-1 py-0.5 font-mono text-[10px] text-panel-text-0"
+                  value={carve.source}
+                  disabled={disabled}
+                  onChange={(e) => onCarveChange({ ...carve, source: e.target.value })}
+                >
+                  <option value="">Select a voice track…</option>
+                  {sourceOptions.map((o) => (
+                    <option key={o.id} value={o.id}>
+                      {o.label}
+                    </option>
+                  ))}
+                </select>
+              </label>
+              <FxParamRow
+                param={{
+                  kind: "number",
+                  key: "maxCutDb",
+                  label: "Depth",
+                  unit: "dB",
+                  min: 0,
+                  max: 24,
+                  step: 0.5,
+                  default: DEFAULT_CARVE.maxCutDb,
+                }}
+                value={carve.maxCutDb}
+                disabled={disabled}
+                onChange={(_k, v) => previewCarve({ ...carve, maxCutDb: Number(v) })}
+                onCommit={(_k, v) => onCarveChange({ ...carve, maxCutDb: Number(v) })}
+              />
+              <FxParamRow
+                param={{
+                  kind: "number",
+                  key: "bands",
+                  label: "Bands",
+                  unit: "",
+                  min: 1,
+                  max: 6,
+                  step: 1,
+                  default: DEFAULT_CARVE.bands,
+                }}
+                value={carve.bands}
+                disabled={disabled}
+                onChange={(_k, v) => previewCarve({ ...carve, bands: Number(v) })}
+                onCommit={(_k, v) => onCarveChange({ ...carve, bands: Number(v) })}
+              />
+              <FxParamRow
+                param={{
+                  kind: "number",
+                  key: "intelligibilityBias",
+                  label: "Speech bias",
+                  unit: "",
+                  min: 0,
+                  max: 1,
+                  step: 0.05,
+                  default: DEFAULT_CARVE.intelligibilityBias,
+                  hint: "At 0 the deepest cuts follow raw voice energy, which lands on the fundamental. Higher weights selection toward 1-3 kHz, where a bed actually masks a voice.",
+                }}
+                value={carve.intelligibilityBias}
+                disabled={disabled}
+                onChange={(_k, v) => previewCarve({ ...carve, intelligibilityBias: Number(v) })}
+                onCommit={(_k, v) => onCarveChange({ ...carve, intelligibilityBias: Number(v) })}
+              />
+              <button
+                type="button"
+                className="hf-fx-analyse mt-1 w-full rounded-[3px] bg-panel-surface py-1 text-[10px] text-panel-text-1 hover:text-panel-text-0 disabled:opacity-40"
+                disabled={disabled || analysing || !carve.source || !onAnalyseCarve}
+                onClick={() => onAnalyseCarve?.()}
+              >
+                {analysing ? "Analysing…" : "Analyse and apply"}
+              </button>
+            </>
+          ) : null}
+        </div>
+      ) : null}
     </div>
   );
 }