From 34118d8f20cf9682f119b157e89b2f3fe42cd4e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel?= Date: Sat, 7 Nov 2026 22:54:11 +0000 Subject: [PATCH] test(producer): the injector budget test no longer leaves a no-op injector for later tests (#7384) --- .../chunkFrames.injectorBudget.test.ts | 43 +++++++++++-------- .../src/services/distributed/chunkFrames.ts | 6 ++- 2 files changed, 30 insertions(+), 19 deletions(-) diff --git a/packages/producer/src/services/distributed/chunkFrames.injectorBudget.test.ts b/packages/producer/src/services/distributed/chunkFrames.injectorBudget.test.ts index d6164d77d8..2d7b40320b 100644 --- a/packages/producer/src/services/distributed/chunkFrames.injectorBudget.test.ts +++ b/packages/producer/src/services/distributed/chunkFrames.injectorBudget.test.ts @@ -1,25 +1,34 @@ -import { afterAll, describe, expect, it, mock } from "bun:test"; - -const real = await import("@hyperframes/engine"); -const created: unknown[] = []; -mock.module("@hyperframes/engine", () => ({ - ...real, - createVideoFrameInjector: (_lookup: unknown, options: unknown) => { - created.push(options); - return async () => {}; - }, -})); -afterAll(() => mock.module("@hyperframes/engine", () => real)); - -const { createChunkVideoFrameInjectorFactory } = await import("./chunkFrames.js"); +import { describe, expect, it } from "bun:test"; +import { createFrameLookupTable } from "@hyperframes/engine"; +import { + chunkFrameInjectorDependencies, + createChunkVideoFrameInjectorFactory, +} from "./chunkFrames.js"; const budget = { frameDataUriCacheLimit: 256, frameDataUriCacheBytesLimitMb: 375 }; describe("chunk video frame injector budget", () => { it("hands the shared cache budget to every injector it builds", async () => { - const lookup = real.createFrameLookupTable([], []); - createChunkVideoFrameInjectorFactory(lookup, budget)(); - await createChunkVideoFrameInjectorFactory(Promise.resolve(lookup), budget)()?.({} as never, 0); + const created: unknown[] = []; + const real = chunkFrameInjectorDependencies.createVideoFrameInjector; + chunkFrameInjectorDependencies.createVideoFrameInjector = (_lookup, options) => { + created.push(options); + return async () => {}; + }; + try { + const lookup = createFrameLookupTable([], []); + createChunkVideoFrameInjectorFactory(lookup, budget)(); + await createChunkVideoFrameInjectorFactory(Promise.resolve(lookup), budget)()?.( + {} as never, + 0, + ); + } finally { + chunkFrameInjectorDependencies.createVideoFrameInjector = real; + } expect(created).toEqual([budget, budget]); }); + + it("leaves the engine's own injector in place for every later test", () => { + expect(createChunkVideoFrameInjectorFactory(null)()).toBeNull(); + }); }); diff --git a/packages/producer/src/services/distributed/chunkFrames.ts b/packages/producer/src/services/distributed/chunkFrames.ts index d5af14615f..a1fb157b62 100644 --- a/packages/producer/src/services/distributed/chunkFrames.ts +++ b/packages/producer/src/services/distributed/chunkFrames.ts @@ -49,17 +49,19 @@ export class RenderChunkValidationError extends Error { } } +export const chunkFrameInjectorDependencies = { createVideoFrameInjector }; + /** One injector per browser session: a hook reused on a fresh page can skip its first injection. */ export function createChunkVideoFrameInjectorFactory( frameLookup: FrameLookupTable | Promise | null, options?: Parameters[1], ): () => BeforeCaptureHook | null { if (!(frameLookup instanceof Promise)) - return () => createVideoFrameInjector(frameLookup, options); + return () => chunkFrameInjectorDependencies.createVideoFrameInjector(frameLookup, options); return () => { let hook: BeforeCaptureHook | null | undefined; return async (page, time, heldVideoTime) => { - hook ??= createVideoFrameInjector(await frameLookup, options); + hook ??= chunkFrameInjectorDependencies.createVideoFrameInjector(await frameLookup, options); await hook?.(page, time, heldVideoTime); }; };