fix(runtime): schedule future WebAudio clips with delay instead of playing immediately

Clips whose compositionStart is ahead of the current timeline position
were starting immediately because sourceNode.start() always received
when=0. Use the AudioContext scheduling API to defer future clips:
sourceNode.start(ctx.currentTime + delay, mediaStart).

Closes #674

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Miguel Ángel
2026-05-08 14:56:33 +00:00
co-authored by Claude Opus 4.6
parent 8de7ad7f61
commit 38522f996e
2 changed files with 89 additions and 2 deletions
@@ -80,4 +80,85 @@ describe("WebAudioTransport", () => {
expect(transport.context).toBeNull();
expect(transport.isActive()).toBe(false);
});
describe("schedulePlayback timing", () => {
function createMockAudioContext(currentTime = 100) {
const startFn = vi.fn();
const sourceNode = {
buffer: null as AudioBuffer | null,
start: startFn,
connect: vi.fn(),
};
const gainNode = {
gain: { value: 1 },
connect: vi.fn(),
};
const masterGain = {
gain: { value: 1 },
connect: vi.fn(),
};
const ctx = {
currentTime,
state: "running",
resume: vi.fn(),
createBufferSource: vi.fn(() => sourceNode),
createGain: vi.fn(() => gainNode),
destination: {},
close: vi.fn(),
};
return { ctx, sourceNode, gainNode, masterGain, startFn };
}
function setupTransport(currentTime = 100) {
const transport = new WebAudioTransport();
const mock = createMockAudioContext(currentTime);
(transport as unknown as { _ctx: unknown })._ctx = mock.ctx;
(transport as unknown as { _masterGain: unknown })._masterGain = mock.masterGain;
const gen = transport.startGeneration();
return { transport, mock, gen };
}
const mockBuffer = {} as AudioBuffer;
const mockEl = { muted: false } as HTMLMediaElement;
it("starts in-progress clips immediately with correct buffer offset", async () => {
const { transport, mock, gen } = setupTransport(100);
await transport.schedulePlayback(mockEl, mockBuffer, 5, 0, 8, 1, gen);
expect(mock.startFn).toHaveBeenCalledWith(0, 3);
});
it("starts in-progress clips with mediaStart offset", async () => {
const { transport, mock, gen } = setupTransport(100);
await transport.schedulePlayback(mockEl, mockBuffer, 5, 2, 8, 1, gen);
expect(mock.startFn).toHaveBeenCalledWith(0, 5);
});
it("schedules future clips with delay instead of playing immediately", async () => {
const { transport, mock, gen } = setupTransport(100);
await transport.schedulePlayback(mockEl, mockBuffer, 10, 0, 2, 1, gen);
expect(mock.startFn).toHaveBeenCalledWith(108, 0);
});
it("schedules future clips with correct mediaStart", async () => {
const { transport, mock, gen } = setupTransport(100);
await transport.schedulePlayback(mockEl, mockBuffer, 10, 1.5, 2, 1, gen);
expect(mock.startFn).toHaveBeenCalledWith(108, 1.5);
});
it("starts clips at exact composition start time immediately", async () => {
const { transport, mock, gen } = setupTransport(100);
await transport.schedulePlayback(mockEl, mockBuffer, 5, 0, 5, 1, gen);
expect(mock.startFn).toHaveBeenCalledWith(0, 0);
});
});
});
@@ -91,10 +91,16 @@ export class WebAudioTransport {
sourceNode.connect(gainNode);
gainNode.connect(this._masterGain);
const offset = Math.max(0, compositionTime - compositionStart + mediaStart);
const elapsed = compositionTime - compositionStart;
const scheduledAt = this._ctx.currentTime;
this._scheduleOffset = scheduledAt - compositionTime;
sourceNode.start(0, offset);
if (elapsed >= 0) {
sourceNode.start(0, elapsed + mediaStart);
} else {
const delay = -elapsed;
sourceNode.start(scheduledAt + delay, mediaStart);
}
const priorMuted = el.muted;
el.muted = true;