fix(render): scope strict lint to composition (#2261)

* fix(render): scope strict lint to composition

* fix(lint): validate explicit composition scope
This commit is contained in:
Miguel Ángel
2026-07-12 22:18:11 -04:00
committed by GitHub
parent 2e34a2d5a0
commit 38badff820
3 changed files with 54 additions and 8 deletions
+2 -1
View File
@@ -807,7 +807,8 @@ export default defineCommand({
// ── Pre-render lint ──────────────────────────────────────────────────
{
const lintResult = await lintProject(project.dir);
const explicitEntry = args.composition && args.composition !== "." ? entryFile : undefined;
const lintResult = await lintProject(project.dir, explicitEntry);
if (!quiet && (lintResult.totalErrors > 0 || lintResult.totalWarnings > 0)) {
console.log("");
for (const line of formatLintFindings(lintResult, { errorsFirst: true })) console.log(line);
@@ -876,6 +876,43 @@ describe("texture_mask_asset_not_found", () => {
});
describe("multiple_root_compositions", () => {
it("scopes lint to an explicit render composition entry", async () => {
const project = makeProject(validHtml());
const standalone = join(project, "standalone.html");
writeFileSync(standalone, validHtml("standalone"));
const { totalErrors, results } = await lintProject(project, standalone);
expect(totalErrors).toBe(0);
expect(results.map((result) => result.file)).toEqual(["standalone.html"]);
expect(
results[0]?.result.findings.find((finding) => finding.code === "multiple_root_compositions"),
).toBeUndefined();
});
it("reports findings from an explicit render composition entry", async () => {
const project = makeProject(validHtml());
const standalone = join(project, "standalone.html");
writeFileSync(standalone, htmlWithMissingMediaId());
const { totalErrors, results } = await lintProject(project, standalone);
expect(totalErrors).toBeGreaterThan(0);
expect(results[0]?.result.findings.some((finding) => finding.code === "media_missing_id")).toBe(
true,
);
});
it("rejects an explicit render composition entry outside the project", async () => {
const project = makeProject(validHtml());
const outsideDir = tmpProject("outside-entry");
dirs.push(outsideDir);
const outsideEntry = join(outsideDir, "standalone.html");
writeFileSync(outsideEntry, validHtml("standalone"));
await expect(lintProject(project, outsideEntry)).rejects.toThrow(/outside.*project/i);
});
it("fires when two HTML files have data-composition-id", async () => {
const project = makeProject(validHtml());
writeFileSync(