fix(studio): author every new tween against one element

U3 fixed "add keyframe at playhead" widening a write to every sibling
sharing a class, but wired writeTargetSelector into only two paths. The
same bug was still reachable from the add-animation button, drag, resize,
rotate, gesture recording, and the property panel: each derived its target
from selectorFromSelection, which hands back a bare class for an id-less
element, so one edit authored a tween over all five siblings and the
timeline collapsed their rows into one.

Route every path that authors a NEW tween through the existing ladder:

- ensureElementAddressable now accepts selection.selector only when it
  addresses exactly one element, so the id-minting fallback right below it
  (previously unreachable whenever any selector was present) does the work.
- gsapDragCommit's five new-tween branches go through one newTweenTarget
  helper; instant patches reuse the written target so the runtime moves the
  element the source write names.
- useGestureCommit and useAnimatedPropertyCommit keep the existing selector
  for matching/retargeting and author new tweens with a separate write
  selector.

Retargets of an EXISTING tween are deliberately untouched: they keep
anim.targetSelector, so a tween aimed at a whole group stays aimed at it.

Narrowing the write alone regressed idempotency, verified by test: the
"is there already a write for this element" lookups matched targetSelector
by string, so the next nudge missed the write it had just made and appended
a second, conflicting one. The read half now falls back to the live DOM
(tweenTargetsElement, same contract as getAnimationsForElement), which also
still matches a deliberate group tween.

Tests reproduce each site through a real writer, re-parse with the real
parser, and resolve through resolveSelectorElementIds (what feeds the
keyframe cache and the lanes), plus pins for the new-tween vs
retarget-existing distinction so a future change cannot collapse the two.
This commit is contained in:
Miguel Angel Simon Sierra
2026-07-28 21:21:37 +02:00
parent ba0d6406d2
commit 3d92436066
10 changed files with 748 additions and 30 deletions
+30 -8
View File
@@ -12,7 +12,7 @@ import { usePlayerStore } from "../player/store/playerStore";
import { readRuntimeKeyframes, scanAllRuntimeKeyframes } from "./gsapRuntimeKeyframes";
import { resolveTweenStart, resolveTweenDuration } from "../utils/globalTimeCompiler";
import { roundTo3 } from "../utils/rounding";
import { computeElementPercentage, idSelector } from "./gsapShared";
import { computeElementPercentage, idSelector, writeTargetSelector } from "./gsapShared";
import { computeDraggedGsapPosition } from "./draggedGsapPosition";
import type { RuntimeTweenChange } from "./gsapRuntimePatch";
import { isGestureTransactionCommit, runGestureTransaction } from "./gestureTransaction";
@@ -44,6 +44,18 @@ export interface GsapDragCommitCallbacks {
fetchAnimations?: () => Promise<GsapAnimation[]>;
}
/**
* The target for a tween these helpers are about to CREATE. Callers derive
* `selector` with `selectorFromSelection`, which hands back a bare class for an
* id-less element: authoring that widens a one-element drag/resize/rotate into a
* write over every sibling sharing the class. Retargets of an EXISTING tween
* must NOT come through here (they keep `anim.targetSelector`, so a tween the
* author aimed at a group stays aimed at it).
*/
function newTweenTarget(selection: DomEditSelection, selector: string): string {
return writeTargetSelector(selection) ?? selector;
}
// Re-export for backward compatibility with existing imports.
export function computeCurrentPercentage(
selection: DomEditSelection,
@@ -75,7 +87,7 @@ async function replaceKeyframedPositionHold(
selection,
{
type: "add",
targetSelector: selector,
targetSelector: newTweenTarget(selection, selector),
method: "set",
position: 0,
properties,
@@ -199,11 +211,14 @@ export async function commitStaticGsapPosition(
}
// New static hold → a base `gsap.set` (off-timeline, no 0% keyframe marker), with
// an instant patch so the first nudge shows immediately (no soft-reload flash).
// The patch reuses the WRITTEN target so the runtime moves exactly the element
// the source write names.
const target = newTweenTarget(selection, selector);
await callbacks.commitMutation(
selection,
{
type: "add",
targetSelector: selector,
targetSelector: target,
method: "set",
position: 0,
properties: { x: newX, y: newY },
@@ -212,7 +227,10 @@ export async function commitStaticGsapPosition(
{
label: "Move layer",
softReload: true,
instantPatch: { selector, change: { kind: "global-set", props: { x: newX, y: newY } } },
instantPatch: {
selector: target,
change: { kind: "global-set", props: { x: newX, y: newY } },
},
},
);
}
@@ -252,11 +270,12 @@ export async function commitStaticGsapRotation(
return;
}
// New static hold → off-timeline `gsap.set` (no 0% keyframe marker) + instant patch.
const target = newTweenTarget(selection, selector);
await callbacks.commitMutation(
selection,
{
type: "add",
targetSelector: selector,
targetSelector: target,
method: "set",
position: 0,
properties: { rotation: newRotation },
@@ -265,7 +284,10 @@ export async function commitStaticGsapRotation(
{
label: "Rotate layer",
softReload: true,
instantPatch: { selector, change: { kind: "global-set", props: { rotation: newRotation } } },
instantPatch: {
selector: target,
change: { kind: "global-set", props: { rotation: newRotation } },
},
},
);
}
@@ -305,7 +327,7 @@ export async function commitStaticGsapSize(
selection,
{
type: "add",
targetSelector: selector,
targetSelector: newTweenTarget(selection, selector),
method: "set",
position: 0,
properties: { width, height },
@@ -393,7 +415,7 @@ export async function commitKeyframedSizeFromResize(
selection,
{
type: "add-with-keyframes",
targetSelector: selector,
targetSelector: newTweenTarget(selection, selector),
position: roundTo3(ts),
duration: roundTo3(td),
keyframes,