From 3e04a59500cbbba8471976e76adee7d14bbe413b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel?= Date: Wed, 11 Nov 2026 16:17:08 +0000 Subject: [PATCH] chore(producer): keep the probe-needs-a-browser doc on its own function (#7554) --- .../src/services/render/stages/probeStage.ts | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/packages/producer/src/services/render/stages/probeStage.ts b/packages/producer/src/services/render/stages/probeStage.ts index 0507c8b995..59551c395c 100644 --- a/packages/producer/src/services/render/stages/probeStage.ts +++ b/packages/producer/src/services/render/stages/probeStage.ts @@ -313,19 +313,6 @@ function hasRuntimeMediaChanges(html: string): boolean { return false; } -/** - * Does this render need a browser probe at all? - * - * Extracted as a pure predicate because whether a probe runs decides whether - * a LIVE DOM element count is available downstream, and the short-comp - * inversion band fails closed without one (see - * `resolveCompositionElementCount` / `resolveDeShortBand`). Notably NONE of - * these conditions fire for a known-duration, media-free composition that - * builds thousands of `div`/`span` nodes in its own init script — - * `hasRuntimeMediaChanges` matches only media creation/source changes — so - * that shape is measured statically and must never reach the band's `applied` - * cohort (review finding, R4). - */ /** A strict render with variables to check needs the loaded page; with none there is nothing to read. */ function checksVariablesInBrowser(config: RenderConfig): boolean { return config.strictVariables === true && Object.keys(config.variables ?? {}).length > 0; @@ -340,6 +327,10 @@ export function strictVariablesAttestation( return !checksVariablesInBrowser(config) || probeSession?.strictVariablesChecked === true; } +/** + * Does this render need a browser probe at all? A pure predicate, because a probe decides whether a LIVE DOM element + * count exists downstream, and the short-comp inversion band fails closed without one. + */ export function probeRequiresBrowser(args: { durationSeconds: number; unresolvedCompositionCount: number;