ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-03 04:38:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: propagate data-timeline-locked in compiler inliners

Browse Source 
The runtime path (compositionLoader.ts) already propagated
data-timeline-locked from inner root to host, but both compiler
inliners (bundler + producer) did not. Bundled output re-opened in
Studio would lose the lock. Now propagated in inlineSubCompositions
alongside the existing data-hf-authored-id propagation.
This commit is contained in:
Miguel Ángel
2026-05-20 02:40:49 -04:00
parent 9c159ad96d
commit 3e17ef7447
2 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/compiler/inlineSubCompositions.test.ts
+19
View File
@@ -197,6 +197,25 @@ describe("inlineSubCompositions – #ID selector scoping divergence", () => {
); );
}); });
it("propagates data-timeline-locked from inner root to host element", () => {
const lockedSubComp = `<!doctype html>
<html><head></head><body>
<div id="captions" data-composition-id="captions" data-timeline-locked data-width="1920" data-height="1080">
<span>Hello</span>
</div>
</body></html>`;
const document = makeHostDocument("captions");
const host = document.querySelector('[data-composition-src="intro.html"]')!;
inlineSubCompositions(document, [host], {
resolveHtml: () => lockedSubComp,
parseHtml: (html) => parseHTML(html).document,
});
expect(host.hasAttribute("data-timeline-locked")).toBe(true);
});
it("producer path propagates data-hf-authored-id to host when inner root has id", () => { it("producer path propagates data-hf-authored-id to host when inner root has id", () => {
const document = makeHostDocument("intro"); const document = makeHostDocument("intro");
const host = document.querySelector('[data-composition-src="intro.html"]')!; const host = document.querySelector('[data-composition-src="intro.html"]')!;
packages/core/src/compiler/inlineSubCompositions.ts
+4
View File
@@ -302,6 +302,10 @@ export function inlineSubCompositions(
); );
} }
if (innerRoot?.hasAttribute("data-timeline-locked")) {
hostEl.setAttribute("data-timeline-locked", "");
}
// Copy dimension attributes from inner root to host if missing // Copy dimension attributes from inner root to host if missing
if (innerRoot) { if (innerRoot) {
const innerW = innerRoot.getAttribute("data-width"); const innerW = innerRoot.getAttribute("data-width");