fix(cli,studio): refuse ?hf-proxy when a request carries no same-site signal (#8066)

A media-proxy request with neither Sec-Fetch-Site nor a Referer naming the
host was treated as same-site. Play, the static project server and Studio now
require a positive signal and refuse the request otherwise. The check
command's own re-request of failed media sends a Referer for its origin so it
keeps working.

— Rames

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
James Russo
2026-11-17 16:45:34 +00:00
committed by GitHub
co-authored by Claude Opus 5.5
parent a56fa2caf3
commit 4bea3e79c2
12 changed files with 201 additions and 87 deletions
@@ -84,6 +84,9 @@ const mocks = vi.hoisted(() => {
});
const FakeProxyTranscodeError = mocks.ProxyTranscodeError;
/** What the page itself sends for its media; a proxy copy needs a same-site signal. */
const OWN_PAGE = { headers: { "Sec-Fetch-Site": "same-origin" } };
vi.mock("@hyperframes/studio-server/proxy-transcoder", () => ({
resolveProxy: mocks.resolveProxy,
ProxyTranscodeError: mocks.ProxyTranscodeError,
@@ -312,7 +315,7 @@ describe("serveStaticProjectHtml asset stream lifetime", () => {
const status = await new Promise<number | undefined>((resolve, reject) => {
const req = get(
`${server?.url}large.mp4${proxy ? "?hf-proxy=h264" : ""}`,
{ headers: range ? { Range: range } : {} },
{ headers: { ...(range ? { Range: range } : {}), ...(proxy ? OWN_PAGE.headers : {}) } },
(response) => {
response.on("data", () => {
response.destroy();
@@ -486,7 +489,7 @@ describe("serveStaticProjectHtml transparent media proxies", () => {
mocks.resolveProxy.mockResolvedValue(proxyPath);
server = await serveStaticProjectHtml(projectDir, "<html></html>");
const res = await fetch(`${server.url}clip.mp4?hf-proxy=h264`);
const res = await fetch(`${server.url}clip.mp4?hf-proxy=h264`, OWN_PAGE);
expect(res.status).toBe(200);
expect(await res.text()).toBe("transcoded-h264-bytes");
expect(mocks.resolveProxy).toHaveBeenCalledWith(
@@ -526,7 +529,7 @@ describe("serveStaticProjectHtml transparent media proxies", () => {
mocks.resolveProxy.mockResolvedValue(proxyPath);
server = await serveStaticProjectHtml(projectDir, "<html></html>");
const res = await fetch(`${server.url}clip.mp4?hf-proxy=h264&hf-proxy-box=2048x1448`);
const res = await fetch(`${server.url}clip.mp4?hf-proxy=h264&hf-proxy-box=2048x1448`, OWN_PAGE);
expect(await res.text()).toBe("boxed-h264-bytes");
expect(mocks.resolveProxy).toHaveBeenCalledWith(
@@ -561,7 +564,7 @@ describe("serveStaticProjectHtml transparent media proxies", () => {
mocks.resolveProxy.mockResolvedValue(proxyPath);
server = await serveStaticProjectHtml(projectDir, "<html></html>");
const res = await fetch(`${server.url}clip.${extension}?hf-proxy=h264`);
const res = await fetch(`${server.url}clip.${extension}?hf-proxy=h264`, OWN_PAGE);
expect(res.status).toBe(200);
expect(await res.text()).toBe("transcoded-h264-bytes");
expect(mocks.resolveProxy).toHaveBeenCalledWith(projectDir, sourcePath, "h264", undefined, {
@@ -584,7 +587,7 @@ describe("serveStaticProjectHtml transparent media proxies", () => {
mocks.resolveProxy.mockResolvedValueOnce(proxyPath);
server = await serveStaticProjectHtml(projectDir, "<html></html>");
const res = await fetch(`${server.url}clip.mov?hf-proxy=auto`);
const res = await fetch(`${server.url}clip.mov?hf-proxy=auto`, OWN_PAGE);
expect(res.status).toBe(200);
expect(res.headers.get("content-type")).toBe("video/webm");
@@ -606,7 +609,7 @@ describe("serveStaticProjectHtml transparent media proxies", () => {
);
server = await serveStaticProjectHtml(projectDir, "<html></html>");
const res = await fetch(`${server.url}clip.mp4?hf-proxy=h264`);
const res = await fetch(`${server.url}clip.mp4?hf-proxy=h264`, OWN_PAGE);
expect(res.status).toBe(502);
});
@@ -616,7 +619,7 @@ describe("serveStaticProjectHtml transparent media proxies", () => {
mocks.resolveProxy.mockRejectedValue(new mocks.ProxyCapacityError());
server = await serveStaticProjectHtml(projectDir, "<html></html>");
const res = await fetch(`${server.url}clip.mp4?hf-proxy=h264`);
const res = await fetch(`${server.url}clip.mp4?hf-proxy=h264`, OWN_PAGE);
expect(res.status).toBe(503);
expect(res.headers.get("retry-after")).toBe("1");
});
@@ -626,22 +629,25 @@ describe("serveStaticProjectHtml transparent media proxies", () => {
writeFileSync(join(projectDir, "image.png"), "not-a-video");
server = await serveStaticProjectHtml(projectDir, "<html></html>");
const res = await fetch(`${server.url}image.png?hf-proxy=h264`);
const res = await fetch(`${server.url}image.png?hf-proxy=h264`, OWN_PAGE);
expect(res.status).toBe(404);
expect(mocks.resolveProxy).not.toHaveBeenCalled();
});
// fails without the fix: another site's page could make this machine transcode the asset.
it.each(["cross-site", "same-site"])(
// fails without the fix: another site's page could make this machine transcode the asset,
// and a request carrying neither fetch metadata nor a Referer counted as this site's.
it.each([
["cross-site", { "Sec-Fetch-Site": "cross-site" }],
["same-site", { "Sec-Fetch-Site": "same-site" }],
["no fetch metadata and no Referer", {}],
])(
"refuses ?hf-proxy for a request from another site (%s) without starting a transcode",
async (site) => {
async (_label, headers: Record<string, string>) => {
const projectDir = mk();
writeFileSync(join(projectDir, "clip.mp4"), "original-hevc-bytes");
server = await serveStaticProjectHtml(projectDir, "<html></html>");
const res = await fetch(`${server.url}clip.mp4?hf-proxy=h264`, {
headers: { "Sec-Fetch-Site": site },
});
const res = await fetch(`${server.url}clip.mp4?hf-proxy=h264`, { headers });
expect(res.status).toBe(403);
expect(mocks.resolveProxy).not.toHaveBeenCalled();
},
@@ -661,6 +667,11 @@ describe("serveStaticProjectHtml transparent media proxies", () => {
expect(own.status).toBe(200);
expect(await own.text()).toBe("transcoded-h264-bytes");
const referred = await fetch(`${server.url}clip.mp4?hf-proxy=h264`, {
headers: { Referer: server.url },
});
expect(referred.status).toBe(200);
const plain = await fetch(`${server.url}clip.mp4`, {
headers: { "Sec-Fetch-Site": "cross-site" },
});
@@ -683,7 +694,7 @@ describe("serveStaticProjectHtml transparent media proxies", () => {
}),
);
const closing = await serveStaticProjectHtml(projectDir, "<html><head></head></html>");
const held = fetch(`${closing.url}clip.mp4?hf-proxy=h264`);
const held = fetch(`${closing.url}clip.mp4?hf-proxy=h264`, OWN_PAGE);
await vi.waitFor(() => expect(asked).toBeDefined());
const injected = vi.mocked(injectMediaCodecMapIntoHtml).mock.calls.at(-1) as unknown[];
const prewarms = injected[5] as AbortSignal | undefined;