mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-13 07:40:06 +00:00
fix(pr-to-video): use display names, not GitHub logins, in credits narration (#2385)
* fix(pr-to-video): use display names, not GitHub logins, in credits narration gh pr view already returns a `name` field for the PR author, commit authors, and mergedBy. ingest.mjs now tracks it in people.json alongside login; fetch-people-avatars.mjs resolves a name for reviewers/commenters/assignees gh doesn't name via the public GitHub user API, best-effort. story-design.md now directs the credits close to speak the person's name (TTS reading a raw handle like @miguAng18947550 aloud is the failure mode), with the handle shown as secondary on-screen text only. * fix(pr-to-video): resolve missing credit names via the agent, not a new script fetch fetch-people-avatars.mjs already runs inside the orchestrating agent's turn, which has gh available — no need for the script to duplicate a name lookup the agent can do itself with `gh api users/<login> --jq .name`. Reverts the script back to avatar-fetching only; SKILL.md/story-design.md now tell the agent to resolve any missing name for the credited people itself before writing the credits close. * fix(pr-to-video): regenerate skills-manifest.json hash Stale hash left over from a rebase conflict I resolved by hand — the generator produces the correct one.
This commit is contained in:
@@ -159,6 +159,8 @@ A PR is shipped by people, and every PR video closes with a `credits` frame nami
|
||||
|
||||
The `credits` frame is an avatar row with names + roles + an "approved" check. On that frame only, set `asset_candidates` to 1–6 entries of `assets/<login>.png — <login>, <role>` (commit authors by `commitCount` first, then reviewers; only `avatarFetched: true` logins). The body stays code-only — avatars appear **only** on this close, never decorating a diff frame. The frame sits in the Step 3 proposal like any other, so the user can cut it there; skip it yourself only when no avatar was fetched.
|
||||
|
||||
> **Narrate the name, not the handle.** `people.json` carries a `name` field (GitHub display name, e.g. "Miguel Angel Simon Sierra") next to `login` for whichever contributors `gh` already named (author, commit authors, `mergedBy`); it's `null` for reviewers/commenters/assignees, which `gh pr view` only ever gives a bare login. Before writing this frame, resolve any `null` name yourself for the 1-6 people going on the close: `gh api users/<login> --jq .name`. Voiceover always says the **name** (first name is enough — "Shipped by Miguel, reviewed by Wenbo") and **never** reads a raw `@login` aloud (`@miguAng18947550` spoken by TTS is the failure mode this exists to avoid). On-screen text under each avatar can show both, name first, handle small and secondary: `Miguel Angel Simon Sierra` / `@miguel-heygen`. When a name still doesn't resolve (GitHub has no public name for that user either), fall back to the login on-screen and skip that person from the spoken line rather than reading the handle.
|
||||
|
||||
Every other frame has **no** `asset_candidates` (the visuals are invented downstream from `scene` + the diff).
|
||||
|
||||
### Versions on the end card (cta / changelog)
|
||||
|
||||
Reference in New Issue
Block a user