From 4d5b4976ef4862a939a40a183b7022debe7ae4d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel?= Date: Mon, 30 Mar 2026 19:17:29 +0200 Subject: [PATCH] fix(engine): union video selectors to restore backward compat with regression tests The video[src][data-start] selector excluded production compositions whose video elements have id+src but no data-start, breaking all visual frames while audio passed. Now unions both selectors so videos are discovered if they match either video[id][src] (original) or video[src][data-start] (sub-composition without explicit id). --- packages/engine/src/services/videoFrameExtractor.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/engine/src/services/videoFrameExtractor.ts b/packages/engine/src/services/videoFrameExtractor.ts index 038b3996d0..e33fa527be 100644 --- a/packages/engine/src/services/videoFrameExtractor.ts +++ b/packages/engine/src/services/videoFrameExtractor.ts @@ -52,7 +52,14 @@ export function parseVideoElements(html: string): VideoElement[] { const videos: VideoElement[] = []; const { document } = parseHTML(html); - const videoEls = Array.from(document.querySelectorAll("video[src][data-start]")); + // Union: original "video[id][src]" (backward compat) + "video[src][data-start]" + // (sub-composition videos that have timing but no explicit id). + const videoEls = Array.from( + new Set([ + ...Array.from(document.querySelectorAll("video[id][src]")), + ...Array.from(document.querySelectorAll("video[src][data-start]")), + ]), + ); videoEls.forEach((el, i) => { if (!el.id) el.id = `hf-video-${i}`; });