fix(studio): the timeline reads clip speed with the same limits as playback (#4667)

This commit is contained in:
Miguel Ángel
2026-09-28 16:15:49 +00:00
committed by GitHub
parent e251d4c1de
commit 523685985b
2 changed files with 48 additions and 14 deletions
@@ -9,7 +9,11 @@ import {
import { isTimelineIgnoredElement } from "./timelineElementHelpers";
import { computeResizePreview } from "../components/timelineClipDragPreview";
import type { TimelineElement } from "../store/playerStore";
import { readMediaOffsetSeconds } from "@hyperframes/parsers/media-duration";
import {
MAX_PLAYBACK_RATE,
MIN_PLAYBACK_RATE,
readMediaOffsetSeconds,
} from "@hyperframes/parsers/media-duration";
function el(id: string, extra: Partial<TimelineElement> = {}): TimelineElement {
return { id, tag: "img", start: 0, duration: 5, track: 0, ...extra };
@@ -269,19 +273,49 @@ describe("group info cache", () => {
describe("parseTimelineFromDOM — canonical playback rate", () => {
it.each([
["10", 5],
["0.01", 0.1],
])("clamps authored rate %s to %s for trim and split math", (authored, expected) => {
const doc = makeDoc(`
["8", 8],
["10", MAX_PLAYBACK_RATE],
["50", MAX_PLAYBACK_RATE],
["0.01", MIN_PLAYBACK_RATE],
])(
"clamps authored rate %s to %s, as playback does, for trim and split math",
(authored, expected) => {
const doc = makeDoc(`
<div data-composition-id="root">
<div id="nested" class="clip" data-composition-src="scene.html"
data-start="0" data-duration="5" data-playback-rate="${authored}"></div>
</div>
`);
const nested = parseTimelineFromDOM(doc, 10).find((entry) => entry.domId === "nested");
const nested = parseTimelineFromDOM(doc, 10).find((entry) => entry.domId === "nested");
expect(nested?.playbackRate).toBe(expected);
expect(nested?.playbackRate).toBe(expected);
},
);
});
describe("parseTimelineFromDOM — head trim at an authored speed above 5x", () => {
it("moves the in-point by the speed playback uses", () => {
const doc = makeDoc(`
<div data-composition-id="root">
<video id="v" class="clip" data-start="2" data-duration="4" data-media-start="1"
data-playback-rate="8"></video>
</div>
`);
const element = parseTimelineFromDOM(doc, 10).find((e) => e.domId === "v")!;
const preview = computeResizePreview(
{
element,
edge: "start",
originClientX: 0,
previewStart: 2,
previewDuration: 4,
started: true,
},
100,
{ scroll: null, pps: 100, buildSnapTargets: () => [] },
);
expect([preview.previewStart, preview.previewPlaybackStart]).toEqual([3, 9]);
});
});
@@ -13,7 +13,11 @@ import { isFinitePositive } from "./playbackAdapter";
import { getSourceScopedSelectorIndex } from "../../utils/sourceScopedSelectorIndex";
import { HF_AUDIO_GROUP_TAG } from "@hyperframes/core/audio-groups";
import { readElementFades } from "@hyperframes/core/audio-fade";
import { type AttrReader, readMediaOffsetSeconds } from "@hyperframes/parsers/media-duration";
import {
type AttrReader,
clampPlaybackRate,
readMediaOffsetSeconds,
} from "@hyperframes/parsers/media-duration";
// ---------------------------------------------------------------------------
// Layer-reveal lift transparency
@@ -79,10 +83,6 @@ function readDurationAttribute(el: Element | null | undefined): number {
return isFinitePositive(duration) ? duration : 0;
}
function normalizePlaybackRate(raw: number): number {
return Number.isFinite(raw) && raw > 0 ? Math.max(0.1, Math.min(5, raw)) : 1;
}
export function isTimelineIgnoredElement(el: Element): boolean {
// An `<hf-audio-group>` is a mixer bus with no timing of its own, drawn as a group row, never a clip.
if (el.tagName.toLowerCase() === HF_AUDIO_GROUP_TAG) return true;
@@ -199,7 +199,7 @@ function applyPlaybackMetadataFromElement(entry: TimelineElement, el: Element):
const authoredPlaybackRate = Number.parseFloat(el.getAttribute("data-playback-rate") ?? "");
if (Number.isFinite(authoredPlaybackRate) && authoredPlaybackRate > 0) {
entry.playbackRate = normalizePlaybackRate(authoredPlaybackRate);
entry.playbackRate = clampPlaybackRate(authoredPlaybackRate);
}
}
@@ -262,7 +262,7 @@ export function applyMediaMetadataFromElement(entry: TimelineElement, el: Elemen
const playbackRate = mediaEl.defaultPlaybackRate;
if (entry.playbackRate == null && Number.isFinite(playbackRate) && playbackRate > 0) {
entry.playbackRate = normalizePlaybackRate(playbackRate);
entry.playbackRate = clampPlaybackRate(playbackRate);
}
}