From 5a3b76a218de4a70f83d1badd76e05b697357155 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel?= Date: Sun, 24 May 2026 17:09:57 -0400 Subject: [PATCH] fix: parse scripted volume probes with html parser --- .../producer/src/services/render/stages/probeStage.test.ts | 4 ++++ packages/producer/src/services/render/stages/probeStage.ts | 6 ++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/producer/src/services/render/stages/probeStage.test.ts b/packages/producer/src/services/render/stages/probeStage.test.ts index e26416b253..f06be2c41b 100644 --- a/packages/producer/src/services/render/stages/probeStage.test.ts +++ b/packages/producer/src/services/render/stages/probeStage.test.ts @@ -21,6 +21,10 @@ describe("hasScriptedAudioVolumeAutomation", () => { ).toBe(true); }); + it("parses script tags with whitespace before the closing bracket", () => { + expect(hasScriptedAudioVolumeAutomation(``, 1)).toBe(true); + }); + it("requires audio metadata", () => { expect( hasScriptedAudioVolumeAutomation(``, 0), diff --git a/packages/producer/src/services/render/stages/probeStage.ts b/packages/producer/src/services/render/stages/probeStage.ts index c67333fdf8..4a370bd624 100644 --- a/packages/producer/src/services/render/stages/probeStage.ts +++ b/packages/producer/src/services/render/stages/probeStage.ts @@ -28,6 +28,7 @@ */ import { join } from "node:path"; +import { parseHTML } from "linkedom"; import { type CaptureOptions, type CaptureSession, @@ -91,8 +92,9 @@ export interface ProbeStageResult { export function hasScriptedAudioVolumeAutomation(html: string, audioCount: number): boolean { if (audioCount <= 0) return false; - const scriptBodies = [...html.matchAll(/]*>([\s\S]*?)<\/script>/gi)] - .map((match) => match[1] ?? "") + const { document } = parseHTML(html); + const scriptBodies = [...document.querySelectorAll("script")] + .map((script) => script.textContent ?? "") .join("\n"); if (!scriptBodies) return false;