mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-18 07:50:13 +00:00
fix(ci): a release fails its checks when its notes miss a commit merged after the cut (#7601)
* fix(ci): a release fails its checks when its notes miss a commit merged after the cut * fix(ci): shorten the release checks comment * fix(ci): find the last release by subject and say to link a deliberate omission
This commit is contained in:
@@ -4,7 +4,10 @@ description: >-
|
||||
can skip it. Main and the merge queue never skip. Needs a checkout with full history.
|
||||
outputs:
|
||||
release_only:
|
||||
description: "'true' when every changed file is a version bump, release note or changelog entry."
|
||||
description: "'true' when a pull request changes only version bumps, release notes and the changelog entry. Always 'false' elsewhere."
|
||||
value: ${{ github.event_name == 'pull_request' && steps.diff.outputs.release_only || 'false' }}
|
||||
release_diff:
|
||||
description: "'true' when the commit changes only a release's own files, in a pull request or the merge queue."
|
||||
value: ${{ steps.diff.outputs.release_only }}
|
||||
runs:
|
||||
using: composite
|
||||
@@ -12,7 +15,7 @@ runs:
|
||||
- id: diff
|
||||
shell: bash
|
||||
run: |
|
||||
if [ "${{ github.event_name }}" = pull_request ]; then
|
||||
if [ "${{ github.event_name }}" = pull_request ] || [ "${{ github.event_name }}" = merge_group ]; then
|
||||
node scripts/ci/release-only-diff.mjs
|
||||
else
|
||||
echo "release_only=false" >> "$GITHUB_OUTPUT"
|
||||
|
||||
@@ -73,6 +73,7 @@ jobs:
|
||||
pull-requests: read
|
||||
outputs:
|
||||
release_only: ${{ steps.release.outputs.release_only }}
|
||||
release_diff: ${{ steps.release.outputs.release_diff }}
|
||||
code: ${{ (github.event_name == 'workflow_dispatch' && inputs.catalog_publish) && 'true' || steps.release.outputs.release_only == 'true' && 'false' || steps.filter.outputs.code }}
|
||||
docs_catalog: ${{ steps.filter.outputs.docs_catalog }}
|
||||
cli: ${{ steps.release.outputs.release_only == 'true' && 'false' || steps.filter.outputs.cli }}
|
||||
@@ -272,7 +273,8 @@ jobs:
|
||||
release-checks:
|
||||
name: Release checks
|
||||
needs: changes
|
||||
if: ${{ needs.changes.outputs.release_only == 'true' }}
|
||||
# The queue also runs this on a release, so a commit merged after the notes were drafted fails here.
|
||||
if: ${{ (github.event_name == 'merge_group' && needs.changes.outputs.release_diff == 'true') || needs.changes.outputs.release_only == 'true' }}
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 4
|
||||
steps:
|
||||
|
||||
Reference in New Issue
Block a user