ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-03 04:38:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(studio): tighten media decode filter with error_name + sampled counter

Browse Source 
Address review feedback:
- AND with error_name === "EncodingError" for tighter filtering
- Add sampled composition_asset_error_filtered tracking event (fires on
  1st occurrence, then every 100th) so filtered errors aren't completely
  invisible in telemetry
This commit is contained in:
Miguel Ángel
2026-05-25 12:55:41 -04:00
parent 87cffb6904
commit 5fe62fc924
1 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/studio/src/main.tsx
+16 -3
View File
@@ -23,10 +23,10 @@ function errorProps(value: unknown): {
}
// fallow-ignore-next-line complexity
function isCompositionAssetError(msg: string): boolean {
function isCompositionAssetError(msg: string, name: string | null): boolean {
if (msg.includes("Error fetching") && (msg.includes("404") || msg.includes("Not Found")))
return true;
if (msg.includes("unsupported or unrecognizable format")) return true;
if (name === "EncodingError" || msg.includes("unsupported or unrecognizable format")) return true;
if (msg.includes("MEDIA_ERR_SRC_NOT_SUPPORTED")) return true;
return false;
}
@@ -62,9 +62,22 @@ window.addEventListener("error", (event) => {
});
});
let filteredAssetErrorCount = 0;
// fallow-ignore-next-line complexity
window.addEventListener("unhandledrejection", (event) => {
const props = errorProps(event.reason);
if (isCompositionAssetError(props.error_message)) return;
if (isCompositionAssetError(props.error_message, props.error_name)) {
filteredAssetErrorCount++;
if (filteredAssetErrorCount === 1 || filteredAssetErrorCount % 100 === 0) {
trackStudioEvent("composition_asset_error_filtered", {
error_message: props.error_message.slice(0, 200),
error_name: props.error_name,
total_filtered: filteredAssetErrorCount,
});
}
return;
}
rejectionCount++;
if (rejectionCount > ERROR_CAP) {