From 61c7e4ab743a3dbe4e0bdfa6caec87911a43fdb6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel?= Date: Sat, 23 May 2026 16:08:27 -0400 Subject: [PATCH] fix(producer): address review feedback on htmlInCanvas worker clamp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Always log when html-in-canvas pins to 1 worker, not just on explicit --workers override (Vance, James) - Assert recommendScreenshot is true for htmlInCanvas detection — pins the load-bearing coupling with the screenshot paint-force protocol (Vance, Magi) - Skip capture calibration for htmlInCanvas auto-sized renders to avoid wasting 600ms–3s on an estimate that gets thrown away (Vance) - Add TODO documenting Chrome's two root-cause mechanisms: paint cache race and SwiftShader contention (James, Magi) --- .../producer/src/services/htmlCompiler.test.ts | 1 + .../producer/src/services/render/captureCost.ts | 15 +++++++++------ .../src/services/renderOrchestrator.test.ts | 1 + .../producer/src/services/renderOrchestrator.ts | 5 ++++- 4 files changed, 15 insertions(+), 7 deletions(-) diff --git a/packages/producer/src/services/htmlCompiler.test.ts b/packages/producer/src/services/htmlCompiler.test.ts index 386ae9c5be..04d363465c 100644 --- a/packages/producer/src/services/htmlCompiler.test.ts +++ b/packages/producer/src/services/htmlCompiler.test.ts @@ -426,6 +426,7 @@ describe("detectRenderModeHints", () => { const result = detectRenderModeHints(html); expect(result.reasons.map((reason) => reason.code)).toContain("htmlInCanvas"); + expect(result.recommendScreenshot).toBe(true); }); it("does not flag htmlInCanvas for plain canvas elements without layoutsubtree", () => { diff --git a/packages/producer/src/services/render/captureCost.ts b/packages/producer/src/services/render/captureCost.ts index e01a6f6f4f..2ca5520743 100644 --- a/packages/producer/src/services/render/captureCost.ts +++ b/packages/producer/src/services/render/captureCost.ts @@ -114,14 +114,17 @@ export function resolveRenderWorkerCount( log: ProducerLogger = defaultLogger, measuredCaptureCost?: CaptureCostEstimate, ): number { + // TODO(htmlInCanvas): workaround — Chrome's experimental drawElementImage + // API (CanvasDrawElement) is non-deterministic across concurrent browser + // instances due to paint-cache races and SwiftShader contention. + // Remove this clamp once Chromium stabilizes CanvasDrawElement for + // concurrent use. const reasonCodes = new Set(compiled.renderModeHints.reasons.map((r) => r.code)); if (reasonCodes.has("htmlInCanvas")) { - if (requestedWorkers !== undefined && requestedWorkers > 1) { - log.warn( - "[Render] html-in-canvas (drawElementImage) detected — overriding --workers to 1. " + - "Chrome does not support concurrent drawElementImage across multiple workers and produces flickering artifacts.", - ); - } + log.warn( + "[Render] html-in-canvas (drawElementImage) detected — pinning to 1 worker (Chrome concurrency limitation).", + { requestedWorkers }, + ); return 1; } diff --git a/packages/producer/src/services/renderOrchestrator.test.ts b/packages/producer/src/services/renderOrchestrator.test.ts index c515dea822..e18f213616 100644 --- a/packages/producer/src/services/renderOrchestrator.test.ts +++ b/packages/producer/src/services/renderOrchestrator.test.ts @@ -584,6 +584,7 @@ describe("resolveRenderWorkerCount", () => { ); expect(workers).toBe(1); + expect(log.warn).toHaveBeenCalledOnce(); }); it("overrides explicit --workers when html-in-canvas is detected", () => { diff --git a/packages/producer/src/services/renderOrchestrator.ts b/packages/producer/src/services/renderOrchestrator.ts index a8eaadc7a6..836a1a573d 100644 --- a/packages/producer/src/services/renderOrchestrator.ts +++ b/packages/producer/src/services/renderOrchestrator.ts @@ -1699,7 +1699,10 @@ export async function executeRenderJob( } | undefined; - if (job.config.workers === undefined && totalFrames >= 60) { + const htmlInCanvasDetected = compiled.renderModeHints.reasons.some( + (r) => r.code === "htmlInCanvas", + ); + if (job.config.workers === undefined && totalFrames >= 60 && !htmlInCanvasDetected) { const outcome = await runCaptureCalibration({ cfg, fileServer,