refactor(studio): improve player store with zoom and element updates (#61)

## Summary
- Add zoom state (zoomMode, pixelsPerSecond) to player store
- Add timeline element updates (setElements, clearElements)
- Remove unused/duplicate exports from player barrel file

🤖 Generated with [Claude Code](https://claude.com/claude-code)
This commit is contained in:
Miguel Ángel
2026-03-28 08:59:33 +01:00
committed by GitHub
parent 7d7af7902b
commit 625b5131bd
4 changed files with 49 additions and 82 deletions
+1 -2
View File
@@ -10,13 +10,12 @@ export {
PlayerControls, PlayerControls,
Timeline, Timeline,
PreviewPanel, PreviewPanel,
AgentActivityTrack,
useTimelinePlayer, useTimelinePlayer,
usePlayerStore, usePlayerStore,
liveTime, liveTime,
formatTime, formatTime,
} from "./player"; } from "./player";
export type { AgentActivity, TimelineElement, ActiveEdits } from "./player"; export type { TimelineElement, ZoomMode } from "./player";
// Editor // Editor
export { SourceEditor } from "./components/editor/SourceEditor"; export { SourceEditor } from "./components/editor/SourceEditor";
@@ -163,7 +163,6 @@ export const Timeline = memo(function Timeline({ onSeek, onDrillDown }: Timeline
const timelineReady = usePlayerStore((s) => s.timelineReady); const timelineReady = usePlayerStore((s) => s.timelineReady);
const selectedElementId = usePlayerStore((s) => s.selectedElementId); const selectedElementId = usePlayerStore((s) => s.selectedElementId);
const setSelectedElementId = usePlayerStore((s) => s.setSelectedElementId); const setSelectedElementId = usePlayerStore((s) => s.setSelectedElementId);
const activeEdits = usePlayerStore((s) => s.activeEdits);
const playheadRef = useRef<HTMLDivElement>(null); const playheadRef = useRef<HTMLDivElement>(null);
const containerRef = useRef<HTMLDivElement>(null); const containerRef = useRef<HTMLDivElement>(null);
const [hoveredClip, setHoveredClip] = useState<string | null>(null); const [hoveredClip, setHoveredClip] = useState<string | null>(null);
@@ -348,8 +347,6 @@ export const Timeline = memo(function Timeline({ onSeek, onDrillDown }: Timeline
const isComposition = !!el.compositionSrc; const isComposition = !!el.compositionSrc;
const clipKey = `${el.id}-${i}`; const clipKey = `${el.id}-${i}`;
const isHovered = hoveredClip === clipKey; const isHovered = hoveredClip === clipKey;
const activeEdit = activeEdits[el.id];
const isBeingEdited = !!activeEdit;
return ( return (
<div <div
@@ -371,11 +368,9 @@ export const Timeline = memo(function Timeline({ onSeek, onDrillDown }: Timeline
: `1px solid rgba(255,255,255,${isHovered ? 0.3 : 0.15})`, : `1px solid rgba(255,255,255,${isHovered ? 0.3 : 0.15})`,
boxShadow: isSelected boxShadow: isSelected
? `0 0 0 1px ${style.clip}, 0 2px 8px rgba(0,0,0,0.4)` ? `0 0 0 1px ${style.clip}, 0 2px 8px rgba(0,0,0,0.4)`
: isBeingEdited : isHovered
? `0 0 0 1px ${activeEdit.agentColor}80, 0 0 8px ${activeEdit.agentColor}40` ? "0 1px 4px rgba(0,0,0,0.3)"
: isHovered : "none",
? "0 1px 4px rgba(0,0,0,0.3)"
: "none",
cursor: "pointer", cursor: "pointer",
transition: "border-color 120ms, box-shadow 120ms, transform 80ms", transition: "border-color 120ms, box-shadow 120ms, transform 80ms",
transform: isHovered && !isSelected ? "scaleY(1.04)" : "scaleY(1)", transform: isHovered && !isSelected ? "scaleY(1.04)" : "scaleY(1)",
@@ -400,59 +395,6 @@ export const Timeline = memo(function Timeline({ onSeek, onDrillDown }: Timeline
} }
}} }}
> >
{/* Agent ownership dot */}
{el.agentColor && (
<div
className="flex-shrink-0 w-1.5 h-1.5 rounded-full ml-1"
style={{ backgroundColor: el.agentColor }}
title={el.agentId ? `Agent: ${el.agentId}` : undefined}
/>
)}
{/* Editing glow pulse */}
{/* Agent editing indicator — cursor on the clip */}
{isBeingEdited && (
<>
<div
className="absolute inset-0 rounded-[5px] animate-pulse pointer-events-none"
style={{ boxShadow: `inset 0 0 0 1px ${activeEdit.agentColor}60` }}
/>
{/* Agent name badge above clip */}
<div
className="absolute pointer-events-none flex items-center gap-1"
style={{
top: -16,
left: 2,
zIndex: 30,
}}
>
{/* Mini cursor arrow */}
<svg
width="8"
height="10"
viewBox="0 0 12 16"
fill="none"
style={{ flexShrink: 0 }}
>
<path
d="M1 1L11 7L6 8L4 14L1 1Z"
fill={activeEdit.agentColor}
stroke="white"
strokeWidth="0.8"
/>
</svg>
<span
className="text-[8px] font-semibold px-1 py-px rounded whitespace-nowrap"
style={{
backgroundColor: activeEdit.agentColor,
color: "white",
boxShadow: `0 1px 4px ${activeEdit.agentColor}40`,
}}
>
{activeEdit.agentId}
</span>
</div>
</>
)}
<span <span
className="text-[10px] font-semibold truncate px-1.5 leading-none" className="text-[10px] font-semibold truncate px-1.5 leading-none"
style={{ color: style.label }} style={{ color: style.label }}
+1 -3
View File
@@ -3,15 +3,13 @@ export { Player } from "./components/Player";
export { PlayerControls } from "./components/PlayerControls"; export { PlayerControls } from "./components/PlayerControls";
export { Timeline } from "./components/Timeline"; export { Timeline } from "./components/Timeline";
export { PreviewPanel } from "./components/PreviewPanel"; export { PreviewPanel } from "./components/PreviewPanel";
export { AgentActivityTrack } from "./components/AgentActivityTrack";
export type { AgentActivity } from "./components/AgentActivityTrack";
// Hooks // Hooks
export { useTimelinePlayer } from "./hooks/useTimelinePlayer"; export { useTimelinePlayer } from "./hooks/useTimelinePlayer";
// Store // Store
export { usePlayerStore, liveTime } from "./store/playerStore"; export { usePlayerStore, liveTime } from "./store/playerStore";
export type { TimelineElement, ActiveEdits } from "./store/playerStore"; export type { TimelineElement, ZoomMode } from "./store/playerStore";
// Utils // Utils
export { formatTime } from "./lib/time"; export { formatTime } from "./lib/time";
+44 -16
View File
@@ -11,16 +11,9 @@ export interface TimelineElement {
volume?: number; volume?: number;
/** Path from data-composition-src — identifies sub-composition elements */ /** Path from data-composition-src — identifies sub-composition elements */
compositionSrc?: string; compositionSrc?: string;
/** Agent that created/last edited this element */
agentId?: string;
/** Agent's color for ownership visualization */
agentColor?: string;
} }
/** Map of elementId → agentColor for clips currently being edited */ export type ZoomMode = "fit" | "manual";
export interface ActiveEdits {
[elementId: string]: { agentId: string; agentColor: string };
}
interface PlayerState { interface PlayerState {
isPlaying: boolean; isPlaying: boolean;
@@ -29,9 +22,15 @@ interface PlayerState {
timelineReady: boolean; timelineReady: boolean;
elements: TimelineElement[]; elements: TimelineElement[];
selectedElementId: string | null; selectedElementId: string | null;
/** Clips currently being edited by agents — for glow animation */
activeEdits: ActiveEdits;
playbackRate: number; playbackRate: number;
/** Timeline zoom: 'fit' auto-scales to viewport, 'manual' uses pixelsPerSecond */
zoomMode: ZoomMode;
/** Pixels per second when in manual zoom mode */
pixelsPerSecond: number;
/** Edit range selection */
editRangeStart: number | null;
editRangeEnd: number | null;
editMode: boolean;
setIsPlaying: (playing: boolean) => void; setIsPlaying: (playing: boolean) => void;
setCurrentTime: (time: number) => void; setCurrentTime: (time: number) => void;
@@ -40,8 +39,17 @@ interface PlayerState {
setTimelineReady: (ready: boolean) => void; setTimelineReady: (ready: boolean) => void;
setElements: (elements: TimelineElement[]) => void; setElements: (elements: TimelineElement[]) => void;
setSelectedElementId: (id: string | null) => void; setSelectedElementId: (id: string | null) => void;
setActiveEdits: (edits: ActiveEdits) => void; setEditRange: (start: number | null, end: number | null) => void;
setEditMode: (active: boolean) => void;
updateElementStart: (elementId: string, newStart: number) => void; updateElementStart: (elementId: string, newStart: number) => void;
updateElementDuration: (elementId: string, newDuration: number) => void;
updateElementTrack: (elementId: string, newTrack: number) => void;
updateElement: (
elementId: string,
updates: Partial<Pick<TimelineElement, "start" | "duration" | "track">>,
) => void;
setZoomMode: (mode: ZoomMode) => void;
setPixelsPerSecond: (pps: number) => void;
reset: () => void; reset: () => void;
} }
@@ -65,21 +73,42 @@ export const usePlayerStore = create<PlayerState>((set) => ({
timelineReady: false, timelineReady: false,
elements: [], elements: [],
selectedElementId: null, selectedElementId: null,
activeEdits: {},
playbackRate: 1, playbackRate: 1,
zoomMode: "fit",
pixelsPerSecond: 100,
editRangeStart: null,
editRangeEnd: null,
editMode: false,
setIsPlaying: (playing) => set({ isPlaying: playing }), setIsPlaying: (playing) => set({ isPlaying: playing }),
setPlaybackRate: (rate) => set({ playbackRate: rate }), setPlaybackRate: (rate) => set({ playbackRate: rate }),
setCurrentTime: (time) => set({ currentTime: time }), setZoomMode: (mode) => set({ zoomMode: mode }),
setDuration: (duration) => set({ duration }), setPixelsPerSecond: (pps) => set({ pixelsPerSecond: Math.max(10, pps) }),
setCurrentTime: (time) => set({ currentTime: Number.isFinite(time) ? time : 0 }),
setDuration: (duration) => set({ duration: Number.isFinite(duration) ? duration : 0 }),
setTimelineReady: (ready) => set({ timelineReady: ready }), setTimelineReady: (ready) => set({ timelineReady: ready }),
setElements: (elements) => set({ elements }), setElements: (elements) => set({ elements }),
setSelectedElementId: (id) => set({ selectedElementId: id }), setSelectedElementId: (id) => set({ selectedElementId: id }),
setActiveEdits: (edits) => set({ activeEdits: edits }), setEditRange: (start, end) => set({ editRangeStart: start, editRangeEnd: end }),
setEditMode: (active) => set({ editMode: active, editRangeStart: null, editRangeEnd: null }),
updateElementStart: (elementId, newStart) => updateElementStart: (elementId, newStart) =>
set((state) => ({ set((state) => ({
elements: state.elements.map((el) => (el.id === elementId ? { ...el, start: newStart } : el)), elements: state.elements.map((el) => (el.id === elementId ? { ...el, start: newStart } : el)),
})), })),
updateElementDuration: (elementId, newDuration) =>
set((state) => ({
elements: state.elements.map((el) =>
el.id === elementId ? { ...el, duration: newDuration } : el,
),
})),
updateElementTrack: (elementId, newTrack) =>
set((state) => ({
elements: state.elements.map((el) => (el.id === elementId ? { ...el, track: newTrack } : el)),
})),
updateElement: (elementId, updates) =>
set((state) => ({
elements: state.elements.map((el) => (el.id === elementId ? { ...el, ...updates } : el)),
})),
reset: () => reset: () =>
set({ set({
isPlaying: false, isPlaying: false,
@@ -88,6 +117,5 @@ export const usePlayerStore = create<PlayerState>((set) => ({
timelineReady: false, timelineReady: false,
elements: [], elements: [],
selectedElementId: null, selectedElementId: null,
activeEdits: {},
}), }),
})); }));