ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-01 19:42:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(engine): warn once per process about unverified hardware GPU

Browse Source
This commit is contained in:
Miguel Angel Simon Sierra
2026-08-04 11:04:35 -07:00
parent 131780fe96
commit 6703ea7e04
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/engine/src/services/browserManager.test.ts
+5
View File
@@ -261,6 +261,11 @@ describe("resolveBrowserGpuMode", () => {
const warning = warn.mock.calls.map((call) => String(call[0])).join("\n");
expect(warning).toContain("browserGpuMode=hardware was requested");
expect(warning).toContain("--gpus all");
// Once per process, not once per worker — the render path resolves the
// mode for the probe browser plus every parallel worker.
await resolveBrowserGpuMode("hardware", { platform: "linux" });
await resolveBrowserGpuMode("hardware", { platform: "linux" });
expect(warn).toHaveBeenCalledTimes(1);
});
it("stays quiet when explicit 'hardware' probes to hardware", async () => {
packages/engine/src/services/browserManager.ts
+9 -1
View File
@@ -438,6 +438,7 @@ let _autoBrowserGpuModeCache: Promise<"software" | "hardware"> | undefined;
/** Test-only: reset the cached probe result. */
export function _resetAutoBrowserGpuModeCacheForTests(): void {
_autoBrowserGpuModeCache = undefined;
_unverifiedHardwareGpuWarned = false;
}
async function getPuppeteerOrNull(): Promise<PuppeteerNode | null> {
@@ -544,13 +545,20 @@ export function resolveBrowserGpuMode(
if (mode === "auto") return _autoBrowserGpuModeCache;
return _autoBrowserGpuModeCache.then((probed) => {
if (probed === "software") {
// Warn once per process, not once per caller: `createCaptureSession`
// resolves the mode for the probe browser AND every parallel worker, so
// an un-deduplicated warning prints N+1 times and buries itself.
if (probed === "software" && !_unverifiedHardwareGpuWarned) {
_unverifiedHardwareGpuWarned = true;
console.warn(buildUnverifiedHardwareGpuWarning(options.platform ?? process.platform));
}
return "hardware";
});
}
/** One-shot latch for the explicit-hardware-probed-to-software warning. */
let _unverifiedHardwareGpuWarned = false;
/**
* Warning text for "you asked for hardware GPU, the probe found none".
*