ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-08 02:36:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): address review — clip-duration audit in check, failure classing, crop observability

Browse Source 
Port validate's per-media-element clip audit into check's session
(clip_media_fit findings): an intrinsic duration meaningfully shorter
than the data-duration slot silently shortens the slot at render time,
and neither lint nor the runtime listeners can see it. A linter crash
now reports as check_lint_failure instead of masquerading as a runtime
failure. Finding-crop capture failures stay non-gating but emit a
stderr note and a telemetry error event so rollouts can measure the
second-session failure rate.
This commit is contained in:
Miguel Angel Simon Sierra
2026-07-10 17:53:04 -04:00
parent 96cb5e39dd
commit 67cdf0fdb7
4 changed files with 61 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/utils/checkBrowser.ts
+10 -1
View File
@@ -12,7 +12,7 @@ import {
seekCompositionTimeline,
waitForPreferredSeekTarget,
} from "../capture/captureCompositionFrame.js";
import { shouldIgnoreRequestFailure } from "../commands/validate.js";
import { auditClipDurations, shouldIgnoreRequestFailure } from "../commands/validate.js";
import { loadBrowserScript } from "../commands/layout.js";
import { normalizeErrorMessage } from "./errorMessage.js";
import { ambiguousIssue, type MotionFrame } from "./motionAudit.js";
@@ -109,6 +109,15 @@ export async function runBrowserCheck(
const rootAnchor = await resolveRootAnchor(page);
const launchSettleMs = Date.now() - launchSettleStart;
// validate's per-media-element audit, kept in the consolidation: a clip
// whose intrinsic duration is meaningfully shorter than its data-duration
// slot silently shortens the slot at render time — invisible to lint (no
// intrinsic durations statically) and to the runtime listeners (nothing
// errors). The session is already open, so this is one extra evaluate.
const { analyzeClipMediaFit } = await import("@hyperframes/engine");
for (const entry of await auditClipDurations(page, analyzeClipMediaFit, options.timeout)) {
drafts.push({ code: "clip_media_fit", severity: entry.level, message: entry.text, time: 0 });
}
const driver = createPageDriver(page, (time) => {
currentTime = time;
});