From 6e0118cb3f5adf43bec8ee08bac89a164b480328 Mon Sep 17 00:00:00 2001 From: Miguel Angel Simon Sierra Date: Sun, 26 Jul 2026 00:57:53 +0200 Subject: [PATCH] refactor(studio): guard the diamond connector's previous keyframe CONTRIBUTING.md asks for a guard clause rather than a non-null assertion outside an already-checked path. The index check and the lookup are now the same guard. --- .../studio/src/player/components/TimelineClipDiamonds.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/studio/src/player/components/TimelineClipDiamonds.tsx b/packages/studio/src/player/components/TimelineClipDiamonds.tsx index 37510955b..a592a4db5 100644 --- a/packages/studio/src/player/components/TimelineClipDiamonds.tsx +++ b/packages/studio/src/player/components/TimelineClipDiamonds.tsx @@ -239,8 +239,8 @@ export const TimelineDiamondLane = memo(function TimelineDiamondLane({ }} > {sorted.map((kf, i) => { - if (i === 0) return null; - const prev = sorted[i - 1]!; + const prev = sorted[i - 1]; + if (!prev) return null; const x1 = Math.max(0, Math.min(clipWidthPx, (prev.percentage / 100) * clipWidthPx)); const x2 = Math.max(0, Math.min(clipWidthPx, (kf.percentage / 100) * clipWidthPx)); if (x2 - x1 < 1) return null;