ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-11 23:00:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): scope skill installs to relevant agents, not all ~70 via --all (#1748)

Browse Source 
`hyperframes skills`, `skills update`, and `init` all shelled out to
`skills add ... --all`, which the upstream CLI expands to
`--skill '*' --agent '*' -y` — every skill into every one of the ~70 agent
conventions it knows about. A user who only runs Claude Code got skill
folders for Cursor, Codex, and 50+ tools they never touch.

Replace `--all` with a resolved target set (new resolveAgentTargets):

  1. If the project already has agent skill folders (`.claude/skills`,
     `.hermes/skills`, …), install ONLY to those — an existing folder is the
     strongest signal of intent, so honour it exactly.
  2. Otherwise (blank project):
     a. Running under Claude Code (CLAUDECODE) → just claude-code.
     b. Else probe PATH for installed agent CLIs (claude, hermes, droid,
        cursor, codex, opencode, gemini) — the gstack approach.
     c. Else fall back to claude-code + the shared `.agents` universal dir,
        which Cursor, Codex, OpenCode, Gemini, Copilot and ~14 others read
        from in project scope. Never `--agent '*'`.

Installs stay `--skill '*'` (all skills) + `--copy` (faithful, detectable by
`skills check`); only the agent fan-out is scoped. The dir<->key map is
explicit because dir names differ from upstream keys (`.factory`/droid,
`.hermes`/hermes-agent) and many agents share `.agents` (-> the single
`universal` key). Keys verified against vercel-labs/skills@v1.5.13.

Verified end-to-end in an isolated project + HOME: the new args land exactly
`.claude/skills` (19) + `.agents/skills` (19) and nothing else — 2 folders,
not 50+. Pure resolver covered by skillsTargets.test.ts; command-arg shape and
the "never --all" regression pinned in skills.test.ts.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
WaterrrForever
2026-06-27 03:45:33 +08:00
committed by GitHub
co-authored by Claude Opus 4.8
parent 05af482f22
commit 70a03f788b
5 changed files with 373 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/commands/init.ts
+6 -7
View File
@@ -584,12 +584,6 @@ async function scaffoldProject(
async function ensureSkillsCurrent(destDir: string): Promise<void> {
const { installAllSkills } = await import("./skills.js");
const { checkSkills } = await import("../utils/skillsManifest.js");
// --all pulls every skill (incl. ones not yet installed); --yes keeps it
// non-interactive. When Claude Code is driving, target its native dir so
// skills land in .claude/skills/.
const extraArgs = process.env["CLAUDECODE"]
? ["--all", "--agent", "claude-code", "--yes"]
: ["--all", "--yes"];
console.log();
console.log(c.bold("Checking AI coding skills against GitHub..."));
@@ -602,7 +596,12 @@ async function ensureSkillsCurrent(destDir: string): Promise<void> {
}
if (needsInstall) {
await installAllSkills({ cwd: destDir, extraArgs });
// installAllSkills resolves the agent target set from destDir + the
// environment (Claude Code → claude-code; otherwise installed CLIs, else a
// Claude-Code + `.agents` floor). A freshly-scaffolded project has no agent
// folders yet, so this lands skills where the running agent will read them
// rather than spraying to every agent convention.
await installAllSkills({ cwd: destDir });
} else {
console.log(c.success("AI coding skills are already up to date."));
}