From 81f89b81504bd37caedd52512972ec2aa5349f91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel?= Date: Wed, 18 Nov 2026 22:57:06 +0000 Subject: [PATCH] fix(studio): a sealed preview shows its loading overlay while media still loads (#8184) * test(studio): a sealed preview keeps its loading overlay while media buffers * fix(studio): a sealed preview's loading overlay waits for its media through the editing port * fix(studio): Studio never calls a preview ready before its asset check has answered * refactor(studio): the preview asset wait lives outside the Player component * refactor(studio): the preview asset wait moves to its own file, out of the Player * refactor(studio): one asset-wait state; a sealed frame's first check is its own value * fix(studio): a sealed preview's missing asset answer is asked again, never taken as ready * fix(studio): a closed preview frees its editing-port client * style(studio): keep the client comment under the line limit --- packages/core/src/lottieReadiness.ts | 20 +++++ .../core/src/runtime/editingAgent.test.ts | 1 + packages/core/src/runtime/editingAgent.ts | 2 + packages/core/src/runtime/editingPort.test.ts | 1 + packages/core/src/runtime/editingPort.ts | 3 + .../player/components/Player.sealed.test.ts | 31 +++++++ .../src/player/components/Player.test.ts | 29 +++++-- .../studio/src/player/components/Player.tsx | 86 +++---------------- .../components/previewAssetWait.test.ts | 71 +++++++++++++++ .../src/player/components/previewAssetWait.ts | 80 +++++++++++++++++ .../studio/src/player/lib/previewChannel.ts | 24 ++++-- 11 files changed, 263 insertions(+), 85 deletions(-) create mode 100644 packages/studio/src/player/components/Player.sealed.test.ts create mode 100644 packages/studio/src/player/components/previewAssetWait.test.ts create mode 100644 packages/studio/src/player/components/previewAssetWait.ts diff --git a/packages/core/src/lottieReadiness.ts b/packages/core/src/lottieReadiness.ts index 1c16ce3fb6..77474e8ffa 100644 --- a/packages/core/src/lottieReadiness.ts +++ b/packages/core/src/lottieReadiness.ts @@ -13,3 +13,23 @@ export function isLottieAnimationLoaded(anim: unknown): boolean { if (typeof maybe.totalFrames === "number" && maybe.totalFrames > 0) return true; return false; } + +const MEDIA_HAVE_FUTURE_DATA = 3; +const MEDIA_NETWORK_NO_SOURCE = 3; + +/** Whether a preview still waits on a `