ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-05 00:56:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(engine): tune VP9 cpu-used across render paths (#1614)

Browse Source 
* fix(engine): tune VP9 cpu-used across render paths

* fix: address VP9 review feedback
This commit is contained in:
Miguel Ángel
2026-06-20 16:36:59 -04:00
committed by GitHub
parent d6135ca155
commit 8408a44745
30 changed files with 273 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/engine/src/services/chunkEncoder.test.ts
+12 -2
View File
@@ -918,7 +918,7 @@ describe("buildEncoderArgs lockGopForChunkConcat", () => {
expect(args[args.indexOf("-g") + 1]).toBe("240");
expect(args[args.indexOf("-keyint_min") + 1]).toBe("240");
expect(args[args.indexOf("-auto-alt-ref") + 1]).toBe("0");
expect(args[args.indexOf("-cpu-used") + 1]).toBe("2");
expect(args[args.indexOf("-cpu-used") + 1]).toBe("4");
expect(args[args.indexOf("-deadline") + 1]).toBe("good");
expect(args.indexOf("-x264-params")).toBe(-1);
expect(args.indexOf("-x265-params")).toBe(-1);
@@ -934,7 +934,7 @@ describe("buildEncoderArgs lockGopForChunkConcat", () => {
);
expect(args).not.toContain("-g");
expect(args).not.toContain("-keyint_min");
expect(args).not.toContain("-cpu-used");
expect(args[args.indexOf("-cpu-used") + 1]).toBe("4");
// The non-locked, non-alpha VP9 path leaves `-auto-alt-ref` at the
// libvpx default. Alpha branches still emit `-auto-alt-ref 0` for an
// unrelated reason (alpha + alt-ref is unsupported), but that's a
@@ -942,6 +942,16 @@ describe("buildEncoderArgs lockGopForChunkConcat", () => {
expect(args).not.toContain("-auto-alt-ref");
});
it("honors the resolved engine VP9 cpu-used override", () => {
const args = buildEncoderArgs(
{ ...baseOptions, codec: "vp9", preset: "good", quality: 23, vp9CpuUsed: 6 },
inputArgs,
"out.webm",
);
expect(args[args.indexOf("-cpu-used") + 1]).toBe("6");
});
it("true with alpha pixel format keeps alpha metadata and emits -auto-alt-ref once", () => {
// Regression: alpha + closed-GOP must NOT double-push `-auto-alt-ref 0`.
// Both paths want it disabled; the encoder branch emits it exactly once.