ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-03 04:38:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #977 from func25/ceil-duration-preview

Browse Source 
fix(core): ceil timeline payload duration to match render frames
This commit is contained in:
Miguel Ángel
2026-05-20 01:33:15 +02:00
committed by GitHub
parent 852008bd44 0fc3937809
commit 8f0545738c
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/runtime/timeline.test.ts
+15
View File
@@ -183,6 +183,21 @@ describe("collectRuntimeTimelinePayload", () => {
expect(result.durationInFrames).toBe(300); // 10s * 30fps
});
it("ceil durationInFrames to match render frame count", () => {
const root = document.createElement("div");
root.setAttribute("data-composition-id", "main");
root.setAttribute("data-duration", "1.01");
document.body.appendChild(root);
const clip = document.createElement("div");
clip.setAttribute("data-start", "0");
clip.setAttribute("data-duration", "1.01");
root.appendChild(clip);
const result = collectRuntimeTimelinePayload(defaultParams);
expect(result.durationInFrames).toBe(31); // ceil(1.01s * 30fps), same as render.
});
it("preserves the authored root duration when clips end earlier", () => {
const root = document.createElement("div");
root.setAttribute("data-composition-id", "main");
packages/core/src/runtime/timeline.ts
+1 -1
View File
@@ -674,7 +674,7 @@ export function collectRuntimeTimelinePayload(params: {
const shouldEmitNonDeterministicInf = timelineLooksLoopInflated && attrDurationCandidate == null;
const durationInFrames = shouldEmitNonDeterministicInf
? Number.POSITIVE_INFINITY
: Math.max(1, Math.round(safeDuration * Math.max(1, params.canonicalFps)));
: Math.max(1, Math.ceil(safeDuration * Math.max(1, params.canonicalFps)));
return {
source: "hf-preview",
type: "timeline",