From 8f73aee229f73634e40099035e982f4fc706fb1a Mon Sep 17 00:00:00 2001 From: Miguel Angel Simon Sierra Date: Fri, 26 Jun 2026 14:53:22 -0400 Subject: [PATCH] feat(studio): in-use / unused filter in the Asset tab (#13) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adds 'In use' / 'Unused' filter chips alongside the category filters, reusing the existing usedPaths (composition references) the in-use badge + used-first sort already compute. filterByUsage/countUsage extracted as pure functions + unit tested (6 vitest). Chips show only on a real used/unused split (no misleading 0s). Verified in agent-browser: Studio boots, project loads, Asset tab renders + filter path runs. Note: chip display binds to usePlayerStore.elements (same source as the existing badge); that store was empty in a synthetic dev project where the timeline is driven by the iframe __clipManifest — confirm/realign usedPaths source in real studio usage (follow-up; affects badge+sort+filter equally). --- .../src/components/sidebar/AssetsTab.test.ts | 34 ++++++++++ .../src/components/sidebar/AssetsTab.tsx | 66 ++++++++++++++++++- 2 files changed, 98 insertions(+), 2 deletions(-) create mode 100644 packages/studio/src/components/sidebar/AssetsTab.test.ts diff --git a/packages/studio/src/components/sidebar/AssetsTab.test.ts b/packages/studio/src/components/sidebar/AssetsTab.test.ts new file mode 100644 index 0000000000..fc53a4488f --- /dev/null +++ b/packages/studio/src/components/sidebar/AssetsTab.test.ts @@ -0,0 +1,34 @@ +import { describe, expect, it } from "vitest"; +import { filterByUsage, countUsage } from "./AssetsTab"; + +const assets = ["bgm.mp3", "logo.png", "orphan.wav"]; +const used = new Set(["bgm.mp3", "logo.png"]); + +describe("filterByUsage", () => { + it("returns everything for 'all'", () => { + expect(filterByUsage(assets, used, "all")).toEqual(assets); + }); + + it("keeps only referenced assets for 'used'", () => { + expect(filterByUsage(assets, used, "used")).toEqual(["bgm.mp3", "logo.png"]); + }); + + it("keeps only unreferenced assets for 'unused'", () => { + expect(filterByUsage(assets, used, "unused")).toEqual(["orphan.wav"]); + }); + + it("treats everything as unused when nothing is referenced", () => { + expect(filterByUsage(assets, new Set(), "used")).toEqual([]); + expect(filterByUsage(assets, new Set(), "unused")).toEqual(assets); + }); +}); + +describe("countUsage", () => { + it("counts used vs unused", () => { + expect(countUsage(assets, used)).toEqual({ used: 2, unused: 1 }); + }); + + it("is all-unused with an empty used set", () => { + expect(countUsage(assets, new Set())).toEqual({ used: 0, unused: 3 }); + }); +}); diff --git a/packages/studio/src/components/sidebar/AssetsTab.tsx b/packages/studio/src/components/sidebar/AssetsTab.tsx index 137ec33ad5..d0f17c1a3d 100644 --- a/packages/studio/src/components/sidebar/AssetsTab.tsx +++ b/packages/studio/src/components/sidebar/AssetsTab.tsx @@ -172,6 +172,29 @@ function ImageCard({ ); } +export type UsageFilter = "all" | "used" | "unused"; + +/** Filter assets by whether the composition references them. Pure — unit-tested. */ +export function filterByUsage( + assets: string[], + usedPaths: Set, + usageFilter: UsageFilter, +): string[] { + if (usageFilter === "used") return assets.filter((a) => usedPaths.has(a)); + if (usageFilter === "unused") return assets.filter((a) => !usedPaths.has(a)); + return assets; +} + +/** Count used vs unused over a media set. Pure — unit-tested. */ +export function countUsage( + assets: string[], + usedPaths: Set, +): { used: number; unused: number } { + let used = 0; + for (const a of assets) if (usedPaths.has(a)) used++; + return { used, unused: assets.length - used }; +} + export const AssetsTab = memo(function AssetsTab({ projectId, assets, @@ -183,6 +206,7 @@ export const AssetsTab = memo(function AssetsTab({ const [dragOver, setDragOver] = useState(false); const [copiedPath, setCopiedPath] = useState(null); const [activeFilter, setActiveFilter] = useState("all"); + const [usageFilter, setUsageFilter] = useState<"all" | "used" | "unused">("all"); const [searchQuery, setSearchQuery] = useState(""); const [manifest, setManifest] = useState< Map @@ -258,7 +282,8 @@ export const AssetsTab = memo(function AssetsTab({ }, [elements]); const mediaAssets = useMemo(() => { - const all = assets.filter((a) => MEDIA_EXT.test(a) || FONT_EXT.test(a)); + const media = assets.filter((a) => MEDIA_EXT.test(a) || FONT_EXT.test(a)); + const all = filterByUsage(media, usedPaths, usageFilter); if (!searchQuery) return all; const q = searchQuery.toLowerCase(); return all.filter((a) => { @@ -266,7 +291,7 @@ export const AssetsTab = memo(function AssetsTab({ const rec = manifest.get(a); return rec?.description?.toLowerCase().includes(q); }); - }, [assets, searchQuery, manifest]); + }, [assets, searchQuery, manifest, usageFilter, usedPaths]); const categorized = useMemo(() => { const groups: Record = { audio: [], images: [], video: [], fonts: [] }; @@ -291,6 +316,17 @@ export const AssetsTab = memo(function AssetsTab({ return c; }, [mediaAssets, categorized]); + // Usage counts over the full media set (independent of the active usage filter, + // so the chips don't show their own filtered totals). + const usageCounts = useMemo( + () => + countUsage( + assets.filter((a) => MEDIA_EXT.test(a) || FONT_EXT.test(a)), + usedPaths, + ), + [assets, usedPaths], + ); + const visibleCategories = activeFilter === "all" ? FILTER_ORDER.filter((c) => categorized[c].length > 0) @@ -405,6 +441,32 @@ export const AssetsTab = memo(function AssetsTab({ ) : null, )} + {/* Usage filter — show only assets the composition references, or only the unused ones */} + {usageCounts.used > 0 && usageCounts.unused > 0 && ( + <> +