diff --git a/packages/core/src/runtime/media.test.ts b/packages/core/src/runtime/media.test.ts index 40802e1bd4..b41ac48c76 100644 --- a/packages/core/src/runtime/media.test.ts +++ b/packages/core/src/runtime/media.test.ts @@ -1,9 +1,10 @@ // fallow-ignore-file code-duplication -import { describe, it, expect, vi, afterEach } from "vitest"; +import { describe, it, expect, vi, afterEach, onTestFinished } from "vitest"; import { mediaElementTime } from "./mediaClock"; import { evictMediaSyncState, hasMediaSyncStateForTest, + isUnplayable, primeMediaForLaterStarts, readElementPlaybackRate, readElementPlaybackStart, @@ -1052,6 +1053,48 @@ describe("syncRuntimeMedia", () => { expect(clip.el.play).not.toHaveBeenCalled(); }); + function askedToPlayAtHeader(networkState: number, play?: () => Promise) { + vi.useFakeTimers({ toFake: ["performance"] }); + onTestFinished(() => vi.useRealTimers()); + const warn = vi.spyOn(console, "warn").mockImplementation(() => {}); + onTestFinished(() => warn.mockRestore()); + const clip = createMockClip({ start: 0, end: 10 }); + clip.el.src = "/alpha.webm"; + if (play) clip.el.play = vi.fn(play); + Object.defineProperty(clip.el, "readyState", { value: 1, configurable: true }); + Object.defineProperty(clip.el, "networkState", { value: networkState, configurable: true }); + syncRuntimeMedia({ clips: [clip], timeSeconds: 1, playing: true, playbackRate: 1 }); + expect(clip.el.play).toHaveBeenCalledTimes(1); + return { el: clip.el, warn }; + } + + it("skips a clip whose fetch stopped at its header 5 s after it was asked to play", () => { + const { el, warn } = askedToPlayAtHeader(HTMLMediaElement.NETWORK_IDLE); + vi.advanceTimersByTime(4999); + expect(isUnplayable(el)).toBe(false); + vi.advanceTimersByTime(1); + expect(isUnplayable(el)).toBe(true); + expect(isUnplayable(el)).toBe(true); + expect(warn).toHaveBeenCalledTimes(1); + expect(String(warn.mock.calls[0]?.[0])).toContain("/alpha.webm"); + }); + + it("keeps waiting on a clip still loading at its header 5 s after it was asked to play", () => { + const { el, warn } = askedToPlayAtHeader(HTMLMediaElement.NETWORK_LOADING); + vi.advanceTimersByTime(60_000); + expect(isUnplayable(el)).toBe(false); + expect(warn).not.toHaveBeenCalled(); + }); + + it("keeps waiting on a clip at its header whose play() the browser refused", async () => { + const refused = () => Promise.reject(new DOMException("needs a tap", "NotAllowedError")); + const { el, warn } = askedToPlayAtHeader(HTMLMediaElement.NETWORK_IDLE, refused); + await Promise.resolve(); + vi.advanceTimersByTime(5000); + expect(isUnplayable(el)).toBe(false); + expect(warn).not.toHaveBeenCalled(); + }); + it("plays again once the element recovers (error clears)", () => { const clip = createMockClip({ start: 0, end: 10 }); Object.defineProperty(clip.el, "error", { value: { code: 4 }, configurable: true }); diff --git a/packages/core/src/runtime/media.ts b/packages/core/src/runtime/media.ts index d4afb73ec7..f42a68948b 100644 --- a/packages/core/src/runtime/media.ts +++ b/packages/core/src/runtime/media.ts @@ -208,6 +208,7 @@ const seekLoadRetried = new WeakSet(); const playRequested = new WeakSet(); const startedEarly = new WeakSet(); function markPlayRequested(el: HTMLMediaElement): void { + noteFirstPlayAsk(el); if (playRequested.has(el)) return; playRequested.add(el); const clear = () => playRequested.delete(el); @@ -229,10 +230,48 @@ export function primeMediaForLaterStarts(els: Iterable): void // HTMLMediaElement.NETWORK_NO_SOURCE — no usable source (404 / unsupported). const MEDIA_NETWORK_NO_SOURCE = 3; -// An element that errored or has no source can't play; re-issuing play() every -// tick just floods rejections. Skip it until its state changes (src reload). +const MEDIA_NETWORK_IDLE = 1; +const MEDIA_HAVE_METADATA = 1; +const STOPPED_AT_METADATA_MS = 5000; +const firstPlayAskedAt = new WeakMap(); +const watchedForFirstFrame = new WeakSet(); +const warnedSkipped = new WeakSet(); + +const sourceOf = (el: HTMLMediaElement): string => el.currentSrc || el.src; + +function noteFirstPlayAsk(el: HTMLMediaElement): void { + if (!watchedForFirstFrame.has(el)) { + watchedForFirstFrame.add(el); + el.addEventListener("loadeddata", () => firstPlayAskedAt.set(el, null)); + el.addEventListener("emptied", () => firstPlayAskedAt.delete(el)); + } + if (!firstPlayAskedAt.has(el)) { + firstPlayAskedAt.set(el, el.readyState > MEDIA_HAVE_METADATA ? null : performance.now()); + } +} + +function stoppedAtMetadata(el: HTMLMediaElement): boolean { + const askedAt = firstPlayAskedAt.get(el); + return ( + askedAt != null && + performance.now() - askedAt >= STOPPED_AT_METADATA_MS && + el.readyState === MEDIA_HAVE_METADATA && + el.networkState === MEDIA_NETWORK_IDLE + ); +} + +// Errored, sourceless, or stopped loading at its header since first asked to play: it can't play, and +// re-issuing play() every tick just floods rejections. Skip it until its state changes (src reload). export function isUnplayable(el: HTMLMediaElement): boolean { - return el.error != null || el.networkState === MEDIA_NETWORK_NO_SOURCE; + if (el.error != null || el.networkState === MEDIA_NETWORK_NO_SOURCE) return true; + if (!stoppedAtMetadata(el)) return false; + if (!warnedSkipped.has(el)) { + warnedSkipped.add(el); + console.warn( + `[hyperframes] skipping "${sourceOf(el)}": the browser stopped loading it after its header; the rest plays`, + ); + } + return true; } const lastRuntimeAppliedVolume = new WeakMap(); @@ -815,7 +854,10 @@ export function syncRuntimeMedia(params: { err && typeof err === "object" && "name" in err ? String((err as { name?: unknown }).name ?? "") : ""; - if (name === "NotAllowedError") params.onAutoplayBlocked?.(); + if (name === "NotAllowedError") { + firstPlayAskedAt.delete(el); + params.onAutoplayBlocked?.(); + } }); } else if (!playing && !el.paused) { el.pause();