ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-07 10:06:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): hide Windows child process consoles (#3529)

Browse Source 
Rebase #3529 onto current main. Preserve all 16 issue-scoped Studio server, lint, and CLI child-process windowsHide options, including main's PowerShell null guards and stderr suppression in orphanCleanup.

Regression tests continue to assert windowsHide at each scoped spawn site. #3476 and #3430 remain out of scope.

Co-authored-by: heygengenesis[bot] <262951085+heygengenesis[bot]@users.noreply.github.com>
Co-authored-by: miguel.sierra <229591595+miguel-heygen@users.noreply.github.com>
This commit is contained in:
heygengenesis[bot]
2026-08-31 18:11:20 -04:00
committed by GitHub
co-authored by miguel.sierra
parent 73aa71c9ec
commit 9097d539b1
23 changed files with 322 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/utils/webmAlphaCheck.test.ts
+24 -3
View File
@@ -86,13 +86,14 @@ describe("sampledAlphaIsFullyOpaque", () => {
}
async function importWithMocks(
execImpl: (cmd: string, args: readonly string[], opts?: unknown) => Buffer,
execImpl: (cmd: string, args: readonly string[], opts?: unknown) => string | Buffer,
ffmpegPath: string | null = FAKE_FFMPEG,
ffprobePath: string | null = null,
) {
vi.doMock("node:child_process", () => ({ execFileSync: execImpl }));
vi.doMock("../browser/ffmpeg.js", () => ({
findFFmpeg: () => ffmpegPath,
findFFprobe: () => null,
findFFprobe: () => ffprobePath,
}));
return await import("./webmAlphaCheck.js");
}
@@ -165,8 +166,10 @@ describe("sampledAlphaIsFullyOpaque", () => {
// Without `-c:v libvpx-vp9` BEFORE `-i`, the check would falsely report
// alpha=255 on WebMs whose alpha is genuinely present.
let capturedArgs: readonly string[] | undefined;
const { sampledAlphaIsFullyOpaque } = await importWithMocks((_cmd, args) => {
let capturedOptions: unknown;
const { sampledAlphaIsFullyOpaque } = await importWithMocks((_cmd, args, options) => {
capturedArgs = args;
capturedOptions = options;
return opaqueBuffer(3);
});
sampledAlphaIsFullyOpaque(FAKE_WEBM);
@@ -182,5 +185,23 @@ describe("sampledAlphaIsFullyOpaque", () => {
expect(argList).toContain("-frames:v");
expect(argList[argList.indexOf("-frames:v") + 1]).toBe("3");
expect(argList).toContain("rawvideo");
expect(capturedOptions).toEqual(expect.objectContaining({ windowsHide: true }));
});
it("hides the ffprobe console window", async () => {
let capturedOptions: unknown;
const { warnIfWebmAlphaDropped } = await importWithMocks(
(_cmd, _args, options) => {
capturedOptions = options;
return JSON.stringify({ streams: [{ codec_name: "vp9", tags: {} }] });
},
null,
"/fake/bin/ffprobe",
);
vi.spyOn(console, "warn").mockImplementation(() => {});
warnIfWebmAlphaDropped(FAKE_WEBM, "webm", false);
expect(capturedOptions).toEqual(expect.objectContaining({ windowsHide: true }));
});
});