fix(cli): report available memory instead of free memory in doctor (#1204)

os.freemem() on macOS returns only truly free pages (~0.1 GB on a 24 GB machine), ignoring inactive/purgeable/speculative pages the kernel reclaims on demand. This caused a false "Low memory" warning on every macOS machine. Add getAvailableMemoryMb() that uses vm_stat on macOS and MemAvailable from /proc/meminfo on Linux, falling back to os.freemem() elsewhere. Also trim FFmpeg/FFprobe version strings to just "toolname X.Y.Z" instead of the full copyright line.
2026-09-08 19:06:04 +00:00 · 2026-06-04 18:23:02 -04:00
parent 0870394d20
commit 9679503158
4 changed files with 217 additions and 13 deletions
@@ -0,0 +1,112 @@
+import { describe, expect, it, vi, beforeEach, afterEach } from "vitest";
+
+beforeEach(() => {
+  vi.resetModules();
+});
+
+afterEach(() => {
+  vi.restoreAllMocks();
+});
+
+describe("getAvailableMemoryMb", () => {
+  it("parses vm_stat on macOS to compute available memory", async () => {
+    vi.doMock("node:os", async () => ({
+      ...(await vi.importActual<typeof import("node:os")>("node:os")),
+      platform: () => "darwin",
+      freemem: () => 100 * 1024 * 1024,
+    }));
+    vi.doMock("node:child_process", async () => ({
+      ...(await vi.importActual<typeof import("node:child_process")>("node:child_process")),
+      execSync: (_cmd: string) =>
+        [
+          "Mach Virtual Memory Statistics: (page size of 16384 bytes)",
+          "Pages free:                             5000.",
+          "Pages active:                         200000.",
+          "Pages inactive:                       100000.",
+          "Pages speculative:                      2000.",
+          "Pages throttled:                           0.",
+          "Pages wired down:                     150000.",
+          "Pages purgeable:                        3000.",
+        ].join("\n"),
+    }));
+
+    const { getAvailableMemoryMb } = await import("./system.js");
+    const result = getAvailableMemoryMb();
+
+    // (5000 + 100000 + 3000 + 2000) * 16384 = 110000 * 16384 = 1,802,240,000 bytes
+    // 1,802,240,000 / (1024 * 1024) = ~1718 MB
+    expect(result).toBe(Math.trunc((110000 * 16384) / (1024 * 1024)));
+  });
+
+  it("falls back to freemem on macOS when vm_stat fails", async () => {
+    vi.doMock("node:os", async () => ({
+      ...(await vi.importActual<typeof import("node:os")>("node:os")),
+      platform: () => "darwin",
+      freemem: () => 4 * 1024 * 1024 * 1024,
+    }));
+    vi.doMock("node:child_process", async () => ({
+      ...(await vi.importActual<typeof import("node:child_process")>("node:child_process")),
+      execSync: () => {
+        throw new Error("vm_stat not found");
+      },
+    }));
+
+    const { getAvailableMemoryMb } = await import("./system.js");
+    expect(getAvailableMemoryMb()).toBe(4096);
+  });
+
+  it("reads MemAvailable from /proc/meminfo on Linux", async () => {
+    vi.doMock("node:os", async () => ({
+      ...(await vi.importActual<typeof import("node:os")>("node:os")),
+      platform: () => "linux",
+      freemem: () => 100 * 1024 * 1024,
+    }));
+    vi.doMock("node:fs", async () => ({
+      ...(await vi.importActual<typeof import("node:fs")>("node:fs")),
+      readFileSync: (path: string, _enc: string) => {
+        if (path === "/proc/meminfo") {
+          return [
+            "MemTotal:       16384000 kB",
+            "MemFree:          512000 kB",
+            "MemAvailable:    8192000 kB",
+            "Buffers:          256000 kB",
+          ].join("\n");
+        }
+        throw new Error(`unexpected path: ${path}`);
+      },
+    }));
+
+    const { getAvailableMemoryMb } = await import("./system.js");
+    // 8192000 kB / 1024 = 8000 MB
+    expect(getAvailableMemoryMb()).toBe(8000);
+  });
+
+  it("falls back to freemem on Linux when /proc/meminfo is unreadable", async () => {
+    vi.doMock("node:os", async () => ({
+      ...(await vi.importActual<typeof import("node:os")>("node:os")),
+      platform: () => "linux",
+      freemem: () => 2 * 1024 * 1024 * 1024,
+    }));
+    vi.doMock("node:fs", async () => ({
+      ...(await vi.importActual<typeof import("node:fs")>("node:fs")),
+      readFileSync: (path: string) => {
+        if (path === "/proc/meminfo") throw new Error("ENOENT");
+        throw new Error(`unexpected path: ${path}`);
+      },
+    }));
+
+    const { getAvailableMemoryMb } = await import("./system.js");
+    expect(getAvailableMemoryMb()).toBe(2048);
+  });
+
+  it("falls back to freemem on unsupported platforms", async () => {
+    vi.doMock("node:os", async () => ({
+      ...(await vi.importActual<typeof import("node:os")>("node:os")),
+      platform: () => "win32",
+      freemem: () => 6 * 1024 * 1024 * 1024,
+    }));
+
+    const { getAvailableMemoryMb } = await import("./system.js");
+    expect(getAvailableMemoryMb()).toBe(6144);
+  });
+});