diff --git a/plans/audio-review-fixes-handoff.md b/plans/audio-review-fixes-handoff.md index 0e30c3eae0..dbb446c47c 100644 --- a/plans/audio-review-fixes-handoff.md +++ b/plans/audio-review-fixes-handoff.md @@ -43,14 +43,33 @@ is a harness split, not breakage. Run BOTH: ```bash cd packages/producer ./node_modules/.bin/vitest run # 534 passing, 50 files fail to collect -bun test ./src/services/distributed/plan.test.ts ./src/plan-parity-*.test.ts \ - ./src/services/render/stages/*.test.ts # 203 passing + +# 203 passing. The list is explicit on purpose — see the two traps below. +bun test \ + ./src/services/distributed/plan.test.ts \ + ./src/services/distributed/planV2.test.ts \ + ./src/plan-parity-analysis.test.ts \ + ./src/plan-parity-contract.test.ts \ + ./src/plan-parity-harness.test.ts \ + ./src/plan-parity-fixture.test.ts \ + ./src/services/render/stages/mutedParity.test.ts \ + ./src/services/render/stages/probeStage.test.ts \ + ./src/services/render/stages/probeFailures.test.ts \ + ./src/services/render/stages/encodeStage.test.ts \ + ./src/services/render/stages/planHash.test.ts \ + ./src/services/render/stages/captureStreamingStage.test.ts ``` -Note the leading `./` — without it `bun test` reads the arguments as name -filters and runs nothing while exiting 0. A bare `bun test` is worse than -useless here: it also picks up the vitest files, which it cannot run, so it -reports ~37 phantom failures. +Two ways to get this wrong, both measured: + +1. **The leading `./` is required.** Without it `bun test` reads the arguments + as name filters, runs nothing, and exits 0. +2. **Do not glob a directory, and do not run a bare `bun test`.** Both sweep in + the vitest files sitting beside these, which bun cannot load — a + `stages/*.test.ts` glob reports 37 failures and 5 errors that are purely the + wrong runner meeting the wrong file. The 49 bun files and the vitest files + are interleaved through the same directories; there is no path that + separates them, which is why the list is spelled out. The bun half matters for the `b1faacb3a` audioStage change specifically: `plan.test.ts` and the `plan-parity-*` suite cover