mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-12 07:09:59 +00:00
feat(cli): forward feedback submissions to the backend feedback endpoint (#2003)
* feat(cli): forward feedback submissions to backend endpoint * fix(cli): truncate feedback fields to backend caps + ack before forwarding Addresses PR review (via): - Truncate comment (2000) / cli_version (100) / env (500) to the backend DTO caps before POSTing, so a pasted stack trace is forwarded truncated instead of rejected with a 422 the best-effort path swallows silently. - Print "Thanks for the feedback!" before the best-effort forward so the ack isn't blocked behind the (bounded) network call. * fix(cli): type feedback fetch mock
This commit is contained in:
@@ -7,6 +7,7 @@ import { trackRenderFeedback } from "../telemetry/events.js";
|
||||
import { shouldTrack, flush } from "../telemetry/client.js";
|
||||
import { getDoctorSummary } from "../telemetry/feedback.js";
|
||||
import { publishProjectArchive } from "../utils/publishProject.js";
|
||||
import { submitFeedback } from "../utils/submitFeedback.js";
|
||||
import { buildIssueUrl, HYPERFRAMES_REPO_URL } from "../utils/feedbackIssue.js";
|
||||
import { VERSION } from "../version.js";
|
||||
import { c } from "../ui/colors.js";
|
||||
@@ -164,7 +165,10 @@ export default defineCommand({
|
||||
trackRenderFeedback({ rating, comment, doctorSummary });
|
||||
|
||||
await flush();
|
||||
// Ack first so the user isn't kept waiting on the best-effort forward (which
|
||||
// is bounded to a few seconds and never surfaces an error either way).
|
||||
console.log(c.dim("Thanks for the feedback!"));
|
||||
await submitFeedback({ rating, comment, cliVersion: VERSION, env: doctorSummary });
|
||||
|
||||
if (args["file-issue"] === true) {
|
||||
await fileGithubIssue({
|
||||
|
||||
Reference in New Issue
Block a user