ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-04 07:19:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(studio): read animation cache keys through their owner

Browse Source 
The timeline-element animation lookup rebuilt the three cache-key variants
by hand. elementCacheKeys already owns that list for the writers, so this
reader takes it from there instead of drifting from it.
This commit is contained in:
Miguel Angel Simon Sierra
2026-07-27 19:52:07 +02:00
parent 8f66b06d12
commit a423c9300e
2 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/studio/src/components/nle/useTimelineEditCallbacks.ts
+8 -6
View File
@@ -11,6 +11,7 @@ import {
} from "../../contexts/DomEditContext"; } from "../../contexts/DomEditContext";
import { resolveTweenStart, resolveTweenDuration } from "../../utils/globalTimeCompiler"; import { resolveTweenStart, resolveTweenDuration } from "../../utils/globalTimeCompiler";
import { resolveClipTimingBasis } from "../../hooks/useGsapTweenCache"; import { resolveClipTimingBasis } from "../../hooks/useGsapTweenCache";
import { elementCacheKeys } from "../../hooks/gsapKeyframeCacheHelpers";
import { resolveKeyframeRetime } from "../editor/keyframeRetime"; import { resolveKeyframeRetime } from "../editor/keyframeRetime";
import type { DomEditSelection } from "../editor/domEditingTypes"; import type { DomEditSelection } from "../editor/domEditingTypes";
import type { TimelineMoveOperation } from "../../hooks/timelineMoveAdapter"; import type { TimelineMoveOperation } from "../../hooks/timelineMoveAdapter";
@@ -121,12 +122,13 @@ export function useTimelineEditCallbacks({
const { gsapAnimations } = usePlayerStore.getState(); const { gsapAnimations } = usePlayerStore.getState();
const { sourceFile, domId } = splitTimelineElementKey(elementKey); const { sourceFile, domId } = splitTimelineElementKey(elementKey);
const scope = sourceFile ?? activeCompPath ?? "index.html"; const scope = sourceFile ?? activeCompPath ?? "index.html";
return ( // elementCacheKeys owns the key-variant list the writers use; reading it
gsapAnimations.get(`${scope}#${domId}`) ?? // back by hand here is how the two sides drift.
gsapAnimations.get(`index.html#${domId}`) ?? for (const key of elementCacheKeys(scope, domId)) {
gsapAnimations.get(domId) ?? const animations = gsapAnimations.get(key);
[] if (animations) return animations;
); }
return [];
}, },
[activeCompPath], [activeCompPath],
); );
packages/studio/src/hooks/gsapKeyframeCacheHelpers.ts
+2 -1
View File
@@ -113,7 +113,8 @@ export function clearKeyframeCacheForFile(sourceFile: string): void {
} }
} }
function elementCacheKeys(sourceFile: string, elementId: string): string[] { /** Every cache key a write for this element sets, in read-preference order. */
export function elementCacheKeys(sourceFile: string, elementId: string): string[] {
return sourceFile === "index.html" return sourceFile === "index.html"
? [`index.html#${elementId}`, elementId] ? [`index.html#${elementId}`, elementId]
: [`${sourceFile}#${elementId}`, `index.html#${elementId}`, elementId]; : [`${sourceFile}#${elementId}`, `index.html#${elementId}`, elementId];