ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-03 23:03:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address review — PostHog key comment, flushTimer cleanup, TOCTOU, type guard

Browse Source
This commit is contained in:
Miguel Ángel
2026-05-20 17:10:58 -04:00
parent 45999226a3
commit a58a881d2e
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/studio-api/helpers/sourceMutation.ts
+6 -1
View File
@@ -55,6 +55,11 @@ export function removeElementFromHtml(source: string, target: SourceMutationTarg
return wrappedFragment ? document.body.innerHTML || "" : document.toString();
}
function isHTMLElement(el: Element): boolean {
const HTMLEl = el.ownerDocument.defaultView?.HTMLElement;
return HTMLEl ? el instanceof HTMLEl : "style" in el;
}
export interface PatchOperation {
type: "inline-style" | "attribute" | "html-attribute" | "text-content";
property: string;
@@ -68,7 +73,7 @@ export function patchElementInHtml(
): string {
const { document, wrappedFragment } = parseSourceDocument(source);
const el = findTargetElement(document, target);
if (!el || !(el instanceof (el.ownerDocument.defaultView?.HTMLElement ?? Element))) return source;
if (!el || !isHTMLElement(el)) return source;
const htmlEl = el as unknown as HTMLElement;
for (const op of operations) {